From c3d2e0a4e5df3cf647440a4c12a5e7a22598cc40 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Le=20Bihan?= <clement.lebihan773@gmail.com>
Date: Mon, 20 Mar 2023 00:28:03 +0100
Subject: [PATCH] updating the showNoteNames policy down to PianoKey

---
 front/components/VirtualPiano/Octave.tsx       | 2 ++
 front/components/VirtualPiano/PianoKeyComp.tsx | 6 +++---
 front/components/VirtualPiano/VirtualPiano.tsx | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/front/components/VirtualPiano/Octave.tsx b/front/components/VirtualPiano/Octave.tsx
index 6b76098..bec5028 100644
--- a/front/components/VirtualPiano/Octave.tsx
+++ b/front/components/VirtualPiano/Octave.tsx
@@ -104,6 +104,7 @@ const Octave = (props: OctaveProps) => {
 						<PianoKeyComp
 							key={i} 
 							pianoKey={key}
+							showNoteName={showNoteNames}
 							bg={isHighlighted ? highlightColor :whiteKeyBg}
 							bgPressed={isHighlighted ? highlightColor : whiteKeyBgPressed}
 							bgHovered={isHighlighted ? highlightColor : whiteKeyBgHovered}
@@ -129,6 +130,7 @@ const Octave = (props: OctaveProps) => {
 						<PianoKeyComp
 							key={i}
 							pianoKey={key}
+							showNoteName={showNoteNames}
 							bg={isHighlighted ? highlightColor : blackKeyBg}
 							bgPressed={isHighlighted ? highlightColor : blackKeyBgPressed}
 							bgHovered={isHighlighted ? highlightColor : blackKeyBgHovered}
diff --git a/front/components/VirtualPiano/PianoKeyComp.tsx b/front/components/VirtualPiano/PianoKeyComp.tsx
index e55e40e..f1bd7f9 100644
--- a/front/components/VirtualPiano/PianoKeyComp.tsx
+++ b/front/components/VirtualPiano/PianoKeyComp.tsx
@@ -14,7 +14,7 @@ import {
 type PianoKeyProps = {
 	key?: Key;
 	pianoKey: PianoKey;
-	showNoteNames: NoteNameBehavior;
+	showNoteName: NoteNameBehavior;
 	bg: string;
 	bgPressed: string;
 	bgHovered: string;
@@ -43,7 +43,7 @@ const isNoteVisible = (
 const PianoKeyComp = ({
 	key,
 	pianoKey,
-	showNoteNames,
+	showNoteName,
 	bg,
 	bgPressed,
 	bgHovered,
@@ -85,7 +85,7 @@ const PianoKeyComp = ({
 					justifyContent="flex-end"
 					alignItems="center"
 				>
-					{isNoteVisible(showNoteNames, isPressed, isHovered) && (
+					{isNoteVisible(showNoteName, isPressed, isHovered) && (
 						<Text {...textProps}>{keyToStr(pianoKey, false)}</Text>
 					)}
 				</Box>
diff --git a/front/components/VirtualPiano/VirtualPiano.tsx b/front/components/VirtualPiano/VirtualPiano.tsx
index 9c84ab7..77c93af 100644
--- a/front/components/VirtualPiano/VirtualPiano.tsx
+++ b/front/components/VirtualPiano/VirtualPiano.tsx
@@ -84,10 +84,10 @@ VirtualPiano.defaultProps = {
 	startNote: Note.C,
 	endOctave: 2,
 	endNote: Note.B,
-	showNoteNames: "onhover",
+	showNoteNames: NoteNameBehavior.onpress,
 	highlightedNotes: [],
 	highlightColor: "red",
-	specialHighlightedNotes: [],
+	specialHighlightedNotes: [Note.D, Note.G],
 	specialHighlightColor: "blue",
 	showOctaveNumbers: true,
 	keyPressStyle: "subtle",