From a81cf8ece0b2ae9397b6c737a8b482ceb9010e83 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Cl=C3=A9ment=20Le=20Bihan?= <clement.lebihan773@gmail.com>
Date: Thu, 27 May 2021 23:00:36 +0200
Subject: [PATCH] adding ui details (and great visuals fixes)

---
 sources/Debugger/TileViewer/TileViewer.cpp | 39 ++++++++++-
 sources/Debugger/TileViewer/TileViewer.hpp |  2 +
 ui/tileView.ui                             | 80 +++++++++++++++++++---
 3 files changed, 110 insertions(+), 11 deletions(-)

diff --git a/sources/Debugger/TileViewer/TileViewer.cpp b/sources/Debugger/TileViewer/TileViewer.cpp
index 76e4990..48484f6 100644
--- a/sources/Debugger/TileViewer/TileViewer.cpp
+++ b/sources/Debugger/TileViewer/TileViewer.cpp
@@ -38,8 +38,13 @@ namespace ComSquare::Debugger
 		QMainWindow::connect(this->_ui.NbColumns, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int nb) -> void { this->setNbColumns(nb); });
 		QMainWindow::connect(this->_ui.ByteSize, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int nb) -> void { this->setRenderSize(nb); });
 		QMainWindow::connect(this->_ui.Address, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int nb) -> void { this->setRamOffset(nb); });
+		QMainWindow::connect(this->_ui.PaletteIndex, QOverload<int>::of(&QSpinBox::valueChanged), this, [this](int nb) -> void { this->setPaletteIndex(nb); });
+		QMainWindow::connect(this->_ui.BppFormat, QOverload<int>::of(&QComboBox::currentIndexChanged), this, [this](int index) -> void { this->_bppChangeUIHandler(index); });
+
+		// used to setup ui restrictions
+		this->setBpp(this->getBpp());
 		this->_window->show();
-		QEvent::registerEventType();
+		this->internalUpdate();
 	}
 
 	void TileViewer::disableViewer()
@@ -65,11 +70,30 @@ namespace ComSquare::Debugger
 	void TileViewer::setPaletteIndex(int paletteIndex)
 	{
 		this->_tileRenderer.setPaletteIndex(paletteIndex);
+		this->internalUpdate();
 	}
 
 	void TileViewer::setBpp(int bpp)
 	{
+		this->_ui.PaletteIndex->setDisabled(bpp > 4);
+		switch (bpp) {
+		case 8:
+			this->_ui.PaletteIndex->setValue(0);
+			break;
+		case 4:
+			this->_ui.PaletteIndex->setMaximum(15);
+			if (this->_ui.PaletteIndex->value() > 15) {
+				this->_ui.PaletteIndex->setValue(15);
+			}
+			break;
+		case 2:
+		default:
+			bpp = 2;
+			this->_ui.PaletteIndex->setMaximum(63);
+			break;
+		}
 		this->_tileRenderer.setBpp(bpp);
+		this->internalUpdate();
 	}
 
 	void TileViewer::setNbColumns(int nbColumns)
@@ -108,5 +132,18 @@ namespace ComSquare::Debugger
 	void TileViewer::setRamOffset(int offset)
 	{
 		this->_tileRenderer.setRamOffset(offset);
+		this->internalUpdate();
+	}
+
+	void TileViewer::_bppChangeUIHandler(int index)
+	{
+		switch (index) {
+		case 0: return this->setBpp(2);
+		case 1: return this->setBpp(4);
+		case 2: return this->setBpp(8);
+		default:
+			break;
+		}
+		// TODO error handling
 	}
 }
\ No newline at end of file
diff --git a/sources/Debugger/TileViewer/TileViewer.hpp b/sources/Debugger/TileViewer/TileViewer.hpp
index e1e90a6..9f21ff8 100644
--- a/sources/Debugger/TileViewer/TileViewer.hpp
+++ b/sources/Debugger/TileViewer/TileViewer.hpp
@@ -38,6 +38,8 @@ namespace ComSquare::Debugger
 		//std::unique_ptr<Renderer::QtSFML> _sfWidget;
 		//! @brief The tile renderer
 		TileRenderer _tileRenderer;
+		//! @brief Change the bpp from the index given by the ui (QT combo box)
+		void _bppChangeUIHandler(int index);
 	public:
 		//! @brief Called when the window is closed. Turn off the debugger.
 		void disableViewer();
diff --git a/ui/tileView.ui b/ui/tileView.ui
index 65da1ef..0ad6a39 100644
--- a/ui/tileView.ui
+++ b/ui/tileView.ui
@@ -38,7 +38,26 @@
          </widget>
         </item>
         <item row="0" column="1">
-         <widget class="QSpinBox" name="Address"/>
+         <widget class="QSpinBox" name="Address">
+          <property name="prefix">
+           <string notr="true">0x</string>
+          </property>
+          <property name="minimum">
+           <number>0</number>
+          </property>
+          <property name="maximum">
+           <number>999999</number>
+          </property>
+          <property name="singleStep">
+           <number>4096</number>
+          </property>
+          <property name="stepType">
+           <enum>QAbstractSpinBox::DefaultStepType</enum>
+          </property>
+          <property name="displayIntegerBase">
+           <number>16</number>
+          </property>
+         </widget>
         </item>
         <item row="2" column="0">
          <widget class="QLabel" name="label_3">
@@ -52,26 +71,50 @@
           <property name="enabled">
            <bool>true</bool>
           </property>
+          <property name="suffix">
+           <string/>
+          </property>
+          <property name="prefix">
+           <string notr="true">0x</string>
+          </property>
           <property name="minimum">
-           <number>100</number>
+           <number>0</number>
           </property>
           <property name="maximum">
-           <number>10000</number>
+           <number>999999999</number>
+          </property>
+          <property name="singleStep">
+           <number>4096</number>
+          </property>
+          <property name="stepType">
+           <enum>QAbstractSpinBox::DefaultStepType</enum>
           </property>
           <property name="value">
-           <number>5000</number>
+           <number>20480</number>
+          </property>
+          <property name="displayIntegerBase">
+           <number>16</number>
           </property>
          </widget>
         </item>
         <item row="4" column="0">
          <widget class="QLabel" name="label_2">
+          <property name="cursor">
+           <cursorShape>ArrowCursor</cursorShape>
+          </property>
           <property name="text">
            <string>Columns</string>
           </property>
+          <property name="buddy">
+           <cstring></cstring>
+          </property>
          </widget>
         </item>
         <item row="4" column="1">
          <widget class="QSpinBox" name="NbColumns">
+          <property name="readOnly">
+           <bool>false</bool>
+          </property>
           <property name="specialValueText">
            <string/>
           </property>
@@ -81,16 +124,19 @@
           <property name="value">
            <number>16</number>
           </property>
-         </widget>
-        </item>
-        <item row="5" column="0">
-         <widget class="QLabel" name="label_4">
-          <property name="text">
-           <string>Format</string>
+          <property name="displayIntegerBase">
+           <number>10</number>
           </property>
          </widget>
         </item>
         <item row="5" column="1">
+         <widget class="QSpinBox" name="PaletteIndex">
+          <property name="maximum">
+           <number>255</number>
+          </property>
+         </widget>
+        </item>
+        <item row="3" column="1">
          <widget class="QComboBox" name="BppFormat">
           <property name="currentText">
            <string>2 bpp</string>
@@ -121,6 +167,20 @@
           </item>
          </widget>
         </item>
+        <item row="3" column="0">
+         <widget class="QLabel" name="label_4">
+          <property name="text">
+           <string>Format</string>
+          </property>
+         </widget>
+        </item>
+        <item row="5" column="0">
+         <widget class="QLabel" name="label_6">
+          <property name="text">
+           <string>Palette Index</string>
+          </property>
+         </widget>
+        </item>
        </layout>
       </item>
       <item>