Merge remote-tracking branch 'origin/master' into v2-exp

textinput/textinput.go

@@ -668,7 +668,7 @@ func (m Model) View() string {
 		v += styleText(m.echoTransform(string(value[pos+1:]))) // text after cursor
 		v += m.completionView(0)                               // suggested completion
 	} else {
-		if m.canAcceptSuggestion() {
+		if m.focus && m.canAcceptSuggestion() {
 			suggestion := m.matchedSuggestions[m.currentSuggestionIndex]
 			if len(value) < len(suggestion) {
 				m.virtualCursor.TextStyle = styles.Suggestion

textinput/textinput_test.go

@@ -1,6 +1,7 @@
 package textinput
 
 import (
+	"strings"
 	"testing"
 )
 
@@ -29,6 +30,11 @@ func Test_CurrentSuggestion(t *testing.T) {
 	if suggestion != expected {
 		t.Fatalf("Error: expected first suggestion but was %s", suggestion)
 	}
+
+	textinput.Blur()
+	if strings.HasSuffix(textinput.View(), "test2") {
+		t.Fatalf("Error: suggestions should not be rendered when input isn't focused. expected \"> test\" but got \"%s\"", textinput.View())
+	}
 }
 
 func Test_SlicingOutsideCap(t *testing.T) {