zoriya/bubbles
1
0
Fork 0
mirror of https://github.com/zoriya/bubbles.git synced 2026-08-16 01:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(viewport): scroll to last line when borders (#706)

Browse Source 
If the viewport has borders, they are not currently taken into account
when calculating the viewport max y offset, which might cause the last
line to not be visible.

This is easily reproducible in `gum pager`.

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This commit is contained in:
Carlos Alexandro Becker
2025-01-21 19:31:03 -03:00
committed by GitHub
parent e3ce11a65f
commit 7ab08fb438
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
viewport/viewport.go
+1 -1
View File
@@ -140,7 +140,7 @@ func (m *Model) SetContent(s string) {
// maxYOffset returns the maximum possible value of the y-offset based on the // maxYOffset returns the maximum possible value of the y-offset based on the
// viewport's content and set height. // viewport's content and set height.
func (m Model) maxYOffset() int { func (m Model) maxYOffset() int {
return max(0, len(m.lines)-m.Height) return max(0, len(m.lines)-m.Height+m.Style.GetVerticalFrameSize())
} }
// visibleLines returns the lines that should currently be visible in the // visibleLines returns the lines that should currently be visible in the