diff --git a/table/table_test.go b/table/table_test.go index 4b08d4f..c76c11e 100644 --- a/table/table_test.go +++ b/table/table_test.go @@ -136,7 +136,6 @@ func TestSetCursor(t *testing.T) { func TestTableAlignment(t *testing.T) { t.Run("No border", func(t *testing.T) { s := DefaultStyles() - s.Border = lipgloss.HiddenBorder() s.BorderHeader = false biscuits := New( WithHeight(5), @@ -152,12 +151,20 @@ func TestTableAlignment(t *testing.T) { }), WithStyles(s), ) + + // unset borders for styling + // TODO maybe do this in View or something instead if border type is hidden? + biscuits.table. + BorderTop(false). + BorderBottom(false). + BorderLeft(false). + BorderRight(false). + BorderColumn(false) got := ansi.Strip(biscuits.View()) golden.RequireEqual(t, []byte(got)) }) t.Run("With border", func(t *testing.T) { biscuits := New( - WithHeight(5), WithColumns([]Column{ {Title: "Name", Width: 25}, {Title: "Country of Origin", Width: 16}, @@ -168,6 +175,7 @@ func TestTableAlignment(t *testing.T) { {"Tim Tams", "Australia", "No"}, {"Hobnobs", "UK", "Yes"}, }), + WithHeight(10), WithStyles(DefaultStyles()), ) got := ansi.Strip(biscuits.View()) diff --git a/table/testdata/TestTableAlignment/No_border.golden b/table/testdata/TestTableAlignment/No_border.golden index a4664a8..5184ba7 100644 --- a/table/testdata/TestTableAlignment/No_border.golden +++ b/table/testdata/TestTableAlignment/No_border.golden @@ -1,5 +1,4 @@ - Name Country of Orig… Dunk-able - Chocolate Digestives UK Yes - Tim Tams Australia No - Hobnobs UK Yes - \ No newline at end of file + Name Country of Origin Dunk-able + Chocolate Digestives UK Yes + Tim Tams Australia No + Hobnobs UK Yes \ No newline at end of file diff --git a/table/testdata/TestTableAlignment/With_border.golden b/table/testdata/TestTableAlignment/With_border.golden index 49f7909..956b1d4 100644 --- a/table/testdata/TestTableAlignment/With_border.golden +++ b/table/testdata/TestTableAlignment/With_border.golden @@ -1,8 +1,7 @@ -┌───────────────────────────────────────────────────────────┐ -│ Name Country of Orig… Dunk-able │ -│───────────────────────────────────────────────────────────│ -│ Chocolate Digestives UK Yes │ -│ Tim Tams Australia No │ -│ Hobnobs UK Yes │ -│ │ -└───────────────────────────────────────────────────────────┘ \ No newline at end of file +┌──────────────────────┬───────────────────┬───────────┐ +│ Name │ Country of Origin │ Dunk-able │ +├──────────────────────┼───────────────────┼───────────┤ +│ Chocolate Digestives │ UK │ Yes │ +│ Tim Tams │ Australia │ No │ +│ Hobnobs │ UK │ Yes │ +└──────────────────────┴───────────────────┴───────────┘ \ No newline at end of file