zoriya/bubbles
1
0
Fork 0
mirror of https://github.com/zoriya/bubbles.git synced 2026-08-16 01:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(textinput): reduce allocations

Browse Source 
As the number of items in `suggestions` and `m.suggestions` is known,
we can use `make` with the expected size instead of appending, which
requires more allocations as the slice grows.
This commit is contained in:
naglis
2024-01-08 12:07:49 -05:00
committed by Maas Lalani
parent 1ba1200c31
commit ec883029c8
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
textinput/textinput.go
+6 -7
View File
@@ -259,10 +259,9 @@ func (m *Model) Reset() {
// SetSuggestions sets the suggestions for the input. // SetSuggestions sets the suggestions for the input.
func (m *Model) SetSuggestions(suggestions []string) { func (m *Model) SetSuggestions(suggestions []string) {
m.suggestions = [][]rune{} m.suggestions = make([][]rune, len(suggestions))
for i, s := range suggestions {
for _, s := range suggestions { m.suggestions[i] = []rune(s)
m.suggestions = append(m.suggestions, []rune(s))
} }
m.updateSuggestions() m.updateSuggestions()
@@ -820,9 +819,9 @@ func (m Model) completionView(offset int) string {
// AvailableSuggestions returns the list of available suggestions. // AvailableSuggestions returns the list of available suggestions.
func (m *Model) AvailableSuggestions() []string { func (m *Model) AvailableSuggestions() []string {
suggestions := []string{} suggestions := make([]string, len(m.suggestions))
for _, s := range m.suggestions { for i, s := range m.suggestions {
suggestions = append(suggestions, string(s)) suggestions[i] = string(s)
} }
return suggestions return suggestions