zoriya/go-astisub
1
0
Fork 0
mirror of https://github.com/zoriya/go-astisub.git synced 2026-08-16 02:33:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

TTML: Fixed improper spacing between captions (#43)

Browse Source 
* 1. Fixed improper spacing between captions while converting TTML -> VTT

2. Added String To Pointer utility.

3. Converted TTML style attributes to pointers

4. Fixed Webvtt not using parent style attributes in region

* 1. Fixed Test cases
2. Fixed SRT and STL strings join

* 1. Removed Util
2. Added Regex to remove multiple space
3. In ttml.go update 'getStyleAttributes()' to 'newStyleAttributesFromTTMLInStyleAttributes()'
4. Using go-astikit to convert string to string pointer.

* Improper spacing fix

* Improper spacing fix

* Added Space in TTML out.
Added comments

* Added space to fix unit test

* update go.sum

* update go.sum

* Update go.sum

* Update go.sum
This commit is contained in:
discovery-avishekgulshan
2021-06-14 17:36:23 +02:00
committed by GitHub
parent 7452768c2b
commit 982542a681
8 changed files with 163 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files
testdata/example-out.ttml
Vendored
+2 -2
View File
@@ -23,8 +23,8 @@
<p begin="00:02:04.080" end="00:02:07.120" region="region_2">
<span>MAN:</span>
<br></br>
<span>How did we</span>
<span style="style_1" tts:color="green">end up</span>
<span>How did we </span>
<span style="style_1" tts:color="green">end up </span>
<span>here?</span>
</p>
<p begin="00:02:12.160" end="00:02:15.200" region="region_1">