zoriya/jj.nvim
1
0
Fork 0
mirror of https://github.com/zoriya/jj.nvim.git synced 2026-08-05 10:46:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent invalid buffer access in terminal on_exit callbacks

Browse Source 
When closing a terminal buffer (floating or regular), a race condition
could occur where the BufWipeout/BufDelete autocmd clears the buffer
reference, but the job's on_exit handler later tries to operate on it
via vim.schedule. This caused 'Invalid buffer' errors.

Add validity checks in both floating and regular buffer on_exit
handlers to safely handle the case where the buffer has already been
cleaned up.
This commit is contained in:
NicolasGB
2025-12-11 17:01:46 +11:00
parent ddfd6e0b56
commit 43b5a81771
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lua/jj/ui/terminal.lua
+8 -2
View File
@@ -179,8 +179,10 @@ function M.run_floating(cmd, keymaps)
end,
on_exit = function(_, _) --[[ exit_code ]]
vim.schedule(function()
buffer.set_modifiable(state.floating_buf, false)
buffer.stop_insert(state.floating_buf)
if state.floating_buf and vim.api.nvim_buf_is_valid(state.floating_buf) then
buffer.set_modifiable(state.floating_buf, false)
buffer.stop_insert(state.floating_buf)
end
end)
end,
})
@@ -309,6 +311,10 @@ function M.run(cmd, keymaps)
end,
on_exit = function(_, exit_code)
vim.schedule(function()
-- Check buffer still exists (it might have been closed)
if not state.buf or not vim.api.nvim_buf_is_valid(state.buf) then
return
end
-- Store the subcommand on successful exit
if exit_code == 0 then
state.buf_cmd = cmd[2] or nil