From 5f2adff8d6847c53a9913c839e6b1203a9218bdd Mon Sep 17 00:00:00 2001
From: ItsLemmy <studio@quadbyte.net>
Date: Mon, 10 Nov 2025 13:59:20 -0500
Subject: [PATCH] Cava: removed some non fruitful optimizations

---
 Services/Media/CavaService.qml | 29 ++---------------------------
 1 file changed, 2 insertions(+), 27 deletions(-)

diff --git a/Services/Media/CavaService.qml b/Services/Media/CavaService.qml
index 8e58c92e..3383b096 100644
--- a/Services/Media/CavaService.qml
+++ b/Services/Media/CavaService.qml
@@ -26,13 +26,7 @@ Singleton {
   property int idleFrameCount: 0
   readonly property int idleThreshold: 30 // Frames of silence before considered idle (0.5s at 60fps)
 
-  // Frame skipping for GPU optimization - skip every Nth frame when playing
-  property int frameCounter: 0
-  readonly property int frameSkip: 1 // Update every N frames (1 = no skip, 2 = every other frame, etc)
-
-  // Change detection - only update if values changed significantly
-  property var lastValues: Array(barsCount).fill(0)
-  readonly property real changeThreshold: 0.005 // Minimum change (1%) to trigger update
+  // Simple config
   property var config: ({
                           "general": {
                             "bars": barsCount,
@@ -101,7 +95,6 @@ Singleton {
               root.isIdle = true
               // Set all values to 0 one final time
               root.values = Array(root.barsCount).fill(0)
-              root.lastValues = Array(root.barsCount).fill(0)
               Logger.d("Cava", "Idle detected - stopped rendering")
             }
             // Don't update values while idle
@@ -116,26 +109,8 @@ Singleton {
           }
         }
 
-        // Frame skipping optimization - skip frames to reduce GPU load
-        root.frameCounter++
-        if (root.frameSkip > 1 && root.frameCounter % root.frameSkip !== 0) {
-          // Skip this frame
-          return
-        }
-
-        // Change detection - only update if values changed significantly
-        let hasSignificantChange = false
-        for (var i = 0; i < newValues.length; i++) {
-          const delta = Math.abs(newValues[i] - root.lastValues[i])
-          if (delta > root.changeThreshold) {
-            hasSignificantChange = true
-            break
-          }
-        }
-
         // Update values only if there's a significant change
-        if (hasSignificantChange) {
-          root.lastValues = newValues.slice() // Copy array
+        if (!isIdle) {
           root.values = newValues
         }
       }