From 7be6ea57a515c33c82c3eb3ba2fd14084f19762b Mon Sep 17 00:00:00 2001
From: kurrycat <44340227+kurrycat2004@users.noreply.github.com>
Date: Wed, 12 Nov 2025 16:51:37 +0100
Subject: [PATCH] don't open settings when clicking on empty command custom
 button with update-text enabled

---
 Modules/Bar/Widgets/CustomButton.qml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Modules/Bar/Widgets/CustomButton.qml b/Modules/Bar/Widgets/CustomButton.qml
index 96de2515..34aa3cbd 100644
--- a/Modules/Bar/Widgets/CustomButton.qml
+++ b/Modules/Bar/Widgets/CustomButton.qml
@@ -213,7 +213,7 @@ Item {
     if (leftClickExec) {
       Quickshell.execDetached(["sh", "-c", leftClickExec])
       Logger.i("CustomButton", `Executing command: ${leftClickExec}`)
-    } else if (!hasExec) {
+    } else if (!hasExec && !leftClickUpdateText) {
       // No script was defined, open settings
       var settingsPanel = PanelService.getPanel("settingsPanel", screen)
       settingsPanel.requestedTab = SettingsPanel.Tab.Bar