From b7d40c035a56299be25cadda6ae0bc28c7e3e7c0 Mon Sep 17 00:00:00 2001 From: ItsLemmy Date: Fri, 7 Nov 2025 09:07:45 -0500 Subject: [PATCH] Wifi: fixed bug where non connected SSID would report as without internet. --- Modules/Bar/Widgets/WiFi.qml | 2 +- Modules/Panels/ControlCenter/Widgets/WiFi.qml | 2 +- Modules/Panels/WiFi/WiFiPanel.qml | 4 ++-- Services/NetworkService.qml | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Modules/Bar/Widgets/WiFi.qml b/Modules/Bar/Widgets/WiFi.qml index 19f37ed9..77000e83 100644 --- a/Modules/Bar/Widgets/WiFi.qml +++ b/Modules/Bar/Widgets/WiFi.qml @@ -51,7 +51,7 @@ Item { break } } - return connected ? NetworkService.signalIcon(signalStrength) : "wifi-off" + return connected ? NetworkService.signalIcon(signalStrength, true) : "wifi-off" } catch (error) { Logger.e("Wi-Fi", "Error getting icon:", error) return "signal_wifi_bad" diff --git a/Modules/Panels/ControlCenter/Widgets/WiFi.qml b/Modules/Panels/ControlCenter/Widgets/WiFi.qml index 8970dc45..a24f43e1 100644 --- a/Modules/Panels/ControlCenter/Widgets/WiFi.qml +++ b/Modules/Panels/ControlCenter/Widgets/WiFi.qml @@ -21,7 +21,7 @@ NIconButtonHot { break } } - return connected ? NetworkService.signalIcon(signalStrength) : "wifi-off" + return connected ? NetworkService.signalIcon(signalStrength, true) : "wifi-off" } catch (error) { Logger.e("Wi-Fi", "Error getting icon:", error) return "signal_wifi_bad" diff --git a/Modules/Panels/WiFi/WiFiPanel.qml b/Modules/Panels/WiFi/WiFiPanel.qml index b811383c..accb5782 100644 --- a/Modules/Panels/WiFi/WiFiPanel.qml +++ b/Modules/Panels/WiFi/WiFiPanel.qml @@ -23,7 +23,7 @@ SmartPanel { panelContent: Rectangle { color: Color.transparent - property real contentPreferredHeight: Math.min(preferredHeight, Math.max(240, mainColumn.implicitHeight + Style.marginL * 2)) + property real contentPreferredHeight: Math.min(preferredHeight, Math.max(280 * Style.uiScaleRatio, mainColumn.implicitHeight + Style.marginL * 2)) ColumnLayout { id: mainColumn @@ -247,7 +247,7 @@ SmartPanel { spacing: Style.marginS NIcon { - icon: NetworkService.signalIcon(modelData.signal) + icon: NetworkService.signalIcon(modelData.signal, modelData.connected) pointSize: Style.fontSizeXXL color: modelData.connected ? Color.mPrimary : Color.mOnSurface } diff --git a/Services/NetworkService.qml b/Services/NetworkService.qml index 3998e47f..4098685e 100644 --- a/Services/NetworkService.qml +++ b/Services/NetworkService.qml @@ -222,8 +222,8 @@ Singleton { } // Helper functions - function signalIcon(signal) { - if (root.internetConnectivity === "limited" || root.internetConnectivity === "portal") + function signalIcon(signal, isConnected = false) { + if (isConnected && (root.internetConnectivity === "limited" || root.internetConnectivity === "portal")) return "world-off" if (signal >= 80) return "wifi"