From 0021269d70cf9dc3c4ddb4d6e26bd826989c02ed Mon Sep 17 00:00:00 2001 From: Ryan Gribble Date: Sat, 16 Jul 2016 20:46:16 +1000 Subject: [PATCH] Remove obsolete items - RepositoriesClient - CommitStatus - RepoCollaborators - Commits - RepositoryComments --- .../Clients/IObservableRepositoriesClient.cs | 38 -------------- .../Clients/ObservableRepositoriesClient.cs | 47 ----------------- Octokit/Clients/IRepositoriesClient.cs | 38 -------------- Octokit/Clients/RepositoriesClient.cs | 50 ------------------- 4 files changed, 173 deletions(-) diff --git a/Octokit.Reactive/Clients/IObservableRepositoriesClient.cs b/Octokit.Reactive/Clients/IObservableRepositoriesClient.cs index 952dd82a..866f4956 100644 --- a/Octokit.Reactive/Clients/IObservableRepositoriesClient.cs +++ b/Octokit.Reactive/Clients/IObservableRepositoriesClient.cs @@ -150,17 +150,6 @@ namespace Octokit.Reactive /// A of . IObservable GetAllForOrg(string organization, ApiOptions options); - /// - /// A client for GitHub's Commit Status API. - /// - /// - /// See the Commit Status API documentation for more - /// details. Also check out the blog post - /// that announced this feature. - /// - [Obsolete("Use Status instead")] - IObservableCommitStatusClient CommitStatus { get; } - /// /// A client for GitHub's Commit Status API. /// @@ -187,15 +176,6 @@ namespace Octokit.Reactive /// IObservableStatisticsClient Statistics { get; } - /// - /// Client for GitHub's Repository Comments API. - /// - /// - /// See the Repository Comments API documentation for more information. - /// - [Obsolete("Comment information is now available under the Comment property. This will be removed in a future update.")] - IObservableRepositoryCommentsClient RepositoryComments { get; } - /// /// Client for GitHub's Repository Comments API. /// @@ -540,15 +520,6 @@ namespace Octokit.Reactive /// The updated IObservable EditBranch(int repositoryId, string branch, BranchUpdate update); - /// - /// A client for GitHub's Repo Collaborators. - /// - /// - /// See the Collaborators API documentation for more details - /// - [Obsolete("Collaborator information is now available under the Collaborator property. This will be removed in a future update.")] - IObservableRepoCollaboratorsClient RepoCollaborators { get; } - /// /// A client for GitHub's Repo Collaborators. /// @@ -557,15 +528,6 @@ namespace Octokit.Reactive /// IObservableRepoCollaboratorsClient Collaborator { get; } - /// - /// Client for GitHub's Repository Commits API - /// - /// - /// See the Commits API documentation for more details - /// - [Obsolete("Commit information is now available under the Commit property. This will be removed in a future update.")] - IObservableRepositoryCommitsClient Commits { get; } - /// /// Client for GitHub's Repository Commits API /// diff --git a/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs b/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs index c4839ea0..c54774af 100644 --- a/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs +++ b/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs @@ -22,20 +22,11 @@ namespace Octokit.Reactive Status = new ObservableCommitStatusClient(client); Hooks = new ObservableRepositoryHooksClient(client); Forks = new ObservableRepositoryForksClient(client); -#pragma warning disable CS0618 // Type or member is obsolete - RepoCollaborators = new ObservableRepoCollaboratorsClient(client); -#pragma warning restore CS0618 // Type or member is obsolete Collaborator = new ObservableRepoCollaboratorsClient(client); Deployment = new ObservableDeploymentsClient(client); Statistics = new ObservableStatisticsClient(client); PullRequest = new ObservablePullRequestsClient(client); -#pragma warning disable CS0618 // Type or member is obsolete - RepositoryComments = new ObservableRepositoryCommentsClient(client); -#pragma warning restore CS0618 // Type or member is obsolete Comment = new ObservableRepositoryCommentsClient(client); -#pragma warning disable CS0618 // Type or member is obsolete - Commits = new ObservableRepositoryCommitsClient(client); -#pragma warning restore CS0618 // Type or member is obsolete Commit = new ObservableRepositoryCommitsClient(client); Release = new ObservableReleasesClient(client); DeployKeys = new ObservableRepositoryDeployKeysClient(client); @@ -264,17 +255,6 @@ namespace Octokit.Reactive return _connection.GetAndFlattenAllPages(ApiUrls.OrganizationRepositories(organization), options); } - /// - /// A client for GitHub's Commit Status API. - /// - /// - /// See the Commit Status API documentation for more - /// details. Also check out the blog post - /// that announced this feature. - /// - [Obsolete("Use Status instead")] - public IObservableCommitStatusClient CommitStatus { get { return Status; } } - /// /// A client for GitHub's Commit Status API. /// @@ -301,15 +281,6 @@ namespace Octokit.Reactive /// public IObservableStatisticsClient Statistics { get; private set; } - /// - /// Client for GitHub's Repository Comments API. - /// - /// - /// See the Repository Comments API documentation for more information. - /// - [Obsolete("Comment information is now available under the Comment property. This will be removed in a future update.")] - public IObservableRepositoryCommentsClient RepositoryComments { get; private set; } - /// /// Client for GitHub's Repository Comments API. /// @@ -836,15 +807,6 @@ namespace Octokit.Reactive return _client.Commit.Compare(owner, name, @base, head).ToObservable(); } - /// - /// A client for GitHub's Repo Collaborators. - /// - /// - /// See the Collaborators API documentation for more details - /// - [Obsolete("Collaborator information is now available under the Collaborator property. This will be removed in a future update.")] - public IObservableRepoCollaboratorsClient RepoCollaborators { get; private set; } - /// /// A client for GitHub's Repo Collaborators. /// @@ -853,15 +815,6 @@ namespace Octokit.Reactive /// public IObservableRepoCollaboratorsClient Collaborator { get; private set; } - /// - /// Client for GitHub's Repository Commits API - /// - /// - /// See the Commits API documentation for more details - /// - [Obsolete("Commit information is now available under the Commit property. This will be removed in a future update.")] - public IObservableRepositoryCommitsClient Commits { get; private set; } - /// /// Client for GitHub's Repository Commits API /// diff --git a/Octokit/Clients/IRepositoriesClient.cs b/Octokit/Clients/IRepositoriesClient.cs index 5ae6b1de..7261c45c 100644 --- a/Octokit/Clients/IRepositoriesClient.cs +++ b/Octokit/Clients/IRepositoriesClient.cs @@ -23,15 +23,6 @@ namespace Octokit /// IPullRequestsClient PullRequest { get; } - /// - /// Client for managing commit comments in a repository. - /// - /// - /// See the Repository Comments API documentation for more information. - /// - [Obsolete("Comment information is now available under the Comment property. This will be removed in a future update.")] - IRepositoryCommentsClient RepositoryComments { get; } - /// /// Client for managing commit comments in a repository. /// @@ -254,17 +245,6 @@ namespace Octokit /// A of . Task> GetAllForOrg(string organization, ApiOptions options); - /// - /// A client for GitHub's Commit Status API. - /// - /// - /// See the Commit Status API documentation for more - /// details. Also check out the blog post - /// that announced this feature. - /// - [Obsolete("Use Status instead")] - ICommitStatusClient CommitStatus { get; } - /// /// A client for GitHub's Commit Status API. /// @@ -287,15 +267,6 @@ namespace Octokit /// See Forks API documentation for more information. IRepositoryForksClient Forks { get; } - /// - /// A client for GitHub's Repo Collaborators. - /// - /// - /// See the Collaborators API documentation for more details - /// - [Obsolete("Collaborator information is now available under the Collaborator property. This will be removed in a future update.")] - IRepoCollaboratorsClient RepoCollaborators { get; } - /// /// A client for GitHub's Repo Collaborators. /// @@ -320,15 +291,6 @@ namespace Octokit /// IStatisticsClient Statistics { get; } - /// - /// Client for GitHub's Repository Commits API - /// - /// - /// See the Commits API documentation for more details - /// - [Obsolete("Commit information is now available under the Commit property. This will be removed in a future update.")] - IRepositoryCommitsClient Commits { get; } - /// /// Client for GitHub's Repository Commits API /// diff --git a/Octokit/Clients/RepositoriesClient.cs b/Octokit/Clients/RepositoriesClient.cs index 8508e4db..e308d2dd 100644 --- a/Octokit/Clients/RepositoriesClient.cs +++ b/Octokit/Clients/RepositoriesClient.cs @@ -25,20 +25,11 @@ namespace Octokit Status = new CommitStatusClient(apiConnection); Hooks = new RepositoryHooksClient(apiConnection); Forks = new RepositoryForksClient(apiConnection); -#pragma warning disable CS0618 // Type or member is obsolete - RepoCollaborators = new RepoCollaboratorsClient(apiConnection); -#pragma warning restore CS0618 // Type or member is obsolete Collaborator = new RepoCollaboratorsClient(apiConnection); Statistics = new StatisticsClient(apiConnection); Deployment = new DeploymentsClient(apiConnection); PullRequest = new PullRequestsClient(apiConnection); -#pragma warning disable CS0618 // Type or member is obsolete - RepositoryComments = new RepositoryCommentsClient(apiConnection); -#pragma warning restore CS0618 // Type or member is obsolete Comment = new RepositoryCommentsClient(apiConnection); -#pragma warning disable CS0618 // Type or member is obsolete - Commits = new RepositoryCommitsClient(apiConnection); -#pragma warning restore CS0618 // Type or member is obsolete Commit = new RepositoryCommitsClient(apiConnection); Release = new ReleasesClient(apiConnection); DeployKeys = new RepositoryDeployKeysClient(apiConnection); @@ -441,20 +432,6 @@ namespace Octokit return ApiConnection.GetAll(ApiUrls.OrganizationRepositories(organization), options); } - /// - /// A client for GitHub's Commit Status API. - /// - /// - /// See the Commit Status API documentation for more - /// details. Also check out the blog post - /// that announced this feature. - /// - [Obsolete("Use Status instead")] - public ICommitStatusClient CommitStatus - { - get { return Status; } - } - /// /// A client for GitHub's Commit Status API. /// @@ -477,15 +454,6 @@ namespace Octokit /// See Forks API documentation for more information. public IRepositoryForksClient Forks { get; private set; } - /// - /// A client for GitHub's Repo Collaborators. - /// - /// - /// See the Collaborators API documentation for more details - /// - [Obsolete("Collaborator information is now available under the Collaborator property. This will be removed in a future update.")] - public IRepoCollaboratorsClient RepoCollaborators { get; private set; } - /// /// A client for GitHub's Repo Collaborators. /// @@ -510,15 +478,6 @@ namespace Octokit /// public IStatisticsClient Statistics { get; private set; } - /// - /// Client for GitHub's Repository Commits API - /// - /// - /// See the Commits API documentation for more details - /// - [Obsolete("Commit information is now available under the Commit property. This will be removed in a future update.")] - public IRepositoryCommitsClient Commits { get; private set; } - /// /// Client for GitHub's Repository Commits API /// @@ -551,15 +510,6 @@ namespace Octokit /// public IPullRequestsClient PullRequest { get; private set; } - /// - /// Client for managing commit comments in a repository. - /// - /// - /// See the Repository Comments API documentation for more information. - /// - [Obsolete("Comment information is now available under the Comment property. This will be removed in a future update.")] - public IRepositoryCommentsClient RepositoryComments { get; private set; } - /// /// Client for managing commit comments in a repository. ///