From 03e14a5f14b4c641ae794860c75a1446c8544b9d Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Thu, 1 May 2014 18:51:21 +0800 Subject: [PATCH] bugfix - the State value when searching for issues is case-sensitive --- .../Clients/SearchClientTests.cs | 12 ++++++++++++ Octokit/Models/Request/IssueRequest.cs | 2 ++ Octokit/Models/Request/SearchIssuesRequest.cs | 4 ++-- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/SearchClientTests.cs b/Octokit.Tests.Integration/Clients/SearchClientTests.cs index 8a4363b5..f896d1f4 100644 --- a/Octokit.Tests.Integration/Clients/SearchClientTests.cs +++ b/Octokit.Tests.Integration/Clients/SearchClientTests.cs @@ -54,4 +54,16 @@ public class SearchClientTests Assert.NotEmpty(repos.Items); } + + [Fact] + public async Task SearchForOpenIssues() + { + var request = new SearchIssuesRequest("phone"); + request.Repo = "caliburn-micro/caliburn.micro"; + request.State = ItemState.Open; + + var repos = await _gitHubClient.Search.SearchIssues(request); + + Assert.NotEmpty(repos.Items); + } } diff --git a/Octokit/Models/Request/IssueRequest.cs b/Octokit/Models/Request/IssueRequest.cs index 7f67f38c..3be09e80 100644 --- a/Octokit/Models/Request/IssueRequest.cs +++ b/Octokit/Models/Request/IssueRequest.cs @@ -73,11 +73,13 @@ namespace Octokit /// /// Isuses that are open (default). /// + [Parameter(Value = "open")] Open, /// /// Isuses that are closed. /// + [Parameter(Value = "closed")] Closed } diff --git a/Octokit/Models/Request/SearchIssuesRequest.cs b/Octokit/Models/Request/SearchIssuesRequest.cs index 37e1ec9e..66376779 100644 --- a/Octokit/Models/Request/SearchIssuesRequest.cs +++ b/Octokit/Models/Request/SearchIssuesRequest.cs @@ -217,9 +217,9 @@ namespace Octokit parameters.Add(String.Format(CultureInfo.InvariantCulture, "involves:{0}", Involves)); } - if (State != null) + if (State.HasValue) { - parameters.Add(String.Format(CultureInfo.InvariantCulture, "state:{0}", State)); + parameters.Add(String.Format(CultureInfo.InvariantCulture, "state:{0}", State.Value.ToParameter())); } if (Labels != null)