mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-04 03:16:11 +00:00
Connection.cs fixes
This commit is contained in:
@@ -142,7 +142,7 @@ namespace Octokit
|
||||
/// <returns><seealso cref="ApiInfo"/> representing the information returned as part of an Api call</returns>
|
||||
public ApiInfo GetLastApiInfo()
|
||||
{
|
||||
// We've choosen to not wrap the _lastApiInfo in a lock. Originally the code was returning a reference - so there was a danger of
|
||||
// We've chosen to not wrap the _lastApiInfo in a lock. Originally the code was returning a reference - so there was a danger of
|
||||
// on thread writing to the object while another was reading. Now we are cloning the ApiInfo on request - thus removing the need (or overhead)
|
||||
// of putting locks in place.
|
||||
// See https://github.com/octokit/octokit.net/pull/855#discussion_r36774884
|
||||
|
||||
Reference in New Issue
Block a user