zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-06 07:16:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cloning ApiInfo object should work when some fields are null (#1580)

Browse Source 
* Adjust ApiInfo.Clone() to work even if some elements (eg ETag) are null

* Remove c# 6 language feature and do it the old school way

* Add a test for cloning ApiInfo when some fields are null

* The 3 lists can never be null anyway so remove some un-needed statements

* Add test for null RateLimit
This commit is contained in:
Ryan Gribble
2017-04-19 19:39:40 +10:00
committed by GitHub
parent f6154dac9f
commit 0a9a31dea4
2 changed files with 92 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
Octokit.Tests/Http/ApiInfoTests.cs
View File

@@ -94,6 +94,92 @@ namespace Octokit.Tests.Http
Assert.Equal(original.RateLimit.Reset, clone.RateLimit.Reset);
Assert.NotSame(original.RateLimit.Reset, clone.RateLimit.Reset);
}
[Fact]
public void CanCloneWithNullETag()
{
var original = new ApiInfo(
new Dictionary<string, Uri>
{
{
"next",
new Uri("https://api.github.com/repos/rails/rails/issues?page=4&per_page=5")
},
{
"last",
new Uri("https://api.github.com/repos/rails/rails/issues?page=131&per_page=5")
},
{
"first",
new Uri("https://api.github.com/repos/rails/rails/issues?page=1&per_page=5")
},
{
"prev",
new Uri("https://api.github.com/repos/rails/rails/issues?page=2&per_page=5")
}
},
new List<string>
{
"user"
},
new List<string>(),
null,
new RateLimit(100, 75, 1372700873)
);
var clone = original.Clone();
Assert.NotNull(clone);
Assert.Equal(4, clone.Links.Count);
Assert.Equal(1, clone.OauthScopes.Count);
Assert.Equal(0, clone.AcceptedOauthScopes.Count);
Assert.Null(clone.Etag);
Assert.Equal(100, clone.RateLimit.Limit);
Assert.Equal(75, clone.RateLimit.Remaining);
Assert.Equal(1372700873, clone.RateLimit.ResetAsUtcEpochSeconds);
}
[Fact]
public void CanCloneWithNullRateLimit()
{
var original = new ApiInfo(
new Dictionary<string, Uri>
{
{
"next",
new Uri("https://api.github.com/repos/rails/rails/issues?page=4&per_page=5")
},
{
"last",
new Uri("https://api.github.com/repos/rails/rails/issues?page=131&per_page=5")
},
{
"first",
new Uri("https://api.github.com/repos/rails/rails/issues?page=1&per_page=5")
},
{
"prev",
new Uri("https://api.github.com/repos/rails/rails/issues?page=2&per_page=5")
}
},
new List<string>
{
"user"
},
new List<string>(),
"123abc",
null
);
var clone = original.Clone();
Assert.NotNull(clone);
Assert.Equal(4, clone.Links.Count);
Assert.Equal(1, clone.OauthScopes.Count);
Assert.Equal(0, clone.AcceptedOauthScopes.Count);
Assert.Equal("123abc", clone.Etag);
Assert.Null(clone.RateLimit);
}
}
}
}
}