From 0e3d077537af49be9bc606990d9af4391f5c1b5e Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Wed, 15 Jun 2016 16:18:38 +0700 Subject: [PATCH] added new overloads --- .../IObservableIssueCommentReactionsClient.cs | 19 +++++++++++++ .../ObservableIssueCommentReactionsClient.cs | 27 +++++++++++++++++++ .../Clients/IIssueCommentReactionsClient.cs | 19 +++++++++++++ .../Clients/IssueCommentReactionsClient.cs | 27 +++++++++++++++++++ 4 files changed, 92 insertions(+) diff --git a/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs b/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs index cf03d350..3098fc7a 100644 --- a/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs +++ b/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs @@ -21,6 +21,16 @@ namespace Octokit.Reactive /// A of < see cref="Reaction"/> representing created reaction for specified comment id. IObservable Create(string owner, string name, int number, NewReaction reaction); + /// + /// Creates a reaction for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// The reaction to create + /// A of < see cref="Reaction"/> representing created reaction for specified comment id. + IObservable Create(int repositoryId, int number, NewReaction reaction); + /// /// List reactions for a specified Issue Comment /// @@ -30,5 +40,14 @@ namespace Octokit.Reactive /// The comment id /// A of s representing reactions for specified comment id. IObservable GetAll(string owner, string name, int number); + + /// + /// List reactions for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// A of s representing reactions for specified comment id. + IObservable GetAll(int repositoryId, int number); } } diff --git a/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs b/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs index afcdf2e9..44d67dfd 100644 --- a/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs +++ b/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs @@ -41,6 +41,21 @@ namespace Octokit.Reactive return _client.Create(owner, name, number, reaction).ToObservable(); } + /// + /// Creates a reaction for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// The reaction to create + /// A of < see cref="Reaction"/> representing created reaction for specified comment id. + public IObservable Create(int repositoryId, int number, NewReaction reaction) + { + Ensure.ArgumentNotNull(reaction, "reaction"); + + return _client.Create(repositoryId, number, reaction).ToObservable(); + } + /// /// List reactions for a specified Issue Comment /// @@ -56,5 +71,17 @@ namespace Octokit.Reactive return _connection.GetAndFlattenAllPages(ApiUrls.IssueCommentReactions(owner, name, number), null, AcceptHeaders.ReactionsPreview); } + + /// + /// List reactions for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// A of s representing reactions for specified comment id. + public IObservable GetAll(int repositoryId, int number) + { + return _connection.GetAndFlattenAllPages(ApiUrls.IssueCommentReactions(repositoryId, number), null, AcceptHeaders.ReactionsPreview); + } } } diff --git a/Octokit/Clients/IIssueCommentReactionsClient.cs b/Octokit/Clients/IIssueCommentReactionsClient.cs index f2bd0e84..4c79f268 100644 --- a/Octokit/Clients/IIssueCommentReactionsClient.cs +++ b/Octokit/Clients/IIssueCommentReactionsClient.cs @@ -22,6 +22,16 @@ namespace Octokit /// A representing created reaction for specified comment id. Task Create(string owner, string name, int number, NewReaction reaction); + /// + /// Creates a reaction for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// The reaction to create + /// A representing created reaction for specified comment id. + Task Create(int repositoryId, int number, NewReaction reaction); + /// /// Get all reactions for a specified Issue Comment /// @@ -31,5 +41,14 @@ namespace Octokit /// The comment id /// A of s representing reactions for specified comment id. Task> GetAll(string owner, string name, int number); + + /// + /// Get all reactions for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// A of s representing reactions for specified comment id. + Task> GetAll(int repositoryId, int number); } } diff --git a/Octokit/Clients/IssueCommentReactionsClient.cs b/Octokit/Clients/IssueCommentReactionsClient.cs index b351da89..e9b29bac 100644 --- a/Octokit/Clients/IssueCommentReactionsClient.cs +++ b/Octokit/Clients/IssueCommentReactionsClient.cs @@ -34,6 +34,21 @@ namespace Octokit return ApiConnection.Post(ApiUrls.IssueCommentReactions(owner, name, number), reaction, AcceptHeaders.ReactionsPreview); } + /// + /// Creates a reaction for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// The reaction to create + /// A representing created reaction for specified comment id. + public Task Create(int repositoryId, int number, NewReaction reaction) + { + Ensure.ArgumentNotNull(reaction, "reaction"); + + return ApiConnection.Post(ApiUrls.IssueCommentReactions(repositoryId, number), reaction, AcceptHeaders.ReactionsPreview); + } + /// /// Get all reactions for a specified Issue Comment /// @@ -49,5 +64,17 @@ namespace Octokit return ApiConnection.GetAll(ApiUrls.IssueCommentReactions(owner, name, number), AcceptHeaders.ReactionsPreview); } + + /// + /// Get all reactions for a specified Issue Comment + /// + /// https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment + /// The ID of the repository + /// The comment id + /// A of s representing reactions for specified comment id. + public Task> GetAll(int repositoryId, int number) + { + return ApiConnection.GetAll(ApiUrls.IssueCommentReactions(repositoryId, number), AcceptHeaders.ReactionsPreview); + } } }