zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-06 07:16:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle NoContent response for queued operations

Browse Source 
We didn't handle the 204 response properly for the `StatisticsClient`.
Now we do.

Fixes #836
This commit is contained in:
Haacked
2015-08-07 10:41:02 -07:00
parent 0811d4cfd3
commit 0e74097dde
7 changed files with 69 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
Octokit.Tests/Clients/StatisticsClientTests.cs
View File

@@ -1,8 +1,8 @@
using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.Threading.Tasks;
using NSubstitute;
using Octokit.Tests.Helpers;
using Xunit;
namespace Octokit.Tests.Clients
@@ -21,16 +21,33 @@ namespace Octokit.Tests.Clients
public class TheGetContributorsMethod
{
[Fact]
public void RequestsCorrectUrl()
public async Task RetrievesContributorsForCorrectUrl()
{
var expectedEndPoint = new Uri("/repos/username/repositoryName/stats/contributors", UriKind.Relative);
var client = Substitute.For<IApiConnection>();
IReadOnlyList<Contributor> contributors = new ReadOnlyCollection<Contributor>(new[] { new Contributor() });
client.GetQueuedOperation<IReadOnlyList<Contributor>>(expectedEndPoint, Args.CancellationToken)
.Returns(Task.FromResult(contributors));
var statisticsClient = new StatisticsClient(client);
statisticsClient.GetContributors("username","repositoryName");
var result = await statisticsClient.GetContributors("username","repositoryName");
client.Received().GetQueuedOperation<IEnumerable<Contributor>>(expectedEndPoint,Args.CancellationToken);
Assert.Equal(1, result.Count);
}
[Fact]
public async Task RetrievesEmptyContributorsCollectionWhenNoContentReturned()
{
var expectedEndPoint = new Uri("/repos/username/repositoryName/stats/contributors", UriKind.Relative);
var client = Substitute.For<IApiConnection>();
IReadOnlyList<Contributor> contributors = null;
client.GetQueuedOperation<IReadOnlyList<Contributor>>(expectedEndPoint, Args.CancellationToken)
.Returns(Task.FromResult(contributors));
var statisticsClient = new StatisticsClient(client);
var result = await statisticsClient.GetContributors("username", "repositoryName");
Assert.Empty(result);
}
[Fact]