Release v0.31 - Check yo' self! (#1851)

* Fix whitespace/formatting with /FormatCode build option

* Update release notes

* fix a few failing integration tests

* Adjust required fields on UpdateCheckRun and NewCheckRun request models and fix tests
Tidy up field accessors and XmlDoc comments

* Update date in ReleaseNotes

* Keeping request models simple (avoid inheritance) - makes it easier when we move to generated models
This commit is contained in:
Ryan Gribble
2018-07-21 18:12:42 +10:00
committed by GitHub
parent c5d5df5b08
commit 101522070d
21 changed files with 173 additions and 83 deletions
@@ -82,7 +82,7 @@ namespace Octokit.Tests.Clients
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableCheckRunsClient(gitHubClient);
var update = new CheckRunUpdate("status") { Status = CheckStatus.InProgress };
var update = new CheckRunUpdate { Status = CheckStatus.InProgress };
client.Update("fake", "repo", 1, update);
@@ -95,7 +95,7 @@ namespace Octokit.Tests.Clients
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableCheckRunsClient(gitHubClient);
var update = new CheckRunUpdate("status") { Status = CheckStatus.InProgress };
var update = new CheckRunUpdate { Status = CheckStatus.InProgress };
client.Update(1, 1, update);
@@ -108,7 +108,7 @@ namespace Octokit.Tests.Clients
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableCheckRunsClient(gitHubClient);
var update = new CheckRunUpdate("status") { Status = CheckStatus.InProgress };
var update = new CheckRunUpdate { Status = CheckStatus.InProgress };
Assert.Throws<ArgumentNullException>(() => client.Update(null, "repo", 1, update));
Assert.Throws<ArgumentNullException>(() => client.Update("fake", null, 1, update));
@@ -121,7 +121,7 @@ namespace Octokit.Tests.Clients
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableCheckRunsClient(gitHubClient);
var update = new CheckRunUpdate("status") { Status = CheckStatus.InProgress };
var update = new CheckRunUpdate { Status = CheckStatus.InProgress };
Assert.Throws<ArgumentException>(() => client.Update("", "repo", 1, update));
Assert.Throws<ArgumentException>(() => client.Update("fake", "", 1, update));