From 128118cd783b070a03fcce4b9832ac85df20b5ed Mon Sep 17 00:00:00 2001 From: Haacked Date: Sun, 13 Dec 2015 22:23:52 -0800 Subject: [PATCH] Use linq expression to create dictionary Just feels nicer than mutating a dictionary. --- Octokit/Helpers/CollectionExtensions.cs | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/Octokit/Helpers/CollectionExtensions.cs b/Octokit/Helpers/CollectionExtensions.cs index 336d337a..74548d98 100644 --- a/Octokit/Helpers/CollectionExtensions.cs +++ b/Octokit/Helpers/CollectionExtensions.cs @@ -16,34 +16,18 @@ namespace Octokit public static IList Clone(this IReadOnlyList input) { - List output = null; if (input == null) - return output; + return null; - output = new List(); - - foreach (var item in input) - { - output.Add(new String(item.ToCharArray())); - } - - return output; + return input.Select(item => new String(item.ToCharArray())).ToList(); } public static IDictionary Clone(this IReadOnlyDictionary input) { - Dictionary output = null; if (input == null) - return output; + return null; - output = new Dictionary(); - - foreach (var item in input) - { - output.Add(new String(item.Key.ToCharArray()), new Uri(item.Value.ToString())); - } - - return output; + return input.ToDictionary(item => new String(item.Key.ToCharArray()), item => new Uri(item.Value.ToString())); } } }