From 133298789fe0634e394f3576b728ea34d98acd5b Mon Sep 17 00:00:00 2001
From: Peter MacNaughton <peter@macnaughton.info>
Date: Sat, 8 Feb 2014 12:48:53 -0700
Subject: [PATCH] Adding IObservableUserEmailsClient and...

default implementation. Still needs delete method which is skipped
because it's a HTTP DELETE. There's currently nothing in the
ApiConnection to handle this scenario and it's a rather unorthodox thing
to support.
delete.
---
 .../Clients/IObservableUserEmailsClient.cs    | 35 +++++++++++++++++++
 .../Clients/IObservableUsersClient.cs         |  7 ----
 .../Clients/ObservableUserEmailsClient.cs     | 31 ++++++++++++++++
 .../Clients/ObservableUsersClient.cs          | 12 -------
 Octokit.Reactive/Octokit.Reactive.csproj      |  2 ++
 5 files changed, 68 insertions(+), 19 deletions(-)
 create mode 100644 Octokit.Reactive/Clients/IObservableUserEmailsClient.cs
 create mode 100644 Octokit.Reactive/Clients/ObservableUserEmailsClient.cs

diff --git a/Octokit.Reactive/Clients/IObservableUserEmailsClient.cs b/Octokit.Reactive/Clients/IObservableUserEmailsClient.cs
new file mode 100644
index 00000000..95f67d9e
--- /dev/null
+++ b/Octokit.Reactive/Clients/IObservableUserEmailsClient.cs
@@ -0,0 +1,35 @@
+using System;
+using System.Diagnostics.CodeAnalysis;
+
+
+namespace Octokit.Reactive
+{
+    /// <summary>
+    /// A client for GitHub's User Emails API.
+    /// </summary>
+    /// <remarks>
+    /// See the <a href="http://developer.github.com/v3/users/emails/">User Emails API documentation</a> for more information.
+    /// </remarks>
+    public interface IObservableUserEmailsClient
+    {
+        /// <summary>
+        /// Gets all email addresses for the authenticated user.
+        /// </summary>
+        /// <remarks>
+        /// http://developer.github.com/v3/users/emails/#list-email-addresses-for-a-user
+        /// </remarks>
+        /// <returns>The <see cref="EmailAddress"/>es for the authenticated user.</returns>
+        [SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
+        IObservable<EmailAddress> GetAll();
+
+        /// <summary>
+        /// Adds email addresses for the authenticated user.
+        /// </summary>
+        /// <remarks>
+        /// http://developer.github.com/v3/users/emails/#add-email-addresses
+        /// </remarks>
+        /// <param name="emailAddresses">The email addresses to add.</param>
+        /// <returns>Returns the added <see cref="EmailAddress"/>es.</returns>
+        IObservable<string> Add(params string[] emailAddresses);
+    }
+}
diff --git a/Octokit.Reactive/Clients/IObservableUsersClient.cs b/Octokit.Reactive/Clients/IObservableUsersClient.cs
index ef319da0..465739a2 100644
--- a/Octokit.Reactive/Clients/IObservableUsersClient.cs
+++ b/Octokit.Reactive/Clients/IObservableUsersClient.cs
@@ -27,12 +27,5 @@ namespace Octokit.Reactive
         /// <exception cref="AuthorizationException">Thrown if the client is not authenticated.</exception>
         /// <returns>A <see cref="User"/></returns>
         IObservable<User> Update(UserUpdate user);
-
-        /// <summary>
-        /// Returns emails for the current user.
-        /// </summary>
-        /// <returns></returns>
-        [SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate")]
-        IObservable<EmailAddress> GetEmails();
     }
 }
diff --git a/Octokit.Reactive/Clients/ObservableUserEmailsClient.cs b/Octokit.Reactive/Clients/ObservableUserEmailsClient.cs
new file mode 100644
index 00000000..c50410aa
--- /dev/null
+++ b/Octokit.Reactive/Clients/ObservableUserEmailsClient.cs
@@ -0,0 +1,31 @@
+using Octokit.Reactive.Internal;
+using System;
+using System.Reactive.Linq;
+using System.Reactive.Threading.Tasks;
+
+namespace Octokit.Reactive
+{
+    public class ObservableUserEmailsClient : IObservableUserEmailsClient
+    {
+        readonly IUserEmailsClient _client;
+        readonly IConnection _connection;
+
+        public ObservableUserEmailsClient(IGitHubClient client)
+        {
+            Ensure.ArgumentNotNull(client, "client");
+
+            _client = client.User.Email;
+            _connection = client.Connection;
+        }
+
+        public IObservable<EmailAddress> GetAll()
+        {
+            return _connection.GetAndFlattenAllPages<EmailAddress>(ApiUrls.Emails());
+        }
+
+        public IObservable<string> Add(params string[] emailAddresses)
+        {
+            return _client.Add(emailAddresses).ToObservable().SelectMany(a => a);
+        }
+    }
+}
diff --git a/Octokit.Reactive/Clients/ObservableUsersClient.cs b/Octokit.Reactive/Clients/ObservableUsersClient.cs
index 5588e737..1648d8cc 100644
--- a/Octokit.Reactive/Clients/ObservableUsersClient.cs
+++ b/Octokit.Reactive/Clients/ObservableUsersClient.cs
@@ -1,20 +1,17 @@
 using System;
 using System.Reactive.Threading.Tasks;
-using Octokit.Reactive.Internal;
 
 namespace Octokit.Reactive
 {
     public class ObservableUsersClient : IObservableUsersClient
     {
         readonly IUsersClient _client;
-        readonly IConnection _connection;
 
         public ObservableUsersClient(IGitHubClient client)
         {
             Ensure.ArgumentNotNull(client, "client");
 
             _client = client.User;
-            _connection = client.Connection;
         }
 
         /// <summary>
@@ -50,14 +47,5 @@ namespace Octokit.Reactive
 
             return _client.Update(user).ToObservable();
         }
-
-        /// <summary>
-        /// Returns emails for the current user.
-        /// </summary>
-        /// <returns></returns>
-        public IObservable<EmailAddress> GetEmails()
-        {
-            return _connection.GetAndFlattenAllPages<EmailAddress>(ApiUrls.Emails());
-        }
     }
 }
diff --git a/Octokit.Reactive/Octokit.Reactive.csproj b/Octokit.Reactive/Octokit.Reactive.csproj
index 6c5c7e71..f66a07f1 100644
--- a/Octokit.Reactive/Octokit.Reactive.csproj
+++ b/Octokit.Reactive/Octokit.Reactive.csproj
@@ -73,6 +73,7 @@
     <Compile Include="..\SolutionInfo.cs">
       <Link>Properties\SolutionInfo.cs</Link>
     </Compile>
+    <Compile Include="Clients\IObservableUserEmailsClient.cs" />
     <Compile Include="Clients\IObservableWatchedClient.cs" />
     <Compile Include="Clients\IObservableFollowersClient.cs" />
     <Compile Include="Clients\ObservableSearchClient.cs" />
@@ -122,6 +123,7 @@
     <Compile Include="Clients\ObservableTagsClient.cs" />
     <Compile Include="Clients\ObservableTreesClient.cs" />
     <Compile Include="Clients\ObservableFollowersClient.cs" />
+    <Compile Include="Clients\ObservableUserEmailsClient.cs" />
     <Compile Include="Clients\ObservableUsersClient.cs" />
     <Compile Include="Clients\IObservableAssigneesClient.cs" />
     <Compile Include="Clients\IObservableNotificationsClient.cs" />