mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-07 04:16:51 +00:00
Ensure no async void methods
Added self tests to find async void methods. It found some cases where we passed an async lambda to a method that did not accept Action<Task> or Func<Task>. I fixed those tests.
This commit is contained in:
@@ -96,7 +96,7 @@ public class PullRequestReviewCommentsClientTests : IDisposable
|
||||
|
||||
var createdComment = await CreateComment(body, position, pullRequest.Sha, pullRequest.Number);
|
||||
|
||||
Assert.DoesNotThrow(async () => { await _client.Delete(Helper.UserName, _repository.Name, createdComment.Id); });
|
||||
await _client.Delete(Helper.UserName, _repository.Name, createdComment.Id);
|
||||
}
|
||||
|
||||
[IntegrationTest]
|
||||
|
||||
Reference in New Issue
Block a user