Add client for organization outside collaborators (#1639)

* Add client for organization outside collaborators * Add unit/integration tests * Add methods for removing an outside collaborator * Add unit/integration tests * Add new Put method to Connection which accepts a preview header * Add methods for converting an org member to an outside collaborator * Fix copy paste errors in new exceptions * According to API docs, a 403 should be returned if the member is not a member of the org, but a 404 is actually returned * Add unit/integration tests * Remove unused using directives * Got a bit overzealous with my removal of using directives * Fix integration tests by using the configured Organization and test username rather than henrik's :) * Remove ApiOptions overloads as it isn't currently supported * Fix XML doc grammar * Fix failing unit tests * Missed a couple of nameof replacements
2026-06-01 10:25:36 +00:00 · 2017-08-07 10:20:57 +10:00
parent cda714bef6
commit 1d1ca0a572
18 changed files with 1224 additions and 0 deletions
@@ -0,0 +1,142 @@
+using System.Reactive.Linq;
+using System.Threading.Tasks;
+using Octokit.Reactive;
+using Octokit.Tests.Integration.Helpers;
+using Xunit;
+
+namespace Octokit.Tests.Integration.Reactive
+{
+    public class ObservableOrganizationOutsideCollaboratorsClientTests
+    {
+        public class TheGetAllMethod
+        {
+            readonly IGitHubClient _gitHub;
+            readonly ObservableOrganizationOutsideCollaboratorsClient _client;
+            readonly string _fixtureCollaborator = "alfhenrik-test-2";
+
+            public TheGetAllMethod()
+            {
+                _gitHub = Helper.GetAuthenticatedClient();
+                _client = new ObservableOrganizationOutsideCollaboratorsClient(_gitHub);
+            }
+
+            [IntegrationTest]
+            public async Task ReturnsNoOutsideCollaborators()
+            {
+                var outsideCollaborators = await _client
+                    .GetAll(Helper.Organization).ToList();
+
+                Assert.NotNull(outsideCollaborators);
+                Assert.Empty(outsideCollaborators);
+            }
+
+            [IntegrationTest]
+            public async Task ReturnsOutsideCollaborators()
+            {
+                var repoName = Helper.MakeNameWithTimestamp("public-repo");
+                using (var context = await _gitHub.CreateRepositoryContext(Helper.Organization, new NewRepository(repoName)))
+                {
+                    await _gitHub.Repository.Collaborator.Add(context.RepositoryOwner, context.RepositoryName, _fixtureCollaborator);
+
+                    var outsideCollaborators = await _client
+                        .GetAll(Helper.Organization).ToList();
+
+                    Assert.NotNull(outsideCollaborators);
+                    Assert.Equal(1, outsideCollaborators.Count);
+                }
+            }
+
+            [IntegrationTest]
+            public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithAllFilter()
+            {
+                var repoName = Helper.MakeNameWithTimestamp("public-repo");
+                using (var context = await _gitHub.CreateRepositoryContext(Helper.Organization, new NewRepository(repoName)))
+                {
+                    await _gitHub.Repository.Collaborator.Add(context.RepositoryOwner, context.RepositoryName, _fixtureCollaborator);
+                    await _gitHub.Repository.Collaborator.Add(context.RepositoryOwner, context.RepositoryName, "alfhenrik");
+
+                    var outsideCollaborators = await _client
+                        .GetAll(Helper.Organization, OrganizationMembersFilter.All).ToList();
+
+                    Assert.NotNull(outsideCollaborators);
+                    Assert.Equal(2, outsideCollaborators.Count);
+                }
+            }
+
+            [IntegrationTest]
+            public async Task ReturnsCorrectCountOfOutsideCollaboratorsWithTwoFactorFilter()
+            {
+                var repoName = Helper.MakeNameWithTimestamp("public-repo");
+                using (var context = await _gitHub.CreateRepositoryContext(Helper.Organization, new NewRepository(repoName)))
+                {
+                    await _gitHub.Repository.Collaborator.Add(context.RepositoryOwner, context.RepositoryName, _fixtureCollaborator);
+                    await _gitHub.Repository.Collaborator.Add(context.RepositoryOwner, context.RepositoryName, "alfhenrik");
+
+                    var outsideCollaborators = await _client
+                        .GetAll(Helper.Organization, OrganizationMembersFilter.TwoFactorAuthenticationDisabled).ToList();
+
+                    Assert.NotNull(outsideCollaborators);
+                    Assert.Equal(1, outsideCollaborators.Count);
+                    Assert.Equal("alfhenrik-test-2", outsideCollaborators[0].Login);
+                }
+            }
+        }
+
+        public class TheDeleteMethod
+        {
+            readonly IGitHubClient _gitHub;
+            readonly ObservableOrganizationOutsideCollaboratorsClient _client;
+            readonly string _fixtureCollaborator = "alfhenrik-test-2";
+
+            public TheDeleteMethod()
+            {
+                _gitHub = Helper.GetAuthenticatedClient();
+                _client = new ObservableOrganizationOutsideCollaboratorsClient(_gitHub);
+            }
+
+            [IntegrationTest]
+            public async Task CanRemoveOutsideCollaborator()
+            {
+                var repoName = Helper.MakeNameWithTimestamp("public-repo");
+                using (var context = await _gitHub.CreateRepositoryContext(Helper.Organization, new NewRepository(repoName)))
+                {
+                    await _gitHub.Repository.Collaborator.Add(context.RepositoryOwner, context.RepositoryName, _fixtureCollaborator);
+
+                    var result = await _client.Delete(Helper.Organization, _fixtureCollaborator);
+                    Assert.True(result);
+
+                    var outsideCollaborators = await _client
+                        .GetAll(Helper.Organization).ToList();
+
+                    Assert.Empty(outsideCollaborators);
+                }
+            }
+        }
+
+        public class TheConvertFromMemberMethod
+        {
+            readonly IGitHubClient _gitHub;
+            readonly ObservableOrganizationOutsideCollaboratorsClient _client;
+            readonly string _fixtureCollaborator = "alfhenrik-test-2";
+
+            public TheConvertFromMemberMethod()
+            {
+                _gitHub = Helper.GetAuthenticatedClient();
+                _client = new ObservableOrganizationOutsideCollaboratorsClient(_gitHub);
+            }
+
+            [IntegrationTest(Skip = "This test relies on https://github.com/octokit/octokit.net/issues/1533 being implemented before being re-enabled as there's currently no way to invite a member to an org")]
+            public async Task CanConvertOrgMemberToOutsideCollaborator()
+            {
+                var result = await _client.ConvertFromMember(Helper.Organization, _fixtureCollaborator);
+                Assert.True(result);
+
+                var outsideCollaborators = await _client
+                    .GetAll(Helper.Organization).ToList();
+
+                Assert.Equal(1, outsideCollaborators.Count);
+                Assert.Equal(_fixtureCollaborator, outsideCollaborators[0].Login);
+            }
+        }
+    }
+}