From 1e36a4e3c30d792d059025f0ee5f3a53706ffcdc Mon Sep 17 00:00:00 2001
From: "aedampir@gmail.com" <aedampir@gmail.com>
Date: Wed, 15 Jun 2016 18:03:10 +0700
Subject: [PATCH] added new overloads

---
 .../IObservableIssueReactionsClient.cs        | 33 ++++++++++---
 .../Clients/ObservableIssueReactionsClient.cs | 47 ++++++++++++++-----
 Octokit/Clients/IIssueReactionsClient.cs      | 19 ++++++++
 Octokit/Clients/IssueReactionsClient.cs       | 47 +++++++++++++++----
 4 files changed, 118 insertions(+), 28 deletions(-)

diff --git a/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs b/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs
index e87af5f9..03aa0e90 100644
--- a/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs
+++ b/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs
@@ -10,6 +10,25 @@ namespace Octokit.Reactive
     /// </remarks>
     public interface IObservableIssueReactionsClient
     {
+        /// <summary>
+        /// List reactions for a specified Issue.
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
+        /// <param name="owner">The owner of the repository</param>
+        /// <param name="name">The name of the repository</param>
+        /// <param name="number">The issue id</param>        
+        /// <returns>An <see cref="IObservable{T}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
+        IObservable<Reaction> GetAll(string owner, string name, int number);
+        
+        /// <summary>
+        /// List reactions for a specified Issue.
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>        
+        /// <returns>An <see cref="IObservable{T}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
+        IObservable<Reaction> GetAll(int repositoryId, int number);
+
         /// <summary>
         /// Creates a reaction for a specified Issue.
         /// </summary>
@@ -22,13 +41,13 @@ namespace Octokit.Reactive
         IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
 
         /// <summary>
-        /// List reactions for a specified Issue.
+        /// Creates a reaction for a specified Issue.
         /// </summary>
-        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
-        /// <param name="owner">The owner of the repository</param>
-        /// <param name="name">The name of the repository</param>
-        /// <param name="number">The issue id</param>        
-        /// <returns>An <see cref="IObservable{T}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
-        IObservable<Reaction> GetAll(string owner, string name, int number);
+        /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>
+        /// <param name="reaction">The reaction to create </param>
+        /// <returns>An <see cref="IObservable{T}"/> representing created <see cref="Reaction"/> for a specified issue.</returns>
+        IObservable<Reaction> Create(int repositoryId, int number, NewReaction reaction);
     }
 }
diff --git a/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs b/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs
index f7026973..7249abdc 100644
--- a/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs
+++ b/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs
@@ -23,6 +23,34 @@ namespace Octokit.Reactive
             _connection = client.Connection;
         }
 
+        /// <summary>
+        /// List reactions for a specified Issue
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
+        /// <param name="owner">The owner of the repository</param>
+        /// <param name="name">The name of the repository</param>
+        /// <param name="number">The issue id</param>        
+        /// <returns>An <see cref="IObservable{T}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
+        public IObservable<Reaction> GetAll(string owner, string name, int number)
+        {
+            Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
+            Ensure.ArgumentNotNullOrEmptyString(name, "name");
+
+            return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueReactions(owner, name, number), null, AcceptHeaders.ReactionsPreview);
+        }
+
+        /// <summary>
+        /// List reactions for a specified Issue.
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>        
+        /// <returns>An <see cref="IObservable{T}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
+        public IObservable<Reaction> GetAll(int repositoryId, int number)
+        {
+            return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueReactions(repositoryId, number), null, AcceptHeaders.ReactionsPreview);
+        }
+
         /// <summary>
         /// Creates a reaction for a specified Issue
         /// </summary>
@@ -42,19 +70,16 @@ namespace Octokit.Reactive
         }
 
         /// <summary>
-        /// List reactions for a specified Issue
+        /// Creates a reaction for a specified Issue.
         /// </summary>
-        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
-        /// <param name="owner">The owner of the repository</param>
-        /// <param name="name">The name of the repository</param>
-        /// <param name="number">The issue id</param>        
-        /// <returns>An <see cref="IObservable{T}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
-        public IObservable<Reaction> GetAll(string owner, string name, int number)
+        /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>
+        /// <param name="reaction">The reaction to create </param>
+        /// <returns>An <see cref="IObservable{T}"/> representing created <see cref="Reaction"/> for a specified issue.</returns>
+        public IObservable<Reaction> Create(int repositoryId, int number, NewReaction reaction)
         {
-            Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
-            Ensure.ArgumentNotNullOrEmptyString(name, "name");
-
-            return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueReactions(owner, name, number), null, AcceptHeaders.ReactionsPreview);
+            return _client.Create(repositoryId, number, reaction).ToObservable();
         }
     }
 }
diff --git a/Octokit/Clients/IIssueReactionsClient.cs b/Octokit/Clients/IIssueReactionsClient.cs
index 5860daa0..9a5c501e 100644
--- a/Octokit/Clients/IIssueReactionsClient.cs
+++ b/Octokit/Clients/IIssueReactionsClient.cs
@@ -21,6 +21,15 @@ namespace Octokit
         /// <returns>A <see cref="Task{T}"/> of <see cref="IReadOnlyList{Reactions}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
         Task<IReadOnlyList<Reaction>> GetAll(string owner, string name, int number);
 
+        /// <summary>
+        /// Get all reactions for a specified Issue
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>        
+        /// <returns>A <see cref="Task{T}"/> of <see cref="IReadOnlyList{Reactions}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
+        Task<IReadOnlyList<Reaction>> GetAll(int repositoryId, int number);
+
         /// <summary>
         /// Creates a reaction for a specified Issue
         /// </summary>
@@ -31,5 +40,15 @@ namespace Octokit
         /// <param name="reaction">The reaction to create</param>
         /// <returns>A <see cref="Task{Reaction}"/> representing created <see cref="Reaction"/> for a specified issue.</returns>
         Task<Reaction> Create(string owner, string name, int number, NewReaction reaction);
+
+        /// <summary>
+        /// Creates a reaction for a specified Issue
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>
+        /// <param name="reaction">The reaction to create</param>
+        /// <returns>A <see cref="Task{Reaction}"/> representing created <see cref="Reaction"/> for a specified issue.</returns>
+        Task<Reaction> Create(int repositoryId, int number, NewReaction reaction);
     }
 }
diff --git a/Octokit/Clients/IssueReactionsClient.cs b/Octokit/Clients/IssueReactionsClient.cs
index dc57f21b..30874053 100644
--- a/Octokit/Clients/IssueReactionsClient.cs
+++ b/Octokit/Clients/IssueReactionsClient.cs
@@ -16,6 +16,34 @@ namespace Octokit
         {
         }
 
+        /// <summary>
+        /// Get all reactions for a specified Issue
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
+        /// <param name="owner">The owner of the repository</param>
+        /// <param name="name">The name of the repository</param>
+        /// <param name="number">The issue id</param>        
+        /// <returns>A <see cref="Task{T}"/> of <see cref="IReadOnlyList{Reactions}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
+        public Task<IReadOnlyList<Reaction>> GetAll(string owner, string name, int number)
+        {
+            Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
+            Ensure.ArgumentNotNullOrEmptyString(name, "name");
+
+            return ApiConnection.GetAll<Reaction>(ApiUrls.IssueReactions(owner, name, number), AcceptHeaders.ReactionsPreview);
+        }
+
+        /// <summary>
+        /// Get all reactions for a specified Issue
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>        
+        /// <returns>A <see cref="Task{T}"/> of <see cref="IReadOnlyList{Reactions}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
+        public Task<IReadOnlyList<Reaction>> GetAll(int repositoryId, int number)
+        {
+            return ApiConnection.GetAll<Reaction>(ApiUrls.IssueReactions(repositoryId, number), AcceptHeaders.ReactionsPreview);
+        }
+
         /// <summary>
         /// Creates a reaction for a specified Issue
         /// </summary>
@@ -35,19 +63,18 @@ namespace Octokit
         }
 
         /// <summary>
-        /// Get all reactions for a specified Issue
+        /// Creates a reaction for a specified Issue
         /// </summary>
-        /// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
-        /// <param name="owner">The owner of the repository</param>
-        /// <param name="name">The name of the repository</param>
-        /// <param name="number">The issue id</param>        
-        /// <returns>A <see cref="Task{T}"/> of <see cref="IReadOnlyList{Reactions}"/> representing <see cref="Reaction"/>s for a specified issue.</returns>
-        public Task<IReadOnlyList<Reaction>> GetAll(string owner, string name, int number)
+        /// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
+        /// <param name="repositoryId">The ID of the repository</param>
+        /// <param name="number">The issue id</param>
+        /// <param name="reaction">The reaction to create</param>
+        /// <returns>A <see cref="Task{Reaction}"/> representing created <see cref="Reaction"/> for a specified issue.</returns>
+        public Task<Reaction> Create(int repositoryId, int number, NewReaction reaction)
         {
-            Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
-            Ensure.ArgumentNotNullOrEmptyString(name, "name");
+            Ensure.ArgumentNotNull(reaction, "reaction");
 
-            return ApiConnection.GetAll<Reaction>(ApiUrls.IssueReactions(owner, name, number), AcceptHeaders.ReactionsPreview);
+            return ApiConnection.Post<Reaction>(ApiUrls.IssueReactions(repositoryId, number), reaction, AcceptHeaders.ReactionsPreview);
         }
     }
 }