mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-08 04:40:54 +00:00
Enable pagination convention tests (#1659)
* Unskip pagination convention tests and rework exclusion property names Also exclude Obsolete methods from pagination convention tests * Reaction APIs appear to support pagination, flag to exclude for now and mark a TODO that they need implementing * Repository invitation APIs need pagination implemented * Exclude methods that use an alternative pagination approach * Migrations, Licenses and References all need pagination implemented * Pagination not supported for these methods (determined by API doc and poking the API) so exclude them from convention tests * These methods need renaming to GetAll * Rename offending RepositoryTrafficClient GetReferrers and GetPaths to GetAllReferrers and GetAllPaths * Rename offending RepositoryBranchesClient methods from Get to GetAll
This commit is contained in:
@@ -40,6 +40,7 @@ namespace Octokit
|
||||
/// <param name="name">The name of the repository</param>
|
||||
/// <param name="number">The comment id</param>
|
||||
/// <returns></returns>
|
||||
[ExcludeFromPaginationApiOptionsConventionTest("TODO: Implement pagination for this method")]
|
||||
Task<IReadOnlyList<Reaction>> GetAll(string owner, string name, int number);
|
||||
|
||||
/// <summary>
|
||||
@@ -49,6 +50,7 @@ namespace Octokit
|
||||
/// <param name="repositoryId">The owner of the repository</param>
|
||||
/// <param name="number">The comment id</param>
|
||||
/// <returns></returns>
|
||||
[ExcludeFromPaginationApiOptionsConventionTest("TODO: Implement pagination for this method")]
|
||||
Task<IReadOnlyList<Reaction>> GetAll(long repositoryId, int number);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user