zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-03 03:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable pagination convention tests (#1659)

Browse Source 
* Unskip pagination convention tests and rework exclusion property names
Also exclude Obsolete methods from pagination convention tests

* Reaction APIs appear to support pagination, flag to exclude for now and mark a TODO that they need implementing

* Repository invitation APIs need pagination implemented

* Exclude methods that use an alternative pagination approach

* Migrations, Licenses and References all need pagination implemented

* Pagination not supported for these methods (determined by API doc and poking the API) so exclude them from convention tests

* These methods need renaming to GetAll

* Rename offending RepositoryTrafficClient GetReferrers and GetPaths to GetAllReferrers and GetAllPaths

* Rename offending RepositoryBranchesClient methods from Get to GetAll
This commit is contained in:
Ryan Gribble
2017-09-03 11:50:02 +10:00
committed by GitHub
parent f96d75fc1b
commit 1e474f8556
30 changed files with 709 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Reactive/Clients/ObservableRepositoryTrafficClient.cs
+50 -4
View File
@@ -20,9 +20,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
public IObservable<RepositoryTrafficPath> GetPaths(long repositoryId)
{
return _client.GetPaths(repositoryId).ToObservable().SelectMany(x => x);
return GetAllPaths(repositoryId);
}
/// <summary>
@@ -31,12 +32,34 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllPaths instead")]
public IObservable<RepositoryTrafficPath> GetPaths(string owner, string name)
{
return GetAllPaths(owner, name);
}
/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="repositoryId">The owner of the repository</param>
public IObservable<RepositoryTrafficPath> GetAllPaths(long repositoryId)
{
return _client.GetAllPaths(repositoryId).ToObservable().SelectMany(x => x);
}
/// <summary>
/// List the top 10 popular contents over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-paths</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
public IObservable<RepositoryTrafficPath> GetAllPaths(string owner, string name)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
return _client.GetPaths(owner, name).ToObservable().SelectMany(x => x);
return _client.GetAllPaths(owner, name).ToObservable().SelectMany(x => x);
}
/// <summary>
@@ -44,9 +67,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="repositoryId">The owner of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
public IObservable<RepositoryTrafficReferrer> GetReferrers(long repositoryId)
{
return _client.GetReferrers(repositoryId).ToObservable().SelectMany(x => x);
return GetAllReferrers(repositoryId);
}
/// <summary>
@@ -55,12 +79,34 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
[Obsolete("Please use GetAllReferrers instead")]
public IObservable<RepositoryTrafficReferrer> GetReferrers(string owner, string name)
{
return GetAllReferrers(owner, name);
}
/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="repositoryId">The owner of the repository</param>
public IObservable<RepositoryTrafficReferrer> GetAllReferrers(long repositoryId)
{
return _client.GetAllReferrers(repositoryId).ToObservable().SelectMany(x => x);
}
/// <summary>
/// List the top 10 referrers over the last 14 days
/// </summary>
/// <remarks>https://developer.github.com/v3/repos/traffic/#list-referrers</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
public IObservable<RepositoryTrafficReferrer> GetAllReferrers(string owner, string name)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name");
return _client.GetReferrers(owner, name).ToObservable().SelectMany(x => x);
return _client.GetAllReferrers(owner, name).ToObservable().SelectMany(x => x);
}
/// <summary>