zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-06 03:55:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable pagination convention tests (#1659)

Browse Source 
* Unskip pagination convention tests and rework exclusion property names
Also exclude Obsolete methods from pagination convention tests

* Reaction APIs appear to support pagination, flag to exclude for now and mark a TODO that they need implementing

* Repository invitation APIs need pagination implemented

* Exclude methods that use an alternative pagination approach

* Migrations, Licenses and References all need pagination implemented

* Pagination not supported for these methods (determined by API doc and poking the API) so exclude them from convention tests

* These methods need renaming to GetAll

* Rename offending RepositoryTrafficClient GetReferrers and GetPaths to GetAllReferrers and GetAllPaths

* Rename offending RepositoryBranchesClient methods from Get to GetAll
This commit is contained in:
Ryan Gribble
2017-09-03 11:50:02 +10:00
committed by GitHub
parent f96d75fc1b
commit 1e474f8556
30 changed files with 709 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Reactive/ObservableRepositoryTrafficClientTests.cs
+16 -16
View File
@@ -24,9 +24,9 @@ namespace Octokit.Tests.Reactive
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableRepositoryTrafficClient(gitHubClient);
client.GetReferrers("fake", "repo");
client.GetAllReferrers("fake", "repo");
gitHubClient.Received().Repository.Traffic.GetReferrers("fake", "repo");
gitHubClient.Received().Repository.Traffic.GetAllReferrers("fake", "repo");
}
[Fact]
@@ -35,9 +35,9 @@ namespace Octokit.Tests.Reactive
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableRepositoryTrafficClient(gitHubClient);
client.GetReferrers(1);
client.GetAllReferrers(1);
gitHubClient.Received().Repository.Traffic.GetReferrers(1);
gitHubClient.Received().Repository.Traffic.GetAllReferrers(1);
}
[Fact]
@@ -45,11 +45,11 @@ namespace Octokit.Tests.Reactive
{
var client = new ObservableRepositoryTrafficClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => client.GetReferrers(null, "name"));
Assert.Throws<ArgumentNullException>(() => client.GetReferrers("owner", null));
Assert.Throws<ArgumentNullException>(() => client.GetAllReferrers(null, "name"));
Assert.Throws<ArgumentNullException>(() => client.GetAllReferrers("owner", null));
Assert.Throws<ArgumentException>(() => client.GetReferrers("", "name"));
Assert.Throws<ArgumentException>(() => client.GetReferrers("owner", ""));
Assert.Throws<ArgumentException>(() => client.GetAllReferrers("", "name"));
Assert.Throws<ArgumentException>(() => client.GetAllReferrers("owner", ""));
}
}
@@ -61,9 +61,9 @@ namespace Octokit.Tests.Reactive
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableRepositoryTrafficClient(gitHubClient);
client.GetPaths("fake", "repo");
client.GetAllPaths("fake", "repo");
gitHubClient.Received().Repository.Traffic.GetPaths("fake", "repo");
gitHubClient.Received().Repository.Traffic.GetAllPaths("fake", "repo");
}
[Fact]
@@ -72,9 +72,9 @@ namespace Octokit.Tests.Reactive
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservableRepositoryTrafficClient(gitHubClient);
client.GetPaths(1);
client.GetAllPaths(1);
gitHubClient.Received().Repository.Traffic.GetPaths(1);
gitHubClient.Received().Repository.Traffic.GetAllPaths(1);
}
[Fact]
@@ -82,11 +82,11 @@ namespace Octokit.Tests.Reactive
{
var client = new ObservableRepositoryTrafficClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => client.GetPaths(null, "name"));
Assert.Throws<ArgumentNullException>(() => client.GetPaths("owner", null));
Assert.Throws<ArgumentNullException>(() => client.GetAllPaths(null, "name"));
Assert.Throws<ArgumentNullException>(() => client.GetAllPaths("owner", null));
Assert.Throws<ArgumentException>(() => client.GetPaths("", "name"));
Assert.Throws<ArgumentException>(() => client.GetPaths("owner", ""));
Assert.Throws<ArgumentException>(() => client.GetAllPaths("", "name"));
Assert.Throws<ArgumentException>(() => client.GetAllPaths("owner", ""));
}
}