From 20e4a8ca7ea38b737bb3002c859bf5c7c18a1f3d Mon Sep 17 00:00:00 2001 From: Valeriu Caraulean Date: Sat, 12 Jul 2014 00:09:48 +0200 Subject: [PATCH] Trivial fixes in XML comments And added an #if around using in RequestParameters.cs (worth having a look, may have implications when building on different platforms) --- Octokit.Reactive/Clients/ObservableFollowersClient.cs | 8 ++++---- Octokit/Clients/IPullRequestsClient.cs | 1 + Octokit/Clients/PullRequestsClient.cs | 1 + Octokit/Models/Request/OauthTokenRequest.cs | 2 +- Octokit/Models/Request/RequestParameters.cs | 2 ++ 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/Octokit.Reactive/Clients/ObservableFollowersClient.cs b/Octokit.Reactive/Clients/ObservableFollowersClient.cs index e9dadc2e..508a440e 100644 --- a/Octokit.Reactive/Clients/ObservableFollowersClient.cs +++ b/Octokit.Reactive/Clients/ObservableFollowersClient.cs @@ -28,7 +28,7 @@ namespace Octokit.Reactive /// /// See the API documentation for more information. /// - /// A of s that follow the authenticated user. + /// A of s that follow the authenticated user. public IObservable GetAllForCurrent() { return _connection.GetAndFlattenAllPages(ApiUrls.Followers()); @@ -41,7 +41,7 @@ namespace Octokit.Reactive /// /// See the API documentation for more information. /// - /// A of s that follow the passed user. + /// A of s that follow the passed user. public IObservable GetAll(string login) { Ensure.ArgumentNotNullOrEmptyString(login, "login"); @@ -55,7 +55,7 @@ namespace Octokit.Reactive /// /// See the API documentation for more information. /// - /// A of s that the authenticated user follows. + /// A of s that the authenticated user follows. public IObservable GetFollowingForCurrent() { return _connection.GetAndFlattenAllPages(ApiUrls.Following()); @@ -68,7 +68,7 @@ namespace Octokit.Reactive /// /// See the API documentation for more information. /// - /// A of s that the passed user follows. + /// A of s that the passed user follows. public IObservable GetFollowing(string login) { Ensure.ArgumentNotNullOrEmptyString(login, "login"); diff --git a/Octokit/Clients/IPullRequestsClient.cs b/Octokit/Clients/IPullRequestsClient.cs index 940db5c0..f9a3073b 100644 --- a/Octokit/Clients/IPullRequestsClient.cs +++ b/Octokit/Clients/IPullRequestsClient.cs @@ -11,6 +11,7 @@ namespace Octokit /// IPullRequestReviewCommentsClient Comment { get; } + /// /// Get a pull request by number. /// /// diff --git a/Octokit/Clients/PullRequestsClient.cs b/Octokit/Clients/PullRequestsClient.cs index bf2a026c..0077f5b5 100644 --- a/Octokit/Clients/PullRequestsClient.cs +++ b/Octokit/Clients/PullRequestsClient.cs @@ -16,6 +16,7 @@ namespace Octokit /// public IPullRequestReviewCommentsClient Comment { get; private set; } + /// /// Get a pull request by number. /// /// diff --git a/Octokit/Models/Request/OauthTokenRequest.cs b/Octokit/Models/Request/OauthTokenRequest.cs index d142462b..e34f386a 100644 --- a/Octokit/Models/Request/OauthTokenRequest.cs +++ b/Octokit/Models/Request/OauthTokenRequest.cs @@ -38,7 +38,7 @@ namespace Octokit public string ClientSecret { get; private set; } /// - /// The code you received as a response to making the OAuth login + /// The code you received as a response to making the OAuth login /// request. /// [Parameter(Key = "code")] diff --git a/Octokit/Models/Request/RequestParameters.cs b/Octokit/Models/Request/RequestParameters.cs index ba69623e..811071a7 100644 --- a/Octokit/Models/Request/RequestParameters.cs +++ b/Octokit/Models/Request/RequestParameters.cs @@ -1,5 +1,7 @@ using System; +#if !PORTABLE using System.Collections.Concurrent; +#endif using System.Collections.Generic; using System.Diagnostics; using System.Diagnostics.CodeAnalysis;