zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-09 21:09:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

bugfix - dictionaries are enumerable - we shouldn't enforce this serialization rule

Browse Source
This commit is contained in:
Brendan Forster
2015-01-04 11:22:41 +09:30
parent 2583f6bdee
commit 2395eecf71
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit/Http/JsonHttpPipeline.cs
+6 -3
View File
@@ -48,12 +48,15 @@ namespace Octokit.Internal
{
var body = response.Body;
// simple json does not support the root node being empty. Will submit a pr but in the mean time....
if (body != "{}")
if (body != "{}")
{
var typeIsDictionary = typeof(IDictionary).IsAssignableFrom(typeof(T));
var typeIsEnumerable = typeof(IEnumerable).IsAssignableFrom(typeof(T));
var responseIsArray = body.StartsWith("{", StringComparison.Ordinal);
// If we're expecting an array, but we get a single object, just wrap it.
// This supports an api that dynamically changes the return type based on the content.
if ((typeof(IEnumerable).IsAssignableFrom(typeof(T)))
&& body.StartsWith("{", StringComparison.Ordinal))
if (!typeIsDictionary && typeIsEnumerable && responseIsArray)
{
body = "[" + body + "]";
}