From 2a9c7c7eff3fe41c24592e495684ee67795427ea Mon Sep 17 00:00:00 2001 From: Peter MacNaughton Date: Sun, 9 Feb 2014 12:04:36 -0700 Subject: [PATCH] Fixing and adding unit tests for UserEmails... Client and ObservableUserEmailsClient --- Octokit.Tests/Clients/UserEmailsClientTests.cs | 18 ++++++++++++++---- .../ObservableUserEmailsClientTests.cs | 12 ++++-------- 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/Octokit.Tests/Clients/UserEmailsClientTests.cs b/Octokit.Tests/Clients/UserEmailsClientTests.cs index d74f0bed..e699bc8a 100644 --- a/Octokit.Tests/Clients/UserEmailsClientTests.cs +++ b/Octokit.Tests/Clients/UserEmailsClientTests.cs @@ -39,17 +39,27 @@ namespace Octokit.Tests.Clients } [Fact] - public async Task EnsuresNonNullArgument() + public void EnsuresNonNullArgument() { var client = new UserEmailsClient(Substitute.For()); - await AssertEx.Throws(async () => await client.Add(null)); + Assert.Throws(() => client.Add(null)); } [Fact] - public async Task EnsuresNoNullEmails() + public void EnsuresNoNullEmails() { var client = new UserEmailsClient(Substitute.For()); - await AssertEx.Throws(async () => await client.Add("octokit@github.com", null)); + Assert.Throws(() => client.Add("octokit@github.com", null)); + } + } + + public class TheCtor + { + [Fact] + public void EnsuresArguments() + { + Assert.Throws( + () => new UserEmailsClient(null)); } } } diff --git a/Octokit.Tests/Reactive/ObservableUserEmailsClientTests.cs b/Octokit.Tests/Reactive/ObservableUserEmailsClientTests.cs index c20128e6..49ea1e8f 100644 --- a/Octokit.Tests/Reactive/ObservableUserEmailsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableUserEmailsClientTests.cs @@ -54,10 +54,8 @@ namespace Octokit.Tests { var client = CreateFixtureWithNonReactiveClient(); - Assert.Throws( - () => client.Add(null)); - Assert.Throws( - () => client.Add("octo@github.com", null)); + Assert.Throws(() => client.Add(null)); + Assert.Throws(() => client.Add("octo@github.com", null)); } [Fact] @@ -65,10 +63,8 @@ namespace Octokit.Tests { var client = CreateFixtureWithNonReactiveClient(); - Assert.Throws( - () => client.Add("")); - Assert.Throws( - () => client.Add("octo@github.com", "")); + Assert.Throws(() => client.Add("")); + Assert.Throws(() => client.Add("octo@github.com", "")); } }