From 2b41b0d5539cdba612599c07c48505e4d938e98e Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Wed, 25 May 2016 12:28:23 +0700 Subject: [PATCH] added new overloads --- .../IObservableDeploymentStatusClient.cs | 14 +++++++++++ .../ObservableDeploymentStatusClient.cs | 23 ++++++++++++++++++- Octokit/Clients/DeploymentStatusClient.cs | 23 ++++++++++++++++++- Octokit/Clients/IDeploymentStatusClient.cs | 14 +++++++++++ 4 files changed, 72 insertions(+), 2 deletions(-) diff --git a/Octokit.Reactive/Clients/IObservableDeploymentStatusClient.cs b/Octokit.Reactive/Clients/IObservableDeploymentStatusClient.cs index 55d4ea6e..2b67fae7 100644 --- a/Octokit.Reactive/Clients/IObservableDeploymentStatusClient.cs +++ b/Octokit.Reactive/Clients/IObservableDeploymentStatusClient.cs @@ -17,6 +17,20 @@ namespace Octokit.Reactive /// All deployment statuses for the given deployment. IObservable GetAll(string owner, string name, int deploymentId); + /// + /// Gets all the statuses for the given deployment. Any user with pull access to a repository can + /// view deployments. + /// + /// + /// http://developer.github.com/v3/repos/deployments/#list-deployment-statuses + /// + /// The owner of the repository. + /// The name of the repository. + /// The id of the deployment. + /// Options for changing the API response + /// All deployment statuses for the given deployment. + IObservable GetAll(string owner, string name, int deploymentId, ApiOptions options); + /// /// Creates a new status for the given deployment. Users with push access can create deployment /// statuses for a given deployment. diff --git a/Octokit.Reactive/Clients/ObservableDeploymentStatusClient.cs b/Octokit.Reactive/Clients/ObservableDeploymentStatusClient.cs index 2aef437f..8295f6b0 100644 --- a/Octokit.Reactive/Clients/ObservableDeploymentStatusClient.cs +++ b/Octokit.Reactive/Clients/ObservableDeploymentStatusClient.cs @@ -33,8 +33,29 @@ namespace Octokit.Reactive.Clients Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); + return GetAll(owner, name, deploymentId, ApiOptions.None); + } + + /// + /// Gets all the statuses for the given deployment. Any user with pull access to a repository can + /// view deployments. + /// + /// + /// http://developer.github.com/v3/repos/deployments/#list-deployment-statuses + /// + /// The owner of the repository. + /// The name of the repository. + /// The id of the deployment. + /// Options for changing the API response + /// All deployment statuses for the given deployment. + public IObservable GetAll(string owner, string name, int deploymentId, ApiOptions options) + { + Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); + Ensure.ArgumentNotNullOrEmptyString(name, "name"); + Ensure.ArgumentNotNull(options, "options"); + return _connection.GetAndFlattenAllPages( - ApiUrls.DeploymentStatuses(owner, name, deploymentId)); + ApiUrls.DeploymentStatuses(owner, name, deploymentId), options); } /// diff --git a/Octokit/Clients/DeploymentStatusClient.cs b/Octokit/Clients/DeploymentStatusClient.cs index 8c9e3236..62722ec4 100644 --- a/Octokit/Clients/DeploymentStatusClient.cs +++ b/Octokit/Clients/DeploymentStatusClient.cs @@ -33,7 +33,28 @@ namespace Octokit Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); - return ApiConnection.GetAll(ApiUrls.DeploymentStatuses(owner, name, deploymentId)); + return GetAll(owner, name, deploymentId, ApiOptions.None); + } + + /// + /// Gets all the statuses for the given deployment. Any user with pull access to a repository can + /// view deployments. + /// + /// + /// http://developer.github.com/v3/repos/deployments/#list-deployment-statuses + /// + /// The owner of the repository. + /// The name of the repository. + /// The id of the deployment. + /// Options for changing the API response + /// All deployment statuses for the given deployment. + public Task> GetAll(string owner, string name, int deploymentId, ApiOptions options) + { + Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); + Ensure.ArgumentNotNullOrEmptyString(name, "name"); + Ensure.ArgumentNotNull(options, "options"); + + return ApiConnection.GetAll(ApiUrls.DeploymentStatuses(owner, name, deploymentId), options); } /// diff --git a/Octokit/Clients/IDeploymentStatusClient.cs b/Octokit/Clients/IDeploymentStatusClient.cs index 285b2353..077c17c1 100644 --- a/Octokit/Clients/IDeploymentStatusClient.cs +++ b/Octokit/Clients/IDeploymentStatusClient.cs @@ -25,6 +25,20 @@ namespace Octokit /// All deployment statuses for the given deployment. Task> GetAll(string owner, string name, int deploymentId); + /// + /// Gets all the statuses for the given deployment. Any user with pull access to a repository can + /// view deployments. + /// + /// + /// http://developer.github.com/v3/repos/deployments/#list-deployment-statuses + /// + /// The owner of the repository. + /// The name of the repository. + /// The id of the deployment. + /// Options for changing the API response + /// All deployment statuses for the given deployment. + Task> GetAll(string owner, string name, int deploymentId, ApiOptions options); + /// /// Creates a new status for the given deployment. Users with push access can create deployment /// statuses for a given deployment.