From 2eb8e562eea56094122f7dd26bf28490d2c3ecd0 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Thu, 23 Apr 2015 09:14:06 +0930 Subject: [PATCH] avoid using parameters here, just craft the URL by hand --- .../Clients/ObservableRepositoriesClient.cs | 4 +++- Octokit/Clients/RepositoriesClient.cs | 4 +++- Octokit/Helpers/ApiUrls.cs | 14 +++++++++++--- 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs b/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs index 1a173d9c..9f767b51 100644 --- a/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs +++ b/Octokit.Reactive/Clients/ObservableRepositoriesClient.cs @@ -114,7 +114,9 @@ namespace Octokit.Reactive { Ensure.ArgumentNotNull(request, "request"); - return _connection.GetAndFlattenAllPages(ApiUrls.AllPublicRepositories(), request.ToParametersDictionary()); + var url = ApiUrls.AllPublicRepositories(request.Since); + + return _connection.GetAndFlattenAllPages(url); } /// diff --git a/Octokit/Clients/RepositoriesClient.cs b/Octokit/Clients/RepositoriesClient.cs index 479ac89f..979ec01b 100644 --- a/Octokit/Clients/RepositoriesClient.cs +++ b/Octokit/Clients/RepositoriesClient.cs @@ -203,7 +203,9 @@ namespace Octokit { Ensure.ArgumentNotNull(request, "request"); - return ApiConnection.GetAll(ApiUrls.AllPublicRepositories(), request.ToParametersDictionary()); + var url = ApiUrls.AllPublicRepositories(request.Since); + + return ApiConnection.GetAll(url); } /// diff --git a/Octokit/Helpers/ApiUrls.cs b/Octokit/Helpers/ApiUrls.cs index 475ae0cc..f42096ea 100644 --- a/Octokit/Helpers/ApiUrls.cs +++ b/Octokit/Helpers/ApiUrls.cs @@ -19,15 +19,23 @@ namespace Octokit static readonly Uri _oauthAuthorize = new Uri("login/oauth/authorize", UriKind.Relative); static readonly Uri _oauthAccesToken = new Uri("login/oauth/access_token", UriKind.Relative); + /// + /// Returns the that returns all public repositories in + /// response to a GET request. + /// + public static Uri AllPublicRepositories() + { + return "/repositories".FormatUri(); + } /// /// Returns the that returns all public repositories in /// response to a GET request. /// - /// - public static Uri AllPublicRepositories() + /// The integer ID of the last Repository that you’ve seen. + public static Uri AllPublicRepositories(long since) { - return "/repositories".FormatUri(); + return "/repositories?since={0}".FormatUri(since); } ///