From 327020750ff5e5a7a3b9f07b3dd65661b33ce9b7 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Wed, 18 Mar 2020 08:52:50 -0300 Subject: [PATCH] add convention test for preview APIs (#2154) --- .../Clients/ObservableIssuesLabelsClient.cs | 14 +-- .../ObservableRepoCollaboratorsClient.cs | 10 +- .../Clients/ObservableRepositoriesClient.cs | 16 +-- .../ObservableRepositoryInvitationsClient.cs | 26 ++-- .../Clients/ObservableTeamsClient.cs | 18 +-- Octokit.Tests.Conventions/PreviewsTests.cs | 99 +++++++++++++++ Octokit.Tests/Clients/CommitsClientTests.cs | 3 +- Octokit.Tests/Clients/IssuesClientTests.cs | 8 +- .../Clients/IssuesLabelsClientTests.cs | 48 +++---- .../Clients/MiscellaneousClientTests.cs | 4 +- .../Clients/PullRequestsClientTests.cs | 8 +- .../Clients/RepoCollaboratorsClientTests.cs | 14 +-- .../Clients/RepositoriesClientTests.cs | 78 ++++-------- .../Clients/RepositoryBranchesClientTests.cs | 118 +++++++++--------- .../RepositoryInvitationsClientTests.cs | 13 +- .../Clients/RepositoryPagesClientTests.cs | 4 +- .../Clients/RepositoryTrafficClientTests.cs | 16 +-- Octokit.Tests/Clients/SearchClientTests.cs | 22 ++-- Octokit.Tests/Clients/TagsClientTests.cs | 4 +- Octokit.Tests/Clients/TeamsClientTests.cs | 42 ++----- .../Clients/UserGpgKeysClientTests.cs | 19 +-- Octokit.Tests/Http/ConnectionTests.cs | 4 +- Octokit.Tests/Http/JsonHttpPipelineTests.cs | 2 +- .../ObservableIssuesLabelsClientTests.cs | 28 ++--- .../ObservableRepoCollaboratorsClientTests.cs | 30 ++--- .../ObservableRepositoriesClientTests.cs | 12 +- .../Reactive/ObservableTeamsClientTests.cs | 12 +- Octokit/Clients/CommitsClient.cs | 2 +- Octokit/Clients/IssuesClient.cs | 8 +- Octokit/Clients/IssuesLabelsClient.cs | 36 +++--- Octokit/Clients/MiscellaneousClient.cs | 4 +- Octokit/Clients/PullRequestsClient.cs | 4 +- Octokit/Clients/RepoCollaboratorsClient.cs | 12 +- Octokit/Clients/RepositoriesClient.cs | 30 ++--- Octokit/Clients/RepositoryBranchesClient.cs | 114 +++++++++-------- .../Clients/RepositoryInvitationsClient.cs | 22 ++-- Octokit/Clients/RepositoryPagesClient.cs | 4 +- Octokit/Clients/RepositoryTrafficClient.cs | 16 +-- Octokit/Clients/SearchClient.cs | 2 +- Octokit/Clients/TagsClient.cs | 4 +- Octokit/Clients/TeamsClient.cs | 30 ++--- Octokit/Clients/UserGpgKeysClient.cs | 8 +- Octokit/Helpers/AcceptHeaders.cs | 36 +----- Octokit/Http/JsonHttpPipeline.cs | 2 +- 44 files changed, 497 insertions(+), 509 deletions(-) create mode 100644 Octokit.Tests.Conventions/PreviewsTests.cs diff --git a/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs b/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs index f3400c14..8781d1f0 100644 --- a/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs +++ b/Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs @@ -71,7 +71,7 @@ namespace Octokit.Reactive Ensure.ArgumentNotNullOrEmptyString(name, nameof(name)); Ensure.ArgumentNotNull(options, nameof(options)); - return _connection.GetAndFlattenAllPages