From 9b289195c1e1e6adca84fd9843b57d24f76c9256 Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Fri, 22 Apr 2016 17:27:35 +0700 Subject: [PATCH 1/4] redundant @ prefix was removed --- Octokit.Reactive/Clients/IObservableRepositoryCommitsClients.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Octokit.Reactive/Clients/IObservableRepositoryCommitsClients.cs b/Octokit.Reactive/Clients/IObservableRepositoryCommitsClients.cs index 12a4ebf8..2cc9c479 100644 --- a/Octokit.Reactive/Clients/IObservableRepositoryCommitsClients.cs +++ b/Octokit.Reactive/Clients/IObservableRepositoryCommitsClients.cs @@ -14,7 +14,7 @@ namespace Octokit.Reactive /// The reference to use as the head commit /// [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "base")] - IObservable Compare(string owner, string name, string @base, string @head); + IObservable Compare(string owner, string name, string @base, string head); /// /// Gets all commits for a given repository From 39ef6e069adba9689dc5a3f59a4aa1d928c2da4b Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Fri, 22 Apr 2016 17:28:52 +0700 Subject: [PATCH 2/4] redundant explicit array type specifications were removed --- .../Clients/UserAdministrationClientTests.cs | 2 +- .../Reactive/ObservableUserAdministrationClientTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/UserAdministrationClientTests.cs b/Octokit.Tests.Integration/Clients/UserAdministrationClientTests.cs index b9c049ab..0a68edd2 100644 --- a/Octokit.Tests.Integration/Clients/UserAdministrationClientTests.cs +++ b/Octokit.Tests.Integration/Clients/UserAdministrationClientTests.cs @@ -91,7 +91,7 @@ namespace Octokit.Tests.Integration.Clients // Create Impersonation token var token = await _github.User.Administration.CreateImpersonationToken( context.UserLogin, - new NewImpersonationToken(new string[] { "public_repo" })); + new NewImpersonationToken(new[] { "public_repo" })); Assert.NotNull(token); Assert.True( diff --git a/Octokit.Tests.Integration/Reactive/ObservableUserAdministrationClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableUserAdministrationClientTests.cs index 49d79d1e..ad15c402 100644 --- a/Octokit.Tests.Integration/Reactive/ObservableUserAdministrationClientTests.cs +++ b/Octokit.Tests.Integration/Reactive/ObservableUserAdministrationClientTests.cs @@ -94,7 +94,7 @@ namespace Octokit.Tests.Integration.Clients // Create Impersonation token var observable = _github.User.Administration.CreateImpersonationToken( context.UserLogin, - new NewImpersonationToken(new string[] { "public_repo" })); + new NewImpersonationToken(new[] { "public_repo" })); var token = await observable; Assert.NotNull(token); From f7fe51a8480a03d27b3f78112a2b142ca9929ac5 Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Fri, 22 Apr 2016 17:29:41 +0700 Subject: [PATCH 3/4] redundant argument list was removed --- Octokit.Tests/Clients/GistsClientTests.cs | 2 +- Octokit.Tests/Clients/IssueCommentsClientTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Octokit.Tests/Clients/GistsClientTests.cs b/Octokit.Tests/Clients/GistsClientTests.cs index 6e9dcb91..536d7619 100644 --- a/Octokit.Tests/Clients/GistsClientTests.cs +++ b/Octokit.Tests/Clients/GistsClientTests.cs @@ -414,7 +414,7 @@ public class GistsClientTests var connection = Substitute.For(); var client = new GistsClient(connection); - var options = new ApiOptions() + var options = new ApiOptions { PageSize = 1, PageCount = 1, diff --git a/Octokit.Tests/Clients/IssueCommentsClientTests.cs b/Octokit.Tests/Clients/IssueCommentsClientTests.cs index 3f4578ed..7584eeb9 100644 --- a/Octokit.Tests/Clients/IssueCommentsClientTests.cs +++ b/Octokit.Tests/Clients/IssueCommentsClientTests.cs @@ -100,7 +100,7 @@ namespace Octokit.Tests.Clients var connection = Substitute.For(); var client = new IssueCommentsClient(connection); - var options = new ApiOptions() + var options = new ApiOptions { StartPage = 1, PageSize = 1, From f1896888c664e1f48aa64b07a117189cee677c11 Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Fri, 22 Apr 2016 17:30:37 +0700 Subject: [PATCH 4/4] Redundant commas in object initializer were removed. --- Octokit.Tests.Integration/Clients/IssuesClientTests.cs | 6 +++--- .../Clients/PullRequestReviewCommentsClientTests.cs | 4 ++-- .../Clients/RepositoryCommitsClientTests.cs | 2 +- .../Reactive/ObservableRepositoryCommitsClientTests.cs | 2 +- Octokit.Tests/Http/ApiInfoTests.cs | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/IssuesClientTests.cs b/Octokit.Tests.Integration/Clients/IssuesClientTests.cs index f8ef4495..b8ae2d64 100644 --- a/Octokit.Tests.Integration/Clients/IssuesClientTests.cs +++ b/Octokit.Tests.Integration/Clients/IssuesClientTests.cs @@ -297,7 +297,7 @@ public class IssuesClientTests : IDisposable var newIssue = new NewIssue("A test issue1") { - Body = "A new unassigned issue", + Body = "A new unassigned issue" }; newIssue.Labels.Add("something"); @@ -320,7 +320,7 @@ public class IssuesClientTests : IDisposable // setup us the issue var newIssue = new NewIssue("A test issue1") { - Body = "A new unassigned issue", + Body = "A new unassigned issue" }; newIssue.Labels.Add("something"); @@ -345,7 +345,7 @@ public class IssuesClientTests : IDisposable // setup us the issue var newIssue = new NewIssue("A test issue1") { - Body = "A new unassigned issue", + Body = "A new unassigned issue" }; newIssue.Labels.Add("something"); newIssue.Labels.Add("another thing"); diff --git a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs index f1af40d1..92d38d2f 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs @@ -249,7 +249,7 @@ public class PullRequestReviewCommentsClientTests : IDisposable var data = new PullRequestData { Sha = createdCommitInBranch.Sha, - Number = createdPullRequest.Number, + Number = createdPullRequest.Number }; return data; @@ -273,7 +273,7 @@ public class PullRequestReviewCommentsClientTests : IDisposable Type = TreeType.Blob, Mode = FileMode.File, Path = treePath, - Sha = createdBlob.Sha, + Sha = createdBlob.Sha }); var createdTree = await _github.Git.Tree.Create(Helper.UserName, repoName, newTree); diff --git a/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs index c0bf59bc..d6f61a20 100644 --- a/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs @@ -82,7 +82,7 @@ public class RepositoryCommitsClientTests var startOptions = new ApiOptions { PageSize = 5, - PageCount = 1, + PageCount = 1 }; var skipStartOptions = new ApiOptions diff --git a/Octokit.Tests.Integration/Reactive/ObservableRepositoryCommitsClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableRepositoryCommitsClientTests.cs index 63995c8c..48b6a75f 100644 --- a/Octokit.Tests.Integration/Reactive/ObservableRepositoryCommitsClientTests.cs +++ b/Octokit.Tests.Integration/Reactive/ObservableRepositoryCommitsClientTests.cs @@ -51,7 +51,7 @@ namespace Octokit.Tests.Integration.Reactive var startOptions = new ApiOptions { PageSize = 5, - PageCount = 1, + PageCount = 1 }; var skipStartOptions = new ApiOptions diff --git a/Octokit.Tests/Http/ApiInfoTests.cs b/Octokit.Tests/Http/ApiInfoTests.cs index d9c213c7..8b713ca3 100644 --- a/Octokit.Tests/Http/ApiInfoTests.cs +++ b/Octokit.Tests/Http/ApiInfoTests.cs @@ -36,7 +36,7 @@ namespace Octokit.Tests.Http }, new List { - "user", + "user" }, new List {