mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-09 04:56:29 +00:00
Adding a convention test to detect whether a model has a constructor exposing all properties (#1798)
* Added a convention test to detect a model constructor exposing all properties * add ctors to classes where they are missing * rename ctor parameters that dont match properties * add missing parameters to existing ctors * add specific PunchCard ctor to allow mocking, and update test to resolve call ambiguity * Added base class properties to the convention test Added member exclusion attribute * Updated newly offending classes 2 excludes and 2 ctors * rename exclusion attribute to be a bit shorter
This commit is contained in:
@@ -9,7 +9,7 @@ namespace Octokit
|
||||
{
|
||||
public CommitComment() { }
|
||||
|
||||
public CommitComment(int id, string url, string htmlUrl, string body, string path, int position, int? line, string commitId, User user, DateTimeOffset createdAt, DateTimeOffset? updatedAt)
|
||||
public CommitComment(int id, string url, string htmlUrl, string body, string path, int position, int? line, string commitId, User user, DateTimeOffset createdAt, DateTimeOffset? updatedAt, ReactionSummary reactions)
|
||||
{
|
||||
Id = id;
|
||||
Url = url;
|
||||
@@ -22,6 +22,7 @@ namespace Octokit
|
||||
User = user;
|
||||
CreatedAt = createdAt;
|
||||
UpdatedAt = updatedAt;
|
||||
Reactions = reactions;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -79,6 +80,9 @@ namespace Octokit
|
||||
/// </summary>
|
||||
public DateTimeOffset? UpdatedAt { get; protected set; }
|
||||
|
||||
/// <summary>
|
||||
/// The reaction summary for this comment.
|
||||
/// </summary>
|
||||
public ReactionSummary Reactions { get; protected set; }
|
||||
|
||||
internal string DebuggerDisplay
|
||||
|
||||
Reference in New Issue
Block a user