zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-05 19:46:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Adding a convention test to detect whether a model has a constructor exposing all properties (#1798)

Browse Source 
* Added a convention test to detect a model constructor exposing all properties

* add ctors to classes where they are missing

* rename ctor parameters that dont match properties

* add missing parameters to existing ctors

* add specific PunchCard ctor to allow mocking, and update test to resolve call ambiguity

* Added base class properties to the convention test

Added member exclusion attribute

* Updated newly offending classes

2 excludes and 2 ctors

* rename exclusion attribute to be a bit shorter
This commit is contained in:
tasadar2
2018-04-25 07:03:13 -04:00
committed by Ryan Gribble
parent f9bf9b2347
commit 3345f76fc9
34 changed files with 232 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit/Models/Response/PullRequestReviewComment.cs
+5 -1
View File
@@ -15,7 +15,7 @@ namespace Octokit
Id = id;
}
public PullRequestReviewComment(string url, int id, string diffHunk, string path, int? position, int? originalPosition, string commitId, string originalCommitId, User user, string body, DateTimeOffset createdAt, DateTimeOffset updatedAt, string htmlUrl, string pullRequestUrl, int? inReplyToId, int? pullRequestReviewId)
public PullRequestReviewComment(string url, int id, string diffHunk, string path, int? position, int? originalPosition, string commitId, string originalCommitId, User user, string body, DateTimeOffset createdAt, DateTimeOffset updatedAt, string htmlUrl, string pullRequestUrl, ReactionSummary reactions, int? inReplyToId, int? pullRequestReviewId)
{
PullRequestReviewId = pullRequestReviewId;
Url = url;
@@ -32,6 +32,7 @@ namespace Octokit
UpdatedAt = updatedAt;
HtmlUrl = htmlUrl;
PullRequestUrl = pullRequestUrl;
Reactions = reactions;
InReplyToId = inReplyToId;
}
@@ -105,6 +106,9 @@ namespace Octokit
/// </summary>
public string PullRequestUrl { get; protected set; }
/// <summary>
/// The reaction summary for this comment.
/// </summary>
public ReactionSummary Reactions { get; protected set; }
/// <summary>