From 36c08248fa53c50200ff03c929a379b08bf9a3eb Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Sun, 10 Apr 2016 22:28:18 +0700 Subject: [PATCH] New convention test was added. Now each "TheCtor" class must have "EnsuresNonNullArguments" method were throwing of ArgumentNullException from client constructor class should be tested. All unused "using" directives were removed. --- .../ClientConstructorTests.cs | 23 ++++++++++++++---- ...singClientConstructorTestClassException.cs | 2 +- ...ingClientConstructorTestMethodException.cs | 16 +++++++++++++ .../Octokit.Tests.Conventions.csproj | 1 + Octokit.Tests/Clients/AssigneesClientTests.cs | 2 +- .../Clients/AuthorizationsClientTests.cs | 2 +- Octokit.Tests/Clients/CommitsClientTests.cs | 3 +-- .../Clients/DeploymentStatusClientTests.cs | 2 +- .../Clients/DeploymentsClientTests.cs | 2 +- .../Clients/GistCommentsClientTests.cs | 4 ++-- Octokit.Tests/Clients/GistsClientTests.cs | 2 +- .../Clients/GitDatabaseClientTests.cs | 2 +- .../Clients/IssueCommentsClientTests.cs | 12 +++++----- Octokit.Tests/Clients/IssuesClientTests.cs | 3 +-- Octokit.Tests/Clients/MergingClientTests.cs | 3 +-- .../Clients/MilestonesClientTests.cs | 3 +-- .../Clients/MiscellaneousClientTests.cs | 2 +- Octokit.Tests/Clients/OauthClientTests.cs | 2 +- .../Clients/OrganizationMembersClientTests.cs | 3 +-- .../PullRequestReviewCommentsClientTests.cs | 6 +++++ .../Clients/PullRequestsClientTests.cs | 2 +- .../Clients/ReferencesClientTests.cs | 3 +-- Octokit.Tests/Clients/ReleasesClientTests.cs | 2 +- .../Clients/RepoCollaboratorsClientTests.cs | 2 +- .../Clients/RepositoryCommentsClientTests.cs | 3 +-- .../RepositoryDeployKeysClientTests.cs | 2 +- Octokit.Tests/Clients/SshKeysClientTests.cs | 2 +- .../Clients/StatisticsClientTests.cs | 2 +- Octokit.Tests/Clients/TagsClientTests.cs | 2 +- Octokit.Tests/Clients/TreesClientTests.cs | 3 +-- .../Clients/UserEmailsClientTests.cs | 2 +- Octokit.Tests/Clients/UserKeysClientTests.cs | 3 +-- Octokit.Tests/Clients/UsersClientTests.cs | 2 +- Octokit.Tests/GitHubClientTests.cs | 24 +++++++++++++++++++ ...ableEnterpriseSearchIndexingClientTests.cs | 2 +- .../Reactive/ObservableBlobClientTests.cs | 4 +--- .../Reactive/ObservableCommitsClientTests.cs | 2 +- .../ObservableDeploymentStatusClientTests.cs | 2 +- .../ObservableDeploymentsClientTests.cs | 2 +- .../ObservableIssueCommentsClientTests.cs | 4 +--- .../Reactive/ObservableIssuesClientTests.cs | 3 +-- .../ObservableMilestonesClientTests.cs | 3 +-- .../ObservableMiscellaneousClientTests.cs | 2 +- .../ObservablePullRequestsClientTests.cs | 4 ++-- .../Reactive/ObservableReleasesClientTests.cs | 2 +- .../ObservableRepositoryCommitsClientTests.cs | 2 +- ...servableRepositoryDeployKeysClientTests.cs | 2 +- .../Reactive/ObservableStarredClientTests.cs | 2 +- .../Reactive/ObservableTeamsClientTests.cs | 3 +-- .../Reactive/ObservableTreesClientTests.cs | 2 +- ...ObservableUserAdministrationClientTests.cs | 2 +- .../Reactive/ObservableUserKeysClientTests.cs | 3 +-- 52 files changed, 119 insertions(+), 76 deletions(-) create mode 100644 Octokit.Tests.Conventions/Exception/MissingClientConstructorTestMethodException.cs diff --git a/Octokit.Tests.Conventions/ClientConstructorTests.cs b/Octokit.Tests.Conventions/ClientConstructorTests.cs index 2fae7a8d..b5d0e7a5 100644 --- a/Octokit.Tests.Conventions/ClientConstructorTests.cs +++ b/Octokit.Tests.Conventions/ClientConstructorTests.cs @@ -8,19 +8,32 @@ namespace Octokit.Tests.Conventions public class ClientConstructorTests { [Theory] - [MemberData("GetTestConstructorsClasses")] - public void CheckTestConstructorsNames(Type type) + [MemberData("GetTestConstructorClasses")] + public void CheckTestConstructorNames(Type type) { - const string constructorClassName = "TheCtor"; + const string constructorTestClassName = "TheCtor"; + const string constructorTestMethodName = "EnsuresNonNullArguments"; + var classes = new HashSet(type.GetNestedTypes().Select(t => t.Name)); - if (!classes.Contains(constructorClassName)) + if (!classes.Contains(constructorTestClassName)) { throw new MissingClientConstructorTestClassException(type); } + + var ctors = type.GetNestedTypes().Where(t => t.Name == constructorTestClassName) + .SelectMany(t => t.GetMethods()) + .Where(info => info.ReturnType == typeof(void) && info.IsPublic) + .Select(info => info.Name); + + var methods = new HashSet(ctors); + if (!methods.Contains(constructorTestMethodName)) + { + throw new MissingClientConstructorTestMethodException(type); + } } - public static IEnumerable GetTestConstructorsClasses() + public static IEnumerable GetTestConstructorClasses() { var tests = typeof(GitHubClientTests) .Assembly diff --git a/Octokit.Tests.Conventions/Exception/MissingClientConstructorTestClassException.cs b/Octokit.Tests.Conventions/Exception/MissingClientConstructorTestClassException.cs index e620972e..231929db 100644 --- a/Octokit.Tests.Conventions/Exception/MissingClientConstructorTestClassException.cs +++ b/Octokit.Tests.Conventions/Exception/MissingClientConstructorTestClassException.cs @@ -10,7 +10,7 @@ namespace Octokit.Tests.Conventions static string CreateMessage(Type ctorTest) { - return string.Format("Constructor test method is missing {0}.", ctorTest.FullName); + return string.Format("Constructor test class is missing {0}.", ctorTest.FullName); } } } \ No newline at end of file diff --git a/Octokit.Tests.Conventions/Exception/MissingClientConstructorTestMethodException.cs b/Octokit.Tests.Conventions/Exception/MissingClientConstructorTestMethodException.cs new file mode 100644 index 00000000..a5908f13 --- /dev/null +++ b/Octokit.Tests.Conventions/Exception/MissingClientConstructorTestMethodException.cs @@ -0,0 +1,16 @@ +using System; + +namespace Octokit.Tests.Conventions +{ + public class MissingClientConstructorTestMethodException : Exception + { + public MissingClientConstructorTestMethodException(Type modelType) + : base(CreateMessage(modelType)) + { } + + static string CreateMessage(Type ctorTest) + { + return string.Format("Constructor test method is missing {0}.", ctorTest.FullName); + } + } +} \ No newline at end of file diff --git a/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj b/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj index 780930f7..e06a67b8 100644 --- a/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj +++ b/Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj @@ -65,6 +65,7 @@ + diff --git a/Octokit.Tests/Clients/AssigneesClientTests.cs b/Octokit.Tests/Clients/AssigneesClientTests.cs index e5c56018..cf03eedc 100644 --- a/Octokit.Tests/Clients/AssigneesClientTests.cs +++ b/Octokit.Tests/Clients/AssigneesClientTests.cs @@ -115,7 +115,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new AssigneesClient(null)); } diff --git a/Octokit.Tests/Clients/AuthorizationsClientTests.cs b/Octokit.Tests/Clients/AuthorizationsClientTests.cs index 4e11ecd1..91887a6e 100644 --- a/Octokit.Tests/Clients/AuthorizationsClientTests.cs +++ b/Octokit.Tests/Clients/AuthorizationsClientTests.cs @@ -17,7 +17,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void ThrowsForBadArgs() + public void EnsuresNonNullArguments() { Assert.Throws(() => new AuthorizationsClient(null)); } diff --git a/Octokit.Tests/Clients/CommitsClientTests.cs b/Octokit.Tests/Clients/CommitsClientTests.cs index 66bebed9..6c1c4201 100644 --- a/Octokit.Tests/Clients/CommitsClientTests.cs +++ b/Octokit.Tests/Clients/CommitsClientTests.cs @@ -4,7 +4,6 @@ using System.Linq; using System.Threading.Tasks; using NSubstitute; using Octokit; -using Octokit.Tests.Helpers; using Xunit; public class CommitsClientTests @@ -71,7 +70,7 @@ public class CommitsClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new CommitsClient(null)); } diff --git a/Octokit.Tests/Clients/DeploymentStatusClientTests.cs b/Octokit.Tests/Clients/DeploymentStatusClientTests.cs index bbf306d4..e88080c0 100644 --- a/Octokit.Tests/Clients/DeploymentStatusClientTests.cs +++ b/Octokit.Tests/Clients/DeploymentStatusClientTests.cs @@ -105,7 +105,7 @@ public class DeploymentStatusClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new DeploymentStatusClient(null)); } diff --git a/Octokit.Tests/Clients/DeploymentsClientTests.cs b/Octokit.Tests/Clients/DeploymentsClientTests.cs index 804835cc..a29e555a 100644 --- a/Octokit.Tests/Clients/DeploymentsClientTests.cs +++ b/Octokit.Tests/Clients/DeploymentsClientTests.cs @@ -143,7 +143,7 @@ public class DeploymentsClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new DeploymentsClient(null)); } diff --git a/Octokit.Tests/Clients/GistCommentsClientTests.cs b/Octokit.Tests/Clients/GistCommentsClientTests.cs index 66b33d38..6b9cf86e 100644 --- a/Octokit.Tests/Clients/GistCommentsClientTests.cs +++ b/Octokit.Tests/Clients/GistCommentsClientTests.cs @@ -10,7 +10,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new GistCommentsClient(null)); } @@ -71,7 +71,7 @@ namespace Octokit.Tests.Clients await Assert.ThrowsAsync(() => client.GetAllForGist("")); await Assert.ThrowsAsync(() => client.GetAllForGist("24", null)); await Assert.ThrowsAsync(() => client.GetAllForGist("", ApiOptions.None)); - + } } diff --git a/Octokit.Tests/Clients/GistsClientTests.cs b/Octokit.Tests/Clients/GistsClientTests.cs index 56c31186..a0519246 100644 --- a/Octokit.Tests/Clients/GistsClientTests.cs +++ b/Octokit.Tests/Clients/GistsClientTests.cs @@ -305,7 +305,7 @@ public class GistsClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new GistsClient(null)); } diff --git a/Octokit.Tests/Clients/GitDatabaseClientTests.cs b/Octokit.Tests/Clients/GitDatabaseClientTests.cs index d66c5ffe..159b44a9 100644 --- a/Octokit.Tests/Clients/GitDatabaseClientTests.cs +++ b/Octokit.Tests/Clients/GitDatabaseClientTests.cs @@ -8,7 +8,7 @@ public class GitDatabaseClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new GitDatabaseClient(null)); } diff --git a/Octokit.Tests/Clients/IssueCommentsClientTests.cs b/Octokit.Tests/Clients/IssueCommentsClientTests.cs index a3788f07..dcae0577 100644 --- a/Octokit.Tests/Clients/IssueCommentsClientTests.cs +++ b/Octokit.Tests/Clients/IssueCommentsClientTests.cs @@ -209,14 +209,14 @@ namespace Octokit.Tests.Clients } } - public class TheCtor + public class TheCtor + { + [Fact] + public void EnsuresNonNullArguments() { - [Fact] - public void EnsuresArgument() - { - Assert.Throws(() => new IssueCommentsClient(null)); - } + Assert.Throws(() => new IssueCommentsClient(null)); } + } [Fact] public void CanDeserializeIssueComment() diff --git a/Octokit.Tests/Clients/IssuesClientTests.cs b/Octokit.Tests/Clients/IssuesClientTests.cs index bcb14395..9dbe0436 100644 --- a/Octokit.Tests/Clients/IssuesClientTests.cs +++ b/Octokit.Tests/Clients/IssuesClientTests.cs @@ -4,7 +4,6 @@ using System.Net; using System.Threading.Tasks; using NSubstitute; using Octokit.Internal; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Clients @@ -240,7 +239,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new IssuesClient(null)); } diff --git a/Octokit.Tests/Clients/MergingClientTests.cs b/Octokit.Tests/Clients/MergingClientTests.cs index 7d5751ec..fa384c94 100644 --- a/Octokit.Tests/Clients/MergingClientTests.cs +++ b/Octokit.Tests/Clients/MergingClientTests.cs @@ -1,7 +1,6 @@ using System; using System.Threading.Tasks; using NSubstitute; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Clients @@ -46,7 +45,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new CommitsClient(null)); } diff --git a/Octokit.Tests/Clients/MilestonesClientTests.cs b/Octokit.Tests/Clients/MilestonesClientTests.cs index 22931232..e5807a7c 100644 --- a/Octokit.Tests/Clients/MilestonesClientTests.cs +++ b/Octokit.Tests/Clients/MilestonesClientTests.cs @@ -2,7 +2,6 @@ using System.Collections.Generic; using System.Threading.Tasks; using NSubstitute; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Clients @@ -151,7 +150,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new MilestonesClient(null)); } diff --git a/Octokit.Tests/Clients/MiscellaneousClientTests.cs b/Octokit.Tests/Clients/MiscellaneousClientTests.cs index e8e245bf..07e50660 100644 --- a/Octokit.Tests/Clients/MiscellaneousClientTests.cs +++ b/Octokit.Tests/Clients/MiscellaneousClientTests.cs @@ -175,7 +175,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgumentsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new MiscellaneousClient(null)); } diff --git a/Octokit.Tests/Clients/OauthClientTests.cs b/Octokit.Tests/Clients/OauthClientTests.cs index 9bbbff77..7f723b26 100644 --- a/Octokit.Tests/Clients/OauthClientTests.cs +++ b/Octokit.Tests/Clients/OauthClientTests.cs @@ -12,7 +12,7 @@ public class OauthClientTests public class TheCtor { [Fact] - public void EnsuresArgumentIsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new OauthClient(null)); diff --git a/Octokit.Tests/Clients/OrganizationMembersClientTests.cs b/Octokit.Tests/Clients/OrganizationMembersClientTests.cs index 9992ab7b..4bf1b353 100644 --- a/Octokit.Tests/Clients/OrganizationMembersClientTests.cs +++ b/Octokit.Tests/Clients/OrganizationMembersClientTests.cs @@ -4,7 +4,6 @@ using System.Net; using System.Threading.Tasks; using NSubstitute; using Octokit.Internal; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Clients @@ -18,7 +17,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsureNonNullArguments() + public void EnsuresNonNullArguments() { Assert.Throws(() => new OrganizationMembersClient(null)); } diff --git a/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs b/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs index 8ab043ed..99ebd227 100644 --- a/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs +++ b/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs @@ -9,6 +9,12 @@ public class PullRequestReviewCommentsClientTests { public class TheCtor { + [Fact] + public void EnsuresNonNullArguments() + { + Assert.Throws(() => new PullRequestReviewCommentsClient(null)); + } + [Fact] public void PullRequestReviewCommentCreateEnsuresArgumentsValue() { diff --git a/Octokit.Tests/Clients/PullRequestsClientTests.cs b/Octokit.Tests/Clients/PullRequestsClientTests.cs index c1067e66..0c02a124 100644 --- a/Octokit.Tests/Clients/PullRequestsClientTests.cs +++ b/Octokit.Tests/Clients/PullRequestsClientTests.cs @@ -249,7 +249,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new PullRequestsClient(null)); } diff --git a/Octokit.Tests/Clients/ReferencesClientTests.cs b/Octokit.Tests/Clients/ReferencesClientTests.cs index ce8bdd53..5d75b1b3 100644 --- a/Octokit.Tests/Clients/ReferencesClientTests.cs +++ b/Octokit.Tests/Clients/ReferencesClientTests.cs @@ -1,7 +1,6 @@ using System; using System.Threading.Tasks; using NSubstitute; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Clients @@ -11,7 +10,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ReferencesClient(null)); } diff --git a/Octokit.Tests/Clients/ReleasesClientTests.cs b/Octokit.Tests/Clients/ReleasesClientTests.cs index bb436d0f..9e79d47e 100644 --- a/Octokit.Tests/Clients/ReleasesClientTests.cs +++ b/Octokit.Tests/Clients/ReleasesClientTests.cs @@ -11,7 +11,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArgumentIsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ReleasesClient(null)); diff --git a/Octokit.Tests/Clients/RepoCollaboratorsClientTests.cs b/Octokit.Tests/Clients/RepoCollaboratorsClientTests.cs index efeef7aa..5fb84fc9 100644 --- a/Octokit.Tests/Clients/RepoCollaboratorsClientTests.cs +++ b/Octokit.Tests/Clients/RepoCollaboratorsClientTests.cs @@ -17,7 +17,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void ThrowsForBadArgs() + public void EnsuresNonNullArguments() { Assert.Throws(() => new RepoCollaboratorsClient(null)); } diff --git a/Octokit.Tests/Clients/RepositoryCommentsClientTests.cs b/Octokit.Tests/Clients/RepositoryCommentsClientTests.cs index 09177c95..a4083ed4 100644 --- a/Octokit.Tests/Clients/RepositoryCommentsClientTests.cs +++ b/Octokit.Tests/Clients/RepositoryCommentsClientTests.cs @@ -5,7 +5,6 @@ using System.Threading.Tasks; using NSubstitute; using Octokit; using Octokit.Internal; -using Octokit.Tests.Helpers; using Xunit; public class RepositoryCommentsClientTests @@ -177,7 +176,7 @@ public class RepositoryCommentsClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new RepositoryCommentsClient(null)); } diff --git a/Octokit.Tests/Clients/RepositoryDeployKeysClientTests.cs b/Octokit.Tests/Clients/RepositoryDeployKeysClientTests.cs index 40037fdb..2362fef4 100644 --- a/Octokit.Tests/Clients/RepositoryDeployKeysClientTests.cs +++ b/Octokit.Tests/Clients/RepositoryDeployKeysClientTests.cs @@ -14,7 +14,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void ThrowsForBadArgs() + public void EnsuresNonNullArguments() { Assert.Throws(() => new RepositoryDeployKeysClient(null)); } diff --git a/Octokit.Tests/Clients/SshKeysClientTests.cs b/Octokit.Tests/Clients/SshKeysClientTests.cs index cdbf93a0..0d48820d 100644 --- a/Octokit.Tests/Clients/SshKeysClientTests.cs +++ b/Octokit.Tests/Clients/SshKeysClientTests.cs @@ -14,7 +14,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void ThrowsForBadArgs() + public void EnsuresNonNullArguments() { Assert.Throws(() => new SshKeysClient(null)); } diff --git a/Octokit.Tests/Clients/StatisticsClientTests.cs b/Octokit.Tests/Clients/StatisticsClientTests.cs index 92273c78..6b2b6ece 100644 --- a/Octokit.Tests/Clients/StatisticsClientTests.cs +++ b/Octokit.Tests/Clients/StatisticsClientTests.cs @@ -13,7 +13,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void DoesThrowOnBadArguments() + public void EnsuresNonNullArguments() { Assert.Throws(() => new StatisticsClient(null)); } diff --git a/Octokit.Tests/Clients/TagsClientTests.cs b/Octokit.Tests/Clients/TagsClientTests.cs index 6d5c1a46..384594c9 100644 --- a/Octokit.Tests/Clients/TagsClientTests.cs +++ b/Octokit.Tests/Clients/TagsClientTests.cs @@ -64,7 +64,7 @@ public class TagsClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new TagsClient(null)); } diff --git a/Octokit.Tests/Clients/TreesClientTests.cs b/Octokit.Tests/Clients/TreesClientTests.cs index 687fe9c4..458f9a14 100644 --- a/Octokit.Tests/Clients/TreesClientTests.cs +++ b/Octokit.Tests/Clients/TreesClientTests.cs @@ -4,7 +4,6 @@ using System.Net; using System.Threading.Tasks; using NSubstitute; using Octokit.Internal; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests @@ -108,7 +107,7 @@ namespace Octokit.Tests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new TreesClient(null)); } diff --git a/Octokit.Tests/Clients/UserEmailsClientTests.cs b/Octokit.Tests/Clients/UserEmailsClientTests.cs index 9ea83029..0ccbb8c7 100644 --- a/Octokit.Tests/Clients/UserEmailsClientTests.cs +++ b/Octokit.Tests/Clients/UserEmailsClientTests.cs @@ -113,7 +113,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArguments() + public void EnsuresNonNullArguments() { Assert.Throws( () => new UserEmailsClient(null)); diff --git a/Octokit.Tests/Clients/UserKeysClientTests.cs b/Octokit.Tests/Clients/UserKeysClientTests.cs index e36369f0..d1a044d8 100644 --- a/Octokit.Tests/Clients/UserKeysClientTests.cs +++ b/Octokit.Tests/Clients/UserKeysClientTests.cs @@ -1,6 +1,5 @@ using NSubstitute; using System; -using System.Collections.Generic; using System.Threading.Tasks; using Xunit; @@ -129,7 +128,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void EnsuresArguments() + public void EnsuresNonNullArguments() { Assert.Throws( () => new UserEmailsClient(null)); diff --git a/Octokit.Tests/Clients/UsersClientTests.cs b/Octokit.Tests/Clients/UsersClientTests.cs index 80c5f110..92b288b8 100644 --- a/Octokit.Tests/Clients/UsersClientTests.cs +++ b/Octokit.Tests/Clients/UsersClientTests.cs @@ -18,7 +18,7 @@ namespace Octokit.Tests.Clients public class TheCtor { [Fact] - public void ThrowsForBadArgs() + public void EnsuresNonNullArguments() { Assert.Throws(() => new UsersClient(null)); } diff --git a/Octokit.Tests/GitHubClientTests.cs b/Octokit.Tests/GitHubClientTests.cs index 41d60c74..1c7d3dad 100644 --- a/Octokit.Tests/GitHubClientTests.cs +++ b/Octokit.Tests/GitHubClientTests.cs @@ -11,6 +11,30 @@ namespace Octokit.Tests { public class TheCtor { + [Fact] + public void EnsuresNonNullArguments() + { + Assert.Throws(() => new GitHubClient((IConnection)null)); + Assert.Throws(() => new GitHubClient((ProductHeaderValue)null)); + + Assert.Throws(() => new GitHubClient(new ProductHeaderValue("UnitTest"), (ICredentialStore)null)); + Assert.Throws(() => new GitHubClient(null, Substitute.For())); + + Assert.Throws(() => new GitHubClient(new ProductHeaderValue("UnitTest"), (Uri)null)); + Assert.Throws(() => new GitHubClient(null, new Uri("http://github.com"))); + + Assert.Throws(() => new GitHubClient(null, (ICredentialStore)null)); + Assert.Throws(() => new GitHubClient(null, (Uri)null)); + + Assert.Throws(() => new GitHubClient(new ProductHeaderValue("UnitTest"), null, null)); + Assert.Throws(() => new GitHubClient(null, Substitute.For(), null)); + Assert.Throws(() => new GitHubClient(null, null, new Uri("http://github.com"))); + + Assert.Throws(() => new GitHubClient(null, Substitute.For(), new Uri("http://github.com"))); + Assert.Throws(() => new GitHubClient(new ProductHeaderValue("UnitTest"), null, new Uri("http://github.com"))); + Assert.Throws(() => new GitHubClient(new ProductHeaderValue("UnitTest"), Substitute.For(), null)); + } + [Fact] public void CreatesAnonymousClientByDefault() { diff --git a/Octokit.Tests/Reactive/Enterprise/ObservableEnterpriseSearchIndexingClientTests.cs b/Octokit.Tests/Reactive/Enterprise/ObservableEnterpriseSearchIndexingClientTests.cs index eb1de683..d6e5607f 100644 --- a/Octokit.Tests/Reactive/Enterprise/ObservableEnterpriseSearchIndexingClientTests.cs +++ b/Octokit.Tests/Reactive/Enterprise/ObservableEnterpriseSearchIndexingClientTests.cs @@ -10,7 +10,7 @@ namespace Octokit.Tests public class TheCtor { [Fact] - public void EnsuresArgumentIsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableEnterpriseSearchIndexingClient(null)); diff --git a/Octokit.Tests/Reactive/ObservableBlobClientTests.cs b/Octokit.Tests/Reactive/ObservableBlobClientTests.cs index b182a818..6db6e1e9 100644 --- a/Octokit.Tests/Reactive/ObservableBlobClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableBlobClientTests.cs @@ -1,10 +1,8 @@ using System; -using System.Reactive.Linq; using System.Reactive.Threading.Tasks; using System.Threading.Tasks; using NSubstitute; using Octokit.Reactive; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Reactive @@ -69,7 +67,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableBlobClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableCommitsClientTests.cs b/Octokit.Tests/Reactive/ObservableCommitsClientTests.cs index 5b379cc7..da6bda02 100644 --- a/Octokit.Tests/Reactive/ObservableCommitsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableCommitsClientTests.cs @@ -12,7 +12,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgumentIsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableCommitsClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableDeploymentStatusClientTests.cs b/Octokit.Tests/Reactive/ObservableDeploymentStatusClientTests.cs index 8e0dd99f..0360d467 100644 --- a/Octokit.Tests/Reactive/ObservableDeploymentStatusClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableDeploymentStatusClientTests.cs @@ -121,7 +121,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws( () => new ObservableDeploymentStatusClient(null)); diff --git a/Octokit.Tests/Reactive/ObservableDeploymentsClientTests.cs b/Octokit.Tests/Reactive/ObservableDeploymentsClientTests.cs index 477d1d78..38328dfc 100644 --- a/Octokit.Tests/Reactive/ObservableDeploymentsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableDeploymentsClientTests.cs @@ -174,7 +174,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArguments() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableDeploymentsClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableIssueCommentsClientTests.cs b/Octokit.Tests/Reactive/ObservableIssueCommentsClientTests.cs index 958ff020..2992c74a 100644 --- a/Octokit.Tests/Reactive/ObservableIssueCommentsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableIssueCommentsClientTests.cs @@ -1,11 +1,9 @@ using System; using System.Collections.Generic; -using System.Reactive.Linq; using System.Reactive.Threading.Tasks; using System.Threading.Tasks; using NSubstitute; using Octokit.Reactive; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Reactive @@ -192,7 +190,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableIssueCommentsClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableIssuesClientTests.cs b/Octokit.Tests/Reactive/ObservableIssuesClientTests.cs index c511b901..c063e5d4 100644 --- a/Octokit.Tests/Reactive/ObservableIssuesClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableIssuesClientTests.cs @@ -2,7 +2,6 @@ using Octokit; using Octokit.Internal; using Octokit.Reactive; -using Octokit.Tests.Helpers; using System; using System.Collections.Generic; using System.Reactive.Linq; @@ -390,7 +389,7 @@ public class ObservableIssuesClientTests public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new IssuesClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableMilestonesClientTests.cs b/Octokit.Tests/Reactive/ObservableMilestonesClientTests.cs index 1c9b2690..beade987 100644 --- a/Octokit.Tests/Reactive/ObservableMilestonesClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableMilestonesClientTests.cs @@ -6,7 +6,6 @@ using System.Threading.Tasks; using NSubstitute; using Octokit.Internal; using Octokit.Reactive; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Reactive @@ -236,7 +235,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new MilestonesClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableMiscellaneousClientTests.cs b/Octokit.Tests/Reactive/ObservableMiscellaneousClientTests.cs index b5a47719..b069c08b 100644 --- a/Octokit.Tests/Reactive/ObservableMiscellaneousClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableMiscellaneousClientTests.cs @@ -136,7 +136,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableMiscellaneousClient((IGitHubClient)null)); } diff --git a/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs b/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs index f9d7eec1..3d8ad7b9 100644 --- a/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs @@ -7,7 +7,6 @@ using System.Threading.Tasks; using NSubstitute; using Octokit.Internal; using Octokit.Reactive; -using Octokit.Tests.Helpers; using Xunit; namespace Octokit.Tests.Reactive @@ -352,10 +351,11 @@ namespace Octokit.Tests.Reactive await Assert.ThrowsAsync(() => client.Files("owner", "", 1)); } } + public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new PullRequestsClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableReleasesClientTests.cs b/Octokit.Tests/Reactive/ObservableReleasesClientTests.cs index 0282829f..ca163f6d 100644 --- a/Octokit.Tests/Reactive/ObservableReleasesClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableReleasesClientTests.cs @@ -12,7 +12,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgumentIsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableReleasesClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableRepositoryCommitsClientTests.cs b/Octokit.Tests/Reactive/ObservableRepositoryCommitsClientTests.cs index 07d15de3..9891b046 100644 --- a/Octokit.Tests/Reactive/ObservableRepositoryCommitsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableRepositoryCommitsClientTests.cs @@ -12,7 +12,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableRepositoryCommitsClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableRepositoryDeployKeysClientTests.cs b/Octokit.Tests/Reactive/ObservableRepositoryDeployKeysClientTests.cs index 83946659..81a4f439 100644 --- a/Octokit.Tests/Reactive/ObservableRepositoryDeployKeysClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableRepositoryDeployKeysClientTests.cs @@ -11,7 +11,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void ThrowsForBadArgs() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableRepositoryDeployKeysClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableStarredClientTests.cs b/Octokit.Tests/Reactive/ObservableStarredClientTests.cs index 684ba48a..c6924dd6 100644 --- a/Octokit.Tests/Reactive/ObservableStarredClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableStarredClientTests.cs @@ -13,7 +13,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgumentIsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableStarredClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableTeamsClientTests.cs b/Octokit.Tests/Reactive/ObservableTeamsClientTests.cs index eebd3491..5fc8bd39 100644 --- a/Octokit.Tests/Reactive/ObservableTeamsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableTeamsClientTests.cs @@ -1,6 +1,5 @@ using System; using System.Reactive.Threading.Tasks; -using System.Threading.Tasks; using NSubstitute; using Octokit.Reactive; using Xunit; @@ -38,7 +37,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresNotNullGitHubClient() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableTeamsClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableTreesClientTests.cs b/Octokit.Tests/Reactive/ObservableTreesClientTests.cs index 30af7c91..d2e0920c 100644 --- a/Octokit.Tests/Reactive/ObservableTreesClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableTreesClientTests.cs @@ -12,7 +12,7 @@ namespace Octokit.Tests public class TheCtor { [Fact] - public void EnsuresArgumentIsNotNull() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableTreesClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableUserAdministrationClientTests.cs b/Octokit.Tests/Reactive/ObservableUserAdministrationClientTests.cs index d6a1fab9..5290511a 100644 --- a/Octokit.Tests/Reactive/ObservableUserAdministrationClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableUserAdministrationClientTests.cs @@ -180,7 +180,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableUserAdministrationClient(null)); } diff --git a/Octokit.Tests/Reactive/ObservableUserKeysClientTests.cs b/Octokit.Tests/Reactive/ObservableUserKeysClientTests.cs index 3a569e27..385a5a1f 100644 --- a/Octokit.Tests/Reactive/ObservableUserKeysClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableUserKeysClientTests.cs @@ -1,5 +1,4 @@ using System; -using System.Linq; using NSubstitute; using Octokit.Reactive; using Xunit; @@ -84,7 +83,7 @@ namespace Octokit.Tests.Reactive public class TheCtor { [Fact] - public void EnsuresArgument() + public void EnsuresNonNullArguments() { Assert.Throws(() => new ObservableUserKeysClient(null)); }