diff --git a/Octokit.Reactive/Clients/ObservableMergingClient.cs b/Octokit.Reactive/Clients/ObservableMergingClient.cs index d52eac8f..719267a5 100644 --- a/Octokit.Reactive/Clients/ObservableMergingClient.cs +++ b/Octokit.Reactive/Clients/ObservableMergingClient.cs @@ -25,6 +25,10 @@ namespace Octokit.Reactive /// public IObservable Create(string owner, string name, NewMerge merge) { + Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); + Ensure.ArgumentNotNullOrEmptyString(name, "name"); + Ensure.ArgumentNotNull(merge, "merge"); + return _client.Create(owner, name, merge).ToObservable(); } @@ -39,6 +43,8 @@ namespace Octokit.Reactive /// public IObservable Create(int repositoryId, NewMerge merge) { + Ensure.ArgumentNotNull(merge, "merge"); + return _client.Create(repositoryId, merge).ToObservable(); } } diff --git a/Octokit.Tests/Reactive/ObservableMergingClientTests.cs b/Octokit.Tests/Reactive/ObservableMergingClientTests.cs index f6ff2405..444b1481 100644 --- a/Octokit.Tests/Reactive/ObservableMergingClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableMergingClientTests.cs @@ -46,13 +46,15 @@ namespace Octokit.Tests.Clients var client = new ObservableMergingClient(Substitute.For()); var newMerge = new NewMerge("baseBranch", "shaToMerge") { CommitMessage = "some mergingMessage" }; + Assert.Throws(() => client.Create(null, "name", newMerge)); Assert.Throws(() => client.Create("owner", null, newMerge)); Assert.Throws(() => client.Create("owner", "name", null)); + Assert.Throws(() => client.Create(1, null)); + Assert.Throws(() => client.Create("", "name", newMerge)); Assert.Throws(() => client.Create("owner", "", newMerge)); - Assert.Throws(() => client.Create("owner", "", null)); } }