zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-08 04:40:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Release v0.24 - A Sight For Sore Eyes (#1539)

Browse Source 
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
This commit is contained in:
Ryan Gribble
2017-01-17 18:56:55 +10:00
committed by GitHub
parent aa80eaa551
commit 3c818934b8
133 changed files with 434 additions and 416 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Reactive/Clients/IObservableStarredClient.cs
+4 -4
View File
@@ -33,7 +33,7 @@ namespace Octokit.Reactive
/// <param name="options">Options for changing the API response</param>
/// <exception cref="AuthorizationException">Thrown if the client is not authenticated</exception>
IObservable<User> GetAllStargazers(string owner, string name, ApiOptions options);
/// <summary>
/// Retrieves all of the stargazers for the passed repository
/// </summary>
@@ -49,7 +49,7 @@ namespace Octokit.Reactive
/// <param name="name">The name of the repository</param>
/// <exception cref="AuthorizationException">Thrown if the client is not authenticated.</exception>
IObservable<UserStar> GetAllStargazersWithTimestamps(string owner, string name);
/// <summary>
/// Retrieves all of the stargazers for the passed repository with star creation timestamps.
/// </summary>
@@ -79,7 +79,7 @@ namespace Octokit.Reactive
/// </summary>
/// <exception cref="AuthorizationException">Thrown if the client is not authenticated</exception>
IObservable<Repository> GetAllForCurrent();
/// <summary>
/// Retrieves all of the starred <see cref="Repository"/>(ies) for the current user
/// </summary>
@@ -91,7 +91,7 @@ namespace Octokit.Reactive
/// </summary>
/// <exception cref="AuthorizationException">Thrown if the client is not authenticated.</exception>
IObservable<RepositoryStar> GetAllForCurrentWithTimestamps();
/// <summary>
/// Retrieves all of the starred <see cref="Repository"/>(ies) for the current user with star creation timestamps.
/// </summary>