mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-07 04:16:51 +00:00
Release v0.24 - A Sight For Sore Eyes (#1539)
* Add release notes and bump version to 0.24 * run "build FormatCode" to fix up whitespace/formatting issues * Fix failing Ssh key tests due to "validation exception". This key must be in use on github (under another user, most likely from these tests failing). Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed * Assignee and Assignees cant both be specified on NewIssue. We missed this one in the PR. Marked Assignee as [Obsolete] and fixed tests to use Assignees * Fix a couple of Reactions tests that were calling the wrong client methods * Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it) * Fix some following tests that require the test user to follow more than 1 other user * Unskip these Event tests now because apparently they work! * add breaking changes notes * Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540) * return null if ApiError.Message is empty or whitespace * Uncomment test, which now passes * update release notes to include PR1540 * Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541) * Update to include PR1541 * add bullets to make release notes easier to read * markup additional code mentions in notes * Fix grammar fields => field
This commit is contained in:
@@ -83,7 +83,7 @@ namespace Octokit.Tests.Reactive
|
||||
|
||||
client.GetAllForRepository(1);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<Activity>>(new Uri("repositories/1/events", UriKind.Relative),
|
||||
gitHubClient.Connection.Received(1).Get<List<Activity>>(new Uri("repositories/1/events", UriKind.Relative),
|
||||
Args.EmptyDictionary, null);
|
||||
}
|
||||
|
||||
@@ -102,7 +102,7 @@ namespace Octokit.Tests.Reactive
|
||||
|
||||
client.GetAllForRepository("fake", "repo", options);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<Activity>>(new Uri("repos/fake/repo/events", UriKind.Relative),
|
||||
gitHubClient.Connection.Received(1).Get<List<Activity>>(new Uri("repos/fake/repo/events", UriKind.Relative),
|
||||
Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
|
||||
}
|
||||
|
||||
@@ -121,7 +121,7 @@ namespace Octokit.Tests.Reactive
|
||||
|
||||
client.GetAllForRepository(1, apiOptions);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<Activity>>(new Uri("repositories/1/events", UriKind.Relative),
|
||||
gitHubClient.Connection.Received(1).Get<List<Activity>>(new Uri("repositories/1/events", UriKind.Relative),
|
||||
Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
|
||||
}
|
||||
|
||||
@@ -156,7 +156,7 @@ namespace Octokit.Tests.Reactive
|
||||
|
||||
client.GetAllIssuesForRepository("fake", "repo");
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repos/fake/repo/issues/events", UriKind.Relative),
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repos/fake/repo/issues/events", UriKind.Relative),
|
||||
Args.EmptyDictionary, null);
|
||||
}
|
||||
|
||||
@@ -168,7 +168,7 @@ namespace Octokit.Tests.Reactive
|
||||
|
||||
client.GetAllIssuesForRepository(1);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repositories/1/issues/events", UriKind.Relative),
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repositories/1/issues/events", UriKind.Relative),
|
||||
Args.EmptyDictionary, null);
|
||||
}
|
||||
|
||||
@@ -187,7 +187,7 @@ namespace Octokit.Tests.Reactive
|
||||
|
||||
client.GetAllIssuesForRepository("fake", "repo", options);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repos/fake/repo/issues/events", UriKind.Relative),
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repos/fake/repo/issues/events", UriKind.Relative),
|
||||
Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
|
||||
}
|
||||
|
||||
@@ -206,7 +206,7 @@ namespace Octokit.Tests.Reactive
|
||||
|
||||
client.GetAllIssuesForRepository(1, options);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repositories/1/issues/events", UriKind.Relative),
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueEvent>>(new Uri("repositories/1/issues/events", UriKind.Relative),
|
||||
Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user