zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-01 10:25:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Release v0.24 - A Sight For Sore Eyes (#1539)

Browse Source 
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
This commit is contained in:
Ryan Gribble
2017-01-17 18:56:55 +10:00
committed by GitHub
parent aa80eaa551
commit 3c818934b8
133 changed files with 434 additions and 416 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests.Integration/Reactive/ObservableCommitStatusClientTests.cs
+4 -4
View File
@@ -12,7 +12,7 @@ namespace Octokit.Tests.Integration.Reactive
readonly ObservableCommitStatusClient _commitStatusClient;
const string owner = "octokit";
const string name = "octokit.net";
const string reference = "1335f37";
const string reference = "1335f37";
public TheGetAllMethod()
{
@@ -37,7 +37,7 @@ namespace Octokit.Tests.Integration.Reactive
PageCount = 1
};
var commitStatus = await _commitStatusClient.GetAll(owner, name ,reference , options).ToList();
var commitStatus = await _commitStatusClient.GetAll(owner, name, reference, options).ToList();
Assert.Equal(2, commitStatus.Count);
}
@@ -75,10 +75,10 @@ namespace Octokit.Tests.Integration.Reactive
StartPage = 2
};
var secondPage = await _commitStatusClient.GetAll(owner, name, reference,skipStartOptions).ToList();
var secondPage = await _commitStatusClient.GetAll(owner, name, reference, skipStartOptions).ToList();
Assert.NotEqual(firstPage[0].Id, secondPage[0].Id);
Assert.NotEqual(firstPage[1].Id, secondPage[1].Id);
Assert.NotEqual(firstPage[1].Id, secondPage[1].Id);
}
}
}