zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-04 03:16:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Release v0.24 - A Sight For Sore Eyes (#1539)

Browse Source 
* Add release notes and bump version to 0.24

* run "build FormatCode" to fix up whitespace/formatting issues

* Fix failing Ssh key tests due to "validation exception".  This key must be in use on github (under another user, most likely from these tests failing).  Changed to a new SSH key and tweaked tests to reduce chance of a key being created and not destroyed

* Assignee and Assignees cant both be specified on NewIssue.  We missed this one in the PR.  Marked Assignee as [Obsolete] and fixed tests to use Assignees

* Fix a couple of Reactions tests that were calling the wrong client methods

* Fix timeline tests - looks like the response class has changed shape a bit, it now has an Issue object in the payload and Id field isnt present (leaving Id field there in case other timeline events do use it)

* Fix some following tests that require the test user to follow more than 1 other user

* Unskip these Event tests now because apparently they work!

* add breaking changes notes

* Update ApiErrorMessageSafe to return null for empty and whitespace strings (#1540)

* return null if ApiError.Message is empty or whitespace

* Uncomment test, which now passes

* update release notes to include PR1540

* Add "Bot" AccountType, was causing a deserialization exception when running the integration test "SearchForExcludedLanguage" (#1541)

* Update to include PR1541

* add bullets to make release notes easier to read

* markup additional code mentions in notes

* Fix grammar

fields => field
This commit is contained in:
Ryan Gribble
2017-01-17 18:56:55 +10:00
committed by GitHub
parent aa80eaa551
commit 3c818934b8
133 changed files with 434 additions and 416 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests.Integration/Reactive/ObservableFollowersClientTests.cs
+19 -8
View File
@@ -1,4 +1,5 @@
using System.Reactive.Linq;
using System;
using System.Reactive.Linq;
using System.Threading.Tasks;
using Octokit.Reactive;
using Xunit;
@@ -9,7 +10,7 @@ namespace Octokit.Tests.Integration.Reactive
{
public class TheGetAllForCurrentMethod
{
readonly ObservableFollowersClient _followersClient;
readonly ObservableFollowersClient _followersClient;
public TheGetAllForCurrentMethod()
{
@@ -18,7 +19,7 @@ namespace Octokit.Tests.Integration.Reactive
_followersClient = new ObservableFollowersClient(github);
}
[IntegrationTest]
[IntegrationTest]
public async Task ReturnsFollowers()
{
var followers = await _followersClient.GetAllForCurrent().ToList();
@@ -30,7 +31,7 @@ namespace Octokit.Tests.Integration.Reactive
public async Task ReturnsCorrectCountOfFollowersWithoutStart()
{
var options = new ApiOptions
{
{
PageSize = 1,
PageCount = 1
};
@@ -75,7 +76,7 @@ namespace Octokit.Tests.Integration.Reactive
var secondFollowersPage = await _followersClient.GetAllForCurrent(skipStartOptions).ToList();
Assert.NotEqual(firstFollowersPage[0].Id, secondFollowersPage[0].Id);
Assert.NotEqual(firstFollowersPage[0].Id, secondFollowersPage[0].Id);
}
}
@@ -153,15 +154,19 @@ namespace Octokit.Tests.Integration.Reactive
}
}
public class TheGetAllFollowingForCurrentMethod
public class TheGetAllFollowingForCurrentMethod : IDisposable
{
readonly ObservableFollowersClient _followersClient;
readonly ObservableFollowersClient _followersClient;
public TheGetAllFollowingForCurrentMethod()
{
var github = Helper.GetAuthenticatedClient();
_followersClient = new ObservableFollowersClient(github);
// Follow someone to set initial state
_followersClient.Follow("alfhenrik").ToList();
_followersClient.Follow("ryangribble").ToList();
}
[IntegrationTest]
@@ -221,7 +226,13 @@ namespace Octokit.Tests.Integration.Reactive
var secondFollowingPage = await _followersClient.GetAllFollowingForCurrent(skipStartOptions).ToList();
Assert.NotEqual(firstFollowingPage[0].Id, secondFollowingPage[0].Id);
Assert.NotEqual(firstFollowingPage[0].Id, secondFollowingPage[0].Id);
}
public void Dispose()
{
_followersClient.Unfollow("alfhenrik");
_followersClient.Unfollow("ryangribble");
}
}