From 3cf54d291c2597bb61ae51ec6d7b37151937bedf Mon Sep 17 00:00:00 2001 From: Kristian Hald Date: Mon, 23 Mar 2015 18:04:39 +0100 Subject: [PATCH] Thought the github api did not correctly add the first event in the list of 'add_events'. Got answer from GitHub that it is because the 'follow' event is no longer supported. --- .../Clients/RepositoryHooksClientTests.cs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs index 2580475c..243716c6 100644 --- a/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs +++ b/Octokit.Tests.Integration/Clients/RepositoryHooksClientTests.cs @@ -78,7 +78,7 @@ namespace Octokit.Tests.Integration.Clients Assert.NotNull(hook.CreatedAt); Assert.NotNull(hook.UpdatedAt); - // TODO: KHA - It seems that even though I provide 'false' to active the response states that it is active + // TODO: KristianHald - It seems that even though I provide 'false' to active, the response states that it is active. Reported to github //Assert.Equal(false, hook.Active); } @@ -105,12 +105,11 @@ namespace Octokit.Tests.Integration.Clients var editRepositoryHook = new EditRepositoryHook { - AddEvents = new[] { "follow", "pull_request" } + AddEvents = new[] { "pull_request" } }; var actualHook = await github.Repository.Hooks.Edit(_fixture.RepositoryOwner, _fixture.RepositoryName, _fixture.ExpectedHook.Id, editRepositoryHook); - // TODO: KHA - It seems that the first AddEvent is either not provided or correctly returned by github - //Assert.Equal(new[] { "delete", "follow", "pull_request" }.ToList(), actualHook.Events.ToList()); + Assert.Equal(new[] { "delete", "pull_request" }.ToList(), actualHook.Events.ToList()); } }