zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-07 20:30:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add repositoryId overloads to methods on I(Observable)RepositoryDeployKeysClient (#1351)

Browse Source
This commit is contained in:
Alexander Efremov
2016-06-18 05:02:28 +07:00
committed by Brendan Forster
parent d941f62904
commit 3d97346672
7 changed files with 608 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Reactive/ObservableRepositoryDeployKeysClientTests.cs
+136 -28
View File
@@ -20,14 +20,25 @@ namespace Octokit.Tests.Reactive
public class TheGetMethod
{
[Fact]
public void CallsIntoClient()
public void RequestsCorrectUrl()
{
var githubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(githubClient);
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
deployKeysClient.Get("user", "repo", 42);
githubClient.Repository.DeployKeys.Received(1).Get("user", "repo", 42);
gitHubClient.Repository.DeployKeys.Received(1).Get("user", "repo", 42);
}
[Fact]
public void RequestsCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
deployKeysClient.Get(1, 42);
gitHubClient.Repository.DeployKeys.Received(1).Get(1, 42);
}
[Fact]
@@ -35,29 +46,30 @@ namespace Octokit.Tests.Reactive
{
var deployKeysClient = new ObservableRepositoryDeployKeysClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Get(null, "repo", 42));
Assert.Throws<ArgumentException>(() => deployKeysClient.Get("", "repo", 42));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Get("user", null, 42));
Assert.Throws<ArgumentException>(() => deployKeysClient.Get("user", "", 42));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Get(null, "repo", 1));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Get("user", null, 1));
Assert.Throws<ArgumentException>(() => deployKeysClient.Get("", "repo", 1));
Assert.Throws<ArgumentException>(() => deployKeysClient.Get("user", "", 1));
}
}
public class TheGetAllMethod
{
[Fact]
public void CallsIntoClient()
public void RequestsCorrectUrl()
{
var githubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(githubClient);
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
deployKeysClient.GetAll("user", "repo");
githubClient.Connection.Received(1).Get<List<DeployKey>>(
gitHubClient.Connection.Received(1).Get<List<DeployKey>>(
new Uri("repos/user/repo/keys", UriKind.Relative), Arg.Is<Dictionary<string, string>>(dictionary => dictionary.Count == 0), null);
}
[Fact]
public void GetsCorrectUrlWithApiOptions()
public void RequestsCorrectUrlWithApiOptions()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
@@ -102,42 +114,96 @@ namespace Octokit.Tests.Reactive
null);
}
[Fact]
public void RequestsCorrectUrlWithRepositoryIdWithApiOptions()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
var expectedUrl = "repositories/1/keys";
// all properties are setted => only 2 options (StartPage, PageSize) in dictionary
var options = new ApiOptions
{
StartPage = 1,
PageCount = 1,
PageSize = 1
};
deployKeysClient.GetAll(1, options);
gitHubClient.Connection.Received(1)
.Get<List<DeployKey>>(Arg.Is<Uri>(u => u.ToString() == expectedUrl),
Arg.Is<IDictionary<string, string>>(dictionary => dictionary.Count == 2),
null);
// StartPage is setted => only 1 option (StartPage) in dictionary
options = new ApiOptions
{
StartPage = 1
};
deployKeysClient.GetAll(1, options);
gitHubClient.Connection.Received(1)
.Get<List<DeployKey>>(Arg.Is<Uri>(u => u.ToString() == expectedUrl),
Arg.Is<IDictionary<string, string>>(dictionary => dictionary.Count == 1),
null);
// PageCount is setted => none of options in dictionary
options = new ApiOptions
{
PageCount = 1
};
deployKeysClient.GetAll(1, options);
gitHubClient.Connection.Received(1)
.Get<List<DeployKey>>(Arg.Is<Uri>(u => u.ToString() == expectedUrl),
Arg.Is<IDictionary<string, string>>(dictionary => dictionary.Count == 0),
null);
}
[Fact]
public void EnsuresNonNullArguments()
{
var deployKeysClient = new ObservableRepositoryDeployKeysClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll(null, null));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll(null, "repo"));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll("user", null));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll(null, null, null));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll(null, null, ApiOptions.None));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll(null, "repo", null));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll("user", null, null));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll(null, "repo", ApiOptions.None));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll("user", null, ApiOptions.None));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll("user", "repo", null));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.GetAll(1, null));
Assert.Throws<ArgumentException>(() => deployKeysClient.GetAll("user", ""));
Assert.Throws<ArgumentException>(() => deployKeysClient.GetAll("", "repo"));
Assert.Throws<ArgumentException>(() => deployKeysClient.GetAll("", "repo", ApiOptions.None));
Assert.Throws<ArgumentException>(() => deployKeysClient.GetAll("user", "", ApiOptions.None));
}
}
public class TheCreateMethod
{
[Fact]
public void CallsIntoClient()
public void CreatesCorrectUrl()
{
var githubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(githubClient);
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
var data = new NewDeployKey { Key = "ABC123", Title = "user@repo" };
deployKeysClient.Create("user", "repo", data);
githubClient.Repository.DeployKeys.Received(1).Create("user", "repo", data);
gitHubClient.Repository.DeployKeys.Received(1).Create("user", "repo", data);
}
[Fact]
public void CreatesCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
var data = new NewDeployKey { Key = "ABC123", Title = "user@repo" };
deployKeysClient.Create(1, data);
gitHubClient.Repository.DeployKeys.Received(1).Create(1, data);
}
[Fact]
@@ -146,12 +212,54 @@ namespace Octokit.Tests.Reactive
var deployKeysClient = new ObservableRepositoryDeployKeysClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Create(null, "repo", new NewDeployKey()));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("", "repo", new NewDeployKey()));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Create("user", null, new NewDeployKey()));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("user", "", new NewDeployKey()));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Create("user", "repo", null));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("user", "repo", new NewDeployKey { Title = "user@repo" }));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Create(1, null));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("", "repo", new NewDeployKey()));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("user", "", new NewDeployKey()));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("user", "repo", new NewDeployKey()));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("user", "repo", new NewDeployKey { Key = "ABC123" }));
Assert.Throws<ArgumentException>(() => deployKeysClient.Create("user", "repo", new NewDeployKey { Title = "user@repo" }));
}
}
public class TheDeleteMethod
{
[Fact]
public void CreatesCorrectUrl()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
deployKeysClient.Delete("user", "repo", 42);
gitHubClient.Repository.DeployKeys.Received(1).Delete("user", "repo", 42);
}
[Fact]
public void CreatesCorrectUrlWithRepositoryId()
{
var gitHubClient = Substitute.For<IGitHubClient>();
var deployKeysClient = new ObservableRepositoryDeployKeysClient(gitHubClient);
deployKeysClient.Delete(1, 42);
gitHubClient.Repository.DeployKeys.Received(1).Delete(1, 42);
}
[Fact]
public void EnsuresNonNullArguments()
{
var deployKeysClient = new ObservableRepositoryDeployKeysClient(Substitute.For<IGitHubClient>());
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Delete(null, "repo", 1));
Assert.Throws<ArgumentNullException>(() => deployKeysClient.Delete("user", null, 1));
Assert.Throws<ArgumentException>(() => deployKeysClient.Delete("", "repo", 1));
Assert.Throws<ArgumentException>(() => deployKeysClient.Delete("user", "", 1));
}
}
}