zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-06 20:13:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

dropped a bunch of async/await usages

Browse Source 
There's also some differences here between using IReadOnlyCollection and
IReadOnlyList. We should decide on one and be consistent
This commit is contained in:
Brendan Forster
2013-10-31 10:35:24 +11:00
parent 9a6a3b2211
commit 451eddc647
13 changed files with 89 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit/Clients/NotificationsClient.cs
+4 -4
View File
@@ -15,9 +15,9 @@ namespace Octokit
/// </summary>
/// <exception cref="AuthorizationException">Thrown if the client is not authenticated.</exception>
/// <returns>A <see cref="IReadOnlyPagedCollection{Notification}"/> of <see cref="Notification"/>.</returns>
public async Task<IReadOnlyCollection<Notification>> GetAllForCurrent()
public Task<IReadOnlyList<Notification>> GetAllForCurrent()
{
return await ApiConnection.GetAll<Notification>(ApiUrls.Notifications());
return ApiConnection.GetAll<Notification>(ApiUrls.Notifications());
}
/// <summary>
@@ -25,9 +25,9 @@ namespace Octokit
/// </summary>
/// <exception cref="AuthorizationException">Thrown if the client is not authenticated.</exception>
/// <returns>A <see cref="IReadOnlyPagedCollection{Notification}"/> of <see cref="Notification"/>.</returns>
public async Task<IReadOnlyCollection<Notification>> GetAllForRepository(string owner, string name)
public Task<IReadOnlyList<Notification>> GetAllForRepository(string owner, string name)
{
return await ApiConnection.GetAll<Notification>(ApiUrls.Notifications(owner, name));
return ApiConnection.GetAll<Notification>(ApiUrls.Notifications(owner, name));
}
}
}