zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-05 19:46:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

autofix tests based on feedback from xunit analyzers (#1997)

Browse Source
This commit is contained in:
Brendan Forster
2019-09-16 19:46:40 -03:00
committed by GitHub
parent 61bd1d1018
commit 45bc5eced7
50 changed files with 222 additions and 232 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Models/MigrationTests.cs
+1 -1
View File
@@ -152,7 +152,7 @@ namespace Octokit.Tests.Models
Assert.Equal("octocat/Hello-World", _migrationReuqest.Repositories[0]);
Assert.Equal(1, _migrationReuqest.Repositories.Count);
Assert.Equal(true, _migrationReuqest.LockRepositories);
Assert.True(_migrationReuqest.LockRepositories);
}
}
}
Octokit.Tests/Models/NewRepositoryWebHookTests.cs
+17 -17
View File
@@ -11,23 +11,23 @@ namespace Octokit.Tests.Models
public void UsesDefaultValuesForDefaultConfig()
{
var create = new NewRepositoryWebHook("windowsazure", new Dictionary<string, string>(), "http://test.com/example");
Assert.Equal(create.Url, "http://test.com/example");
Assert.Equal(create.ContentType, WebHookContentType.Form);
Assert.Equal("http://test.com/example", create.Url);
Assert.Equal(WebHookContentType.Form, create.ContentType);
Assert.Empty(create.Secret);
Assert.False(create.InsecureSsl);
var request = create.ToRequest();
Assert.Equal(request.Config.Count, 4);
Assert.Equal(4, request.Config.Count);
Assert.True(request.Config.ContainsKey("url"));
Assert.True(request.Config.ContainsKey("content_type"));
Assert.True(request.Config.ContainsKey("secret"));
Assert.True(request.Config.ContainsKey("insecure_ssl"));
Assert.Equal(request.Config["url"], "http://test.com/example");
Assert.Equal("http://test.com/example", request.Config["url"]);
Assert.Equal(request.Config["content_type"], WebHookContentType.Form.ToParameter());
Assert.Equal(request.Config["secret"], "");
Assert.Equal(request.Config["insecure_ssl"], "False");
Assert.Equal("", request.Config["secret"]);
Assert.Equal("False", request.Config["insecure_ssl"]);
}
[Fact]
@@ -47,23 +47,23 @@ namespace Octokit.Tests.Models
InsecureSsl = true
};
Assert.Equal(create.Url, "http://test.com/example");
Assert.Equal(create.ContentType, WebHookContentType.Json);
Assert.Equal("http://test.com/example", create.Url);
Assert.Equal(WebHookContentType.Json, create.ContentType);
Assert.Empty(create.Secret);
Assert.True(create.InsecureSsl);
var request = create.ToRequest();
Assert.Equal(request.Config.Count, 7);
Assert.Equal(7, request.Config.Count);
Assert.True(request.Config.ContainsKey("url"));
Assert.True(request.Config.ContainsKey("content_type"));
Assert.True(request.Config.ContainsKey("secret"));
Assert.True(request.Config.ContainsKey("insecure_ssl"));
Assert.Equal(request.Config["url"], "http://test.com/example");
Assert.Equal("http://test.com/example", request.Config["url"]);
Assert.Equal(request.Config["content_type"], WebHookContentType.Json.ToParameter());
Assert.Equal(request.Config["secret"], "");
Assert.Equal("", request.Config["secret"]);
Assert.Equal(request.Config["insecure_ssl"], true.ToString());
Assert.True(request.Config.ContainsKey("hostname"));
@@ -130,8 +130,8 @@ namespace Octokit.Tests.Models
var request = create.ToRequest();
var requestRepeated = create.ToRequest();
Assert.Equal(request.Config.Count, 4);
Assert.Equal(requestRepeated.Config.Count, 4);
Assert.Equal(4, request.Config.Count);
Assert.Equal(4, requestRepeated.Config.Count);
}
[Fact]
@@ -151,8 +151,8 @@ namespace Octokit.Tests.Models
var requestRepeated = create.ToRequest();
//This is not 8, because `url` used in config, is already part of the base config
Assert.Equal(request.Config.Count, 7);
Assert.Equal(requestRepeated.Config.Count, 7);
Assert.Equal(7, request.Config.Count);
Assert.Equal(7, requestRepeated.Config.Count);
}
[Fact]
@@ -167,10 +167,10 @@ namespace Octokit.Tests.Models
var request = create.ToRequest();
Assert.Equal(request.Config["url"], "http://test.com/example");
Assert.Equal("http://test.com/example", request.Config["url"]);
var subsequentRequest = create.ToRequest();
Assert.Equal(subsequentRequest.Config["url"], "http://test.com/example");
Assert.Equal("http://test.com/example", subsequentRequest.Config["url"]);
}
}
}
Octokit.Tests/Models/SearchIssuesRequestExclusionsTests.cs
+13 -13
View File
@@ -28,7 +28,7 @@ public class SearchIssuesRequestExclusionsTests
var request = new SearchIssuesRequestExclusions();
// Ensure the specified parameter does not exist when not set
Assert.False(request.MergedQualifiers().Any(x => x.Contains(property.Key)));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains(property.Key));
// Set the parameter
property.Value(request, "blah");
@@ -42,61 +42,61 @@ public class SearchIssuesRequestExclusionsTests
public void HandlesStateAttributeCorrectly()
{
var request = new SearchIssuesRequestExclusions();
Assert.False(request.MergedQualifiers().Any(x => x.Contains("-state:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("-state:"));
request.State = ItemState.Closed;
Assert.True(request.MergedQualifiers().Contains("-state:closed"));
Assert.Contains("-state:closed", request.MergedQualifiers());
}
[Fact]
public void HandlesExcludeLabelsAttributeCorrectly()
{
var request = new SearchIssuesRequestExclusions();
Assert.False(request.MergedQualifiers().Any(x => x.Contains("-label:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("-label:"));
request.Labels = new[] { "label1", "label2" };
Assert.True(request.MergedQualifiers().Contains("-label:label1"));
Assert.True(request.MergedQualifiers().Contains("-label:label2"));
Assert.Contains("-label:label1", request.MergedQualifiers());
Assert.Contains("-label:label2", request.MergedQualifiers());
}
[Fact]
public void HandlesLanguageAttributeCorrectly()
{
var request = new SearchIssuesRequestExclusions();
Assert.False(request.MergedQualifiers().Any(x => x.Contains("-language:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("-language:"));
request.Language = Language.CSharp;
Assert.True(request.MergedQualifiers().Contains("-language:CSharp"));
Assert.Contains("-language:CSharp", request.MergedQualifiers());
}
[Fact]
public void HandlesStatusAttributeCorrectly()
{
var request = new SearchIssuesRequestExclusions();
Assert.False(request.MergedQualifiers().Any(x => x.Contains("-status:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("-status:"));
request.Status = CommitState.Error;
Assert.True(request.MergedQualifiers().Contains("-status:error"));
Assert.Contains("-status:error", request.MergedQualifiers());
}
[Fact]
public void HandlesMilestoneAttributeWithoutQuotes()
{
var request = new SearchIssuesRequestExclusions();
Assert.False(request.MergedQualifiers().Any(x => x.Contains("-milestone:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("-milestone:"));
request.Milestone = "testMilestone";
Assert.True(request.MergedQualifiers().Contains("-milestone:\"testMilestone\""));
Assert.Contains("-milestone:\"testMilestone\"", request.MergedQualifiers());
}
[Fact]
public void DoesntWrapMilestoneWithDoubleQuotesForQuotedMilestone()
{
var request = new SearchIssuesRequestExclusions();
Assert.False(request.MergedQualifiers().Any(x => x.Contains("-milestone:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("-milestone:"));
request.Milestone = "\"testMilestone\"";
Assert.Contains<string>("-milestone:\"\\\"testMilestone\\\"\"", request.MergedQualifiers());
Octokit.Tests/Models/SearchIssuesRequestTests.cs
+26 -26
View File
@@ -50,7 +50,7 @@ public class SearchIssuesRequestTests
var request = new SearchIssuesRequest("query");
// Ensure the specified parameter does not exist when not set
Assert.False(request.MergedQualifiers().Any(x => x.Contains(property.Key)));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains(property.Key));
// Set the parameter
property.Value(request, "blah");
@@ -76,7 +76,7 @@ public class SearchIssuesRequestTests
var request = new SearchIssuesRequest("query");
// Ensure the specified parameter does not exist when not set
Assert.False(request.MergedQualifiers().Any(x => x.Contains(property.Key)));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains(property.Key));
// Set the parameter
property.Value(request, DateRange.GreaterThan(new DateTimeOffset(DateTime.Today.AddDays(-7))));
@@ -90,48 +90,48 @@ public class SearchIssuesRequestTests
public void HandlesInAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("in:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("in:"));
request.In = new List<IssueInQualifier> { IssueInQualifier.Body, IssueInQualifier.Comment };
Assert.True(request.MergedQualifiers().Contains("in:body,comment"));
Assert.Contains("in:body,comment", request.MergedQualifiers());
}
[Fact]
public void HandlesStateAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("state:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("state:"));
request.State = ItemState.Closed;
Assert.True(request.MergedQualifiers().Contains("state:closed"));
Assert.Contains("state:closed", request.MergedQualifiers());
}
[Fact]
public void HandlesLabelsAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("label:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("label:"));
request.Labels = new[] { "label1", "label2" };
Assert.True(request.MergedQualifiers().Contains("label:label1"));
Assert.True(request.MergedQualifiers().Contains("label:label2"));
Assert.Contains("label:label1", request.MergedQualifiers());
Assert.Contains("label:label2", request.MergedQualifiers());
}
[Fact]
public void HandlesMilestoneAttributeWithoutQuotes()
{
var request = new SearchIssuesRequest("text");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("milestone:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("milestone:"));
request.Milestone = "testMilestone";
Assert.True(request.MergedQualifiers().Contains("milestone:\"testMilestone\""));
Assert.Contains("milestone:\"testMilestone\"", request.MergedQualifiers());
}
[Fact]
public void DoesntWrapMilestoneWithDoubleQuotesForQuotedMilestone()
{
var request = new SearchIssuesRequest("text");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("milestone:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("milestone:"));
request.Milestone = "\"testMilestone\"";
Assert.Contains<string>("milestone:\"\\\"testMilestone\\\"\"", request.MergedQualifiers());
@@ -141,63 +141,63 @@ public class SearchIssuesRequestTests
public void HandlesNoMetadataAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("no:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("no:"));
request.No = IssueNoMetadataQualifier.Milestone;
Assert.True(request.MergedQualifiers().Contains("no:milestone"));
Assert.Contains("no:milestone", request.MergedQualifiers());
}
[Fact]
public void HandlesLanguageAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("language:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("language:"));
request.Language = Language.CSharp;
Assert.True(request.MergedQualifiers().Contains("language:CSharp"));
Assert.Contains("language:CSharp", request.MergedQualifiers());
}
[Fact]
public void HandlesIsAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("is:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("is:"));
request.Is = new List<IssueIsQualifier> { IssueIsQualifier.Merged, IssueIsQualifier.PullRequest };
Assert.True(request.MergedQualifiers().Contains("is:merged"));
Assert.True(request.MergedQualifiers().Contains("is:pr"));
Assert.Contains("is:merged", request.MergedQualifiers());
Assert.Contains("is:pr", request.MergedQualifiers());
}
[Fact]
public void HandlesStatusAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("status:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("status:"));
request.Status = CommitState.Error;
Assert.True(request.MergedQualifiers().Contains("status:error"));
Assert.Contains("status:error", request.MergedQualifiers());
}
[Fact]
public void HandlesCommentsAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("comments:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("comments:"));
request.Comments = Range.GreaterThan(5);
Assert.True(request.MergedQualifiers().Contains("comments:>5"));
Assert.Contains("comments:>5", request.MergedQualifiers());
}
[Fact]
public void HandlesRepoAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("repo:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("repo:"));
request.Repos.Add("myorg", "repo1");
request.Repos.Add("myorg", "repo2");
Assert.True(request.MergedQualifiers().Contains("repo:myorg/repo1"));
Assert.True(request.MergedQualifiers().Contains("repo:myorg/repo2"));
Assert.Contains("repo:myorg/repo1", request.MergedQualifiers());
Assert.Contains("repo:myorg/repo2", request.MergedQualifiers());
}
}
}