autofix tests based on feedback from xunit analyzers (#1997)

This commit is contained in:
Brendan Forster
2019-09-16 19:46:40 -03:00
committed by GitHub
parent 61bd1d1018
commit 45bc5eced7
50 changed files with 222 additions and 232 deletions

View File

@@ -50,7 +50,7 @@ public class SearchIssuesRequestTests
var request = new SearchIssuesRequest("query");
// Ensure the specified parameter does not exist when not set
Assert.False(request.MergedQualifiers().Any(x => x.Contains(property.Key)));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains(property.Key));
// Set the parameter
property.Value(request, "blah");
@@ -76,7 +76,7 @@ public class SearchIssuesRequestTests
var request = new SearchIssuesRequest("query");
// Ensure the specified parameter does not exist when not set
Assert.False(request.MergedQualifiers().Any(x => x.Contains(property.Key)));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains(property.Key));
// Set the parameter
property.Value(request, DateRange.GreaterThan(new DateTimeOffset(DateTime.Today.AddDays(-7))));
@@ -90,48 +90,48 @@ public class SearchIssuesRequestTests
public void HandlesInAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("in:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("in:"));
request.In = new List<IssueInQualifier> { IssueInQualifier.Body, IssueInQualifier.Comment };
Assert.True(request.MergedQualifiers().Contains("in:body,comment"));
Assert.Contains("in:body,comment", request.MergedQualifiers());
}
[Fact]
public void HandlesStateAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("state:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("state:"));
request.State = ItemState.Closed;
Assert.True(request.MergedQualifiers().Contains("state:closed"));
Assert.Contains("state:closed", request.MergedQualifiers());
}
[Fact]
public void HandlesLabelsAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("label:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("label:"));
request.Labels = new[] { "label1", "label2" };
Assert.True(request.MergedQualifiers().Contains("label:label1"));
Assert.True(request.MergedQualifiers().Contains("label:label2"));
Assert.Contains("label:label1", request.MergedQualifiers());
Assert.Contains("label:label2", request.MergedQualifiers());
}
[Fact]
public void HandlesMilestoneAttributeWithoutQuotes()
{
var request = new SearchIssuesRequest("text");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("milestone:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("milestone:"));
request.Milestone = "testMilestone";
Assert.True(request.MergedQualifiers().Contains("milestone:\"testMilestone\""));
Assert.Contains("milestone:\"testMilestone\"", request.MergedQualifiers());
}
[Fact]
public void DoesntWrapMilestoneWithDoubleQuotesForQuotedMilestone()
{
var request = new SearchIssuesRequest("text");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("milestone:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("milestone:"));
request.Milestone = "\"testMilestone\"";
Assert.Contains<string>("milestone:\"\\\"testMilestone\\\"\"", request.MergedQualifiers());
@@ -141,63 +141,63 @@ public class SearchIssuesRequestTests
public void HandlesNoMetadataAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("no:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("no:"));
request.No = IssueNoMetadataQualifier.Milestone;
Assert.True(request.MergedQualifiers().Contains("no:milestone"));
Assert.Contains("no:milestone", request.MergedQualifiers());
}
[Fact]
public void HandlesLanguageAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("language:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("language:"));
request.Language = Language.CSharp;
Assert.True(request.MergedQualifiers().Contains("language:CSharp"));
Assert.Contains("language:CSharp", request.MergedQualifiers());
}
[Fact]
public void HandlesIsAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("is:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("is:"));
request.Is = new List<IssueIsQualifier> { IssueIsQualifier.Merged, IssueIsQualifier.PullRequest };
Assert.True(request.MergedQualifiers().Contains("is:merged"));
Assert.True(request.MergedQualifiers().Contains("is:pr"));
Assert.Contains("is:merged", request.MergedQualifiers());
Assert.Contains("is:pr", request.MergedQualifiers());
}
[Fact]
public void HandlesStatusAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("status:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("status:"));
request.Status = CommitState.Error;
Assert.True(request.MergedQualifiers().Contains("status:error"));
Assert.Contains("status:error", request.MergedQualifiers());
}
[Fact]
public void HandlesCommentsAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("comments:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("comments:"));
request.Comments = Range.GreaterThan(5);
Assert.True(request.MergedQualifiers().Contains("comments:>5"));
Assert.Contains("comments:>5", request.MergedQualifiers());
}
[Fact]
public void HandlesRepoAttributeCorrectly()
{
var request = new SearchIssuesRequest("test");
Assert.False(request.MergedQualifiers().Any(x => x.Contains("repo:")));
Assert.DoesNotContain(request.MergedQualifiers(), x => x.Contains("repo:"));
request.Repos.Add("myorg", "repo1");
request.Repos.Add("myorg", "repo2");
Assert.True(request.MergedQualifiers().Contains("repo:myorg/repo1"));
Assert.True(request.MergedQualifiers().Contains("repo:myorg/repo2"));
Assert.Contains("repo:myorg/repo1", request.MergedQualifiers());
Assert.Contains("repo:myorg/repo2", request.MergedQualifiers());
}
}
}