zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-08 04:40:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove Type parameter for IHttpClient send method

Browse Source 
This keeps the IHttpClient interface simpler and ensures the
deserialization responsibility lies outside of that class. It only
needed the Type parameter for a special case that could be handled in a
better way.
This commit is contained in:
Haacked
2015-01-01 19:12:22 -08:00
parent 37dec8491c
commit 49f95d40f1
16 changed files with 183 additions and 152 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Http/HttpClientAdapterTests.cs
+11 -9
View File
@@ -4,11 +4,11 @@ using System.IO;
using System.Linq;
using System.Net;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Text;
using System.Threading.Tasks;
using Octokit.Internal;
using Xunit;
using Xunit.Extensions;
namespace Octokit.Tests.Http
{
@@ -120,7 +120,7 @@ namespace Octokit.Tests.Http
};
var tester = new HttpClientAdapterTester();
var response = await tester.BuildResponseTester<object>(responseMessage);
var response = await tester.BuildResponseTester(responseMessage);
var firstHeader = response.Headers.First();
Assert.Equal("peanut", firstHeader.Key);
@@ -141,25 +141,27 @@ namespace Octokit.Tests.Http
StatusCode = HttpStatusCode.OK,
Content = new ByteArrayContent(new byte[] { 0, 1, 1, 0, 1}),
};
responseMessage.Content.Headers.ContentType = new MediaTypeHeaderValue("image/png");
var tester = new HttpClientAdapterTester();
var response = await tester.BuildResponseTester<byte[]>(responseMessage);
var response = await tester.BuildResponseTester(responseMessage);
Assert.Equal(new byte[] { 0, 1, 1, 0, 1 }, response.BodyAsObject);
Assert.Null(response.Body);
Assert.Null(response.ContentType);
Assert.Equal("image/png", response.ContentType);
}
public async Task SetsContentType(HttpStatusCode httpStatusCode)
[Fact]
public async Task SetsContentType()
{
var responseMessage = new HttpResponseMessage
{
StatusCode = httpStatusCode,
StatusCode = HttpStatusCode.OK,
Content = new StringContent("{}", Encoding.UTF8, "application/json"),
};
var tester = new HttpClientAdapterTester();
var response = await tester.BuildResponseTester<object>(responseMessage);
var response = await tester.BuildResponseTester(responseMessage);
Assert.Equal("application/json", response.ContentType);
}
@@ -172,9 +174,9 @@ namespace Octokit.Tests.Http
return BuildRequestMessage(request);
}
public async Task<IResponse<T>> BuildResponseTester<T>(HttpResponseMessage responseMessage)
public async Task<IResponse> BuildResponseTester(HttpResponseMessage responseMessage)
{
return await BuildResponse<T>(responseMessage);
return await BuildResponse(responseMessage);
}
}
}