remove all usages of TaskFactory in test suite (#2164)

This commit is contained in:
Brendan Forster
2020-03-31 16:57:16 -03:00
committed by GitHub
parent b54091376d
commit 4b0e7255b1
18 changed files with 219 additions and 179 deletions
@@ -301,11 +301,11 @@ public class ObservableIssuesClientTests
&& d["state"] == "open"
&& d["sort"] == "created"
&& d["filter"] == "assigned"), Arg.Any<string>())
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => firstPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(firstPageResponse));
gitHubClient.Connection.Get<List<Issue>>(secondPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => secondPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(secondPageResponse));
gitHubClient.Connection.Get<List<Issue>>(thirdPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => lastPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(lastPageResponse));
var client = new ObservableIssuesClient(gitHubClient);
var results = await client.GetAllForRepository("fake", "repo").ToArray();
@@ -378,11 +378,11 @@ public class ObservableIssuesClientTests
&& d["sort"] == "created"
&& d["filter"] == "assigned"),
"application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => firstPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(firstPageResponse));
gitHubClient.Connection.Get<List<Issue>>(secondPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => secondPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(secondPageResponse));
gitHubClient.Connection.Get<List<Issue>>(thirdPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => lastPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(lastPageResponse));
var client = new ObservableIssuesClient(gitHubClient);
var results = await client.GetAllForOwnedAndMemberRepositories().ToArray();
@@ -464,11 +464,11 @@ public class ObservableIssuesClientTests
&& d["state"] == "open"
&& d["sort"] == "created"
&& d["filter"] == "assigned"), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => firstPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(firstPageResponse));
gitHubClient.Connection.Get<List<Issue>>(secondPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => secondPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(secondPageResponse));
gitHubClient.Connection.Get<List<Issue>>(thirdPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => lastPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(lastPageResponse));
var client = new ObservableIssuesClient(gitHubClient);
@@ -537,11 +537,11 @@ public class ObservableIssuesClientTests
&& d["state"] == "open"
&& d["sort"] == "created"
&& d["filter"] == "assigned"), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => firstPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(firstPageResponse));
gitHubClient.Connection.Get<List<Issue>>(secondPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => secondPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(secondPageResponse));
gitHubClient.Connection.Get<List<Issue>>(thirdPageUrl, Arg.Any<Dictionary<string, string>>(), "application/vnd.github.squirrel-girl-preview+json")
.Returns(Task.Factory.StartNew<IApiResponse<List<Issue>>>(() => lastPageResponse));
.Returns(Task.FromResult<IApiResponse<List<Issue>>>(lastPageResponse));
var client = new ObservableIssuesClient(gitHubClient);
var results = await client.GetAllForCurrent().ToArray();