zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-04 19:26:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

IApiResponse no longer inherits IResponse

Browse Source
This commit is contained in:
Haacked
2015-01-01 20:37:52 -08:00
parent 09d5c236a4
commit 4c8bab20eb
42 changed files with 383 additions and 397 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Exceptions/ApiExceptionTests.cs
+5 -5
View File
@@ -44,7 +44,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void CreatesGitHubErrorFromJsonResponse()
{
var response = new ApiResponse<object>
var response = new Response
{
Body = @"{""errors"":[{""code"":""custom"",""field"":""key"",""message"":""key is " +
@"already in use"",""resource"":""PublicKey""}],""message"":""Validation Failed""}",
@@ -65,7 +65,7 @@ namespace Octokit.Tests.Exceptions
[InlineData("<html><body><h1>502 Bad Gateway</h1>The server returned an invalid or incomplete response.</body></html>")]
public void CreatesGitHubErrorIfResponseMessageIsNotValidJson(string responseContent)
{
var response = new ApiResponse<object>
var response = new Response
{
Body = responseContent,
StatusCode = HttpStatusCode.GatewayTimeout
@@ -84,8 +84,8 @@ namespace Octokit.Tests.Exceptions
response.Body.Returns("test");
var exception = new ApiException();
var anotherException = new ApiException(new ApiResponse<object> { Body = "message1" });
var thirdException = new ApiException(new ApiResponse<object> { Body = "message2" });
var anotherException = new ApiException(new Response { Body = "message1" });
var thirdException = new ApiException(new Response { Body = "message2" });
// It's fine if the message is null when there's no response body as long as this doesn't throw.
Assert.Null(exception.ApiError.Message);
@@ -97,7 +97,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void CanPopulateObjectFromSerializedData()
{
var response = new ApiResponse<object>
var response = new Response
{
Body = @"{""errors"":[{""code"":""custom"",""field"":""key"",""message"":""key is " +
@"already in use"",""resource"":""PublicKey""}],""message"":""Validation Failed""}",
Octokit.Tests/Exceptions/ApiValidationExceptionTests.cs
+3 -3
View File
@@ -14,7 +14,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void CreatesGitHubErrorFromJsonResponse()
{
var response = new ApiResponse<object>
var response = new Response
{
Body = @"{""errors"":[{""code"":""custom"",""field"":""key"",""message"":""key is " +
@"already in use"",""resource"":""PublicKey""}],""message"":""Validation Failed""}",
@@ -30,7 +30,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void ProvidesDefaultMessage()
{
var response = new ApiResponse<object>
var response = new Response
{
StatusCode = (HttpStatusCode)422
};
@@ -44,7 +44,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void CanPopulateObjectFromSerializedData()
{
var response = new ApiResponse<object>
var response = new Response
{
Body = @"{""errors"":[{""code"":""custom"",""field"":""key"",""message"":""key is " +
@"already in use"",""resource"":""PublicKey""}],""message"":""Validation Failed""}",
Octokit.Tests/Exceptions/ForbiddenExceptionTests.cs
+2 -2
View File
@@ -13,7 +13,7 @@ namespace Octokit.Tests.Exceptions
{
const string responseBody = "{\"message\":\"YOU SHALL NOT PASS!\"," +
"\"documentation_url\":\"http://developer.github.com/v3\"}";
var response = new ApiResponse<object> { Body = responseBody, StatusCode = HttpStatusCode.Forbidden };
var response = new Response { Body = responseBody, StatusCode = HttpStatusCode.Forbidden };
var forbiddenException = new ForbiddenException(response);
Assert.Equal("YOU SHALL NOT PASS!", forbiddenException.ApiError.Message);
@@ -22,7 +22,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void HasDefaultMessage()
{
var response = new ApiResponse<object> { StatusCode = HttpStatusCode.Forbidden };
var response = new Response { StatusCode = HttpStatusCode.Forbidden };
var forbiddenException = new ForbiddenException(response);
Assert.Equal("Request Forbidden", forbiddenException.Message);
Octokit.Tests/Exceptions/LoginAttemptsExceededExceptionTests.cs
+1 -1
View File
@@ -16,7 +16,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void SetsDefaultMessage()
{
var response = new ApiResponse<object>
var response = new Response
{
StatusCode = HttpStatusCode.Forbidden
};
Octokit.Tests/Exceptions/RateLimitExceededExceptionTests.cs
+4 -5
View File
@@ -4,7 +4,6 @@ using System.Globalization;
using System.IO;
using System.Net;
using System.Runtime.Serialization.Formatters.Binary;
using Octokit.Internal;
using Xunit;
namespace Octokit.Tests.Exceptions
@@ -16,7 +15,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void ParsesRateLimitsFromHeaders()
{
var response = new ApiResponse<object> { StatusCode = HttpStatusCode.Forbidden };
var response = new Response { StatusCode = HttpStatusCode.Forbidden };
response.Headers.Add("X-RateLimit-Limit", "100");
response.Headers.Add("X-RateLimit-Remaining", "42");
response.Headers.Add("X-RateLimit-Reset", "1372700873");
@@ -38,7 +37,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void HandlesInvalidHeaderValues()
{
var response = new ApiResponse<object> { StatusCode = HttpStatusCode.Forbidden };
var response = new Response { StatusCode = HttpStatusCode.Forbidden };
response.Headers.Add("X-RateLimit-Limit", "XXX");
response.Headers.Add("X-RateLimit-Remaining", "XXXX");
response.Headers.Add("X-RateLimit-Reset", "XXXX");
@@ -58,7 +57,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void HandlesMissingHeaderValues()
{
var response = new ApiResponse<object>
var response = new Response
{
StatusCode = HttpStatusCode.Forbidden
};
@@ -79,7 +78,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void CanPopulateObjectFromSerializedData()
{
var response = new ApiResponse<object> { StatusCode = HttpStatusCode.Forbidden };
var response = new Response { StatusCode = HttpStatusCode.Forbidden };
response.Headers.Add("X-RateLimit-Limit", "100");
response.Headers.Add("X-RateLimit-Remaining", "42");
response.Headers.Add("X-RateLimit-Reset", "1372700873");
Octokit.Tests/Exceptions/TwoFactorRequiredExceptionTests.cs
+1 -1
View File
@@ -16,7 +16,7 @@ namespace Octokit.Tests.Exceptions
[Fact]
public void SetsDefaultMessage()
{
var response = new ApiResponse<object>
var response = new Response
{
StatusCode = HttpStatusCode.Unauthorized
};