Implement Check Suites API (#1846)

* Check run request models

* Check Run response models

* Check run clients

* Check run ApiUrls and AcceptHeaders

* Pack it all together for now

* Add missing accept headers to connection calls

* Standardize class definitions

* Standardize function names

* Merge ICheckRunAnnotationsClient into ICheckRunsClient

* Properly organize clients

* Cleanup CheckRun response model

* Fix slug check run urls

* Add checks installation permission

* Use StringEnums where appropriate

* Cleanup check run output models

* Flesh out CheckSuite model

* Delete CheckRunsList

* Remove a sealed, fix some line endings

* Adding check suite models

* Skeleton check suite client implementation

* Add check suite ApiUrls

* Flesh out check suites client

* Add parameterless CheckRun constructor

* Add DebuggerDisplay to checks models

* Add observable checks interfaces

* Add return values to POST and PATCH check clients

* Fix some check suite client return values

* Skeleton reactive checks implementation

* Implement observable checks clients

* Remove rogue tabs

* Add CheckSuiteEventPayload

* Add CheckRunEventPayload

* Add DebuggerDisplay attributes to checks API payloads

* Properly nullables check suite/run conclusion

* Add CheckSuiteEventTests

* Fix checks client accessor naming issues

* Add missing Text field to CheckRunOutput

* Marks CheckRunUpdate's conclusion as nullable

* Fix reactive checks client naming

* Today I learned DateTimeOffset is a struct

Makes CheckRunUpdate's DateTimeOffsets nullable

* Modify check clients to put slug version before repo id version

* Add nullable to CheckRun.CompletedAt

* Implement parameterless ICheckRunsClient.GetAllForReference and GetAllForCheckSuite

* Add missing RequestParameters base to CheckSuiteRequest

* Implement checks API GetAll methods

* Bring parity to Reactive checks clients

* fix project settings to get GitHubApp helper working again

* remove un-needed InstallationId setting - provide helper method to find installation based on owner

* fix up request object ctors based on required/optional parameters

* fix up request object ctors based on required/optional parameters

* add some initial integration tests for CheckSuites and CheckRuns including some helper methods

* Add test for Request CheckSuite
Fix Request CheckSuite to use correct Uri
Fix Request CheckSuite return type as it doesnt return an object
Fix CheckSuiteTriggerRequest ctor to make required fields mandatory

* simplify Get CheckSuite test to not require as much data setup

* Add test for CheckSuite GetAllForReference

* Add test for CheckSuite UpdatePreferences

* rename response models

* rename CheckSuitesList to CheckSuitesResponse and use as response to the GetAll calls

* Fix tests

* Fix observable

* fix model convention tests

* remove CheckRuns so we can focus only on CheckSuites for now

* naming things is hard

* oh so many unit tests for CheckSuites methods

* make client mockable

* Fix issue with .Max() when no results returned

* fix request parameter names

* add Xml doc comments

* Add XmlDoc comments to request/common model objects

* rename class to match usage

* tidy ups

* xmldoc for observable clients

* fix method order

* add observable unit tests and get them passing

* Add Observable unit tests and get them passing

* add observable integration tests

* tidy up ApiUrl method name

* whitespace/using tidy ups

* Ensure CheckSuiteEventPayload class is handled in deserializer and add to activity test

* add response model XmlDoc comments

* missed one xmldoc

* add xmldoc to NewCheckSuite request and remove HeadBranch property as it doesnt exist anymore

* add some extra check suites integration tests
This commit is contained in:
Ryan Gribble
2018-07-14 20:01:41 +10:00
committed by GitHub
parent 043e64b89f
commit 4df21a61de
39 changed files with 2905 additions and 13 deletions
+61 -5
View File
@@ -2,7 +2,9 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;
namespace Octokit.Tests.Integration
{
@@ -171,11 +173,6 @@ namespace Octokit.Tests.Integration
get { return Environment.GetEnvironmentVariable("OCTOKIT_GITHUBAPP_SLUG"); }
}
public static long GitHubAppInstallationId
{
get { return Convert.ToInt64(Environment.GetEnvironmentVariable("OCTOKIT_GITHUBAPP_INSTALLATIONID")); }
}
public static void DeleteRepo(IConnection connection, Repository repository)
{
if (repository != null)
@@ -304,6 +301,28 @@ namespace Octokit.Tests.Integration
};
}
public static Installation GetGitHubAppInstallationForOwner(string owner)
{
var client = GetAuthenticatedGitHubAppsClient();
var installations = client.GitHubApps.GetAllInstallationsForCurrent().Result;
var installation = installations.First(x => x.Account.Login == owner);
return installation;
}
public static GitHubClient GetAuthenticatedGitHubAppInstallationForOwner(string owner)
{
var client = GetAuthenticatedGitHubAppsClient();
var installation = GetGitHubAppInstallationForOwner(owner);
var token = client.GitHubApps.CreateInstallationToken(installation.Id).Result.Token;
return new GitHubClient(new ProductHeaderValue("OctokitTests"), TargetUrl)
{
Credentials = new Credentials(token)
};
}
public static void DeleteInvitations(IConnection connection, List<string> invitees, int teamId)
{
try
@@ -327,5 +346,42 @@ namespace Octokit.Tests.Integration
return login;
}
public async static Task<Reference> CreateFeatureBranch(string owner, string repo, string parentSha, string branchName)
{
var github = Helper.GetAuthenticatedClient();
// Create content blob
var baselineBlob = new NewBlob
{
Content = "I am overwriting this blob with something new",
Encoding = EncodingType.Utf8
};
var baselineBlobResult = await github.Git.Blob.Create(owner, repo, baselineBlob);
// Create tree item
var treeItem = new NewTreeItem
{
Type = TreeType.Blob,
Mode = FileMode.File,
Path = "README.md",
Sha = baselineBlobResult.Sha
};
// Create tree
var newTree = new NewTree();
newTree.Tree.Add(treeItem);
var tree = await github.Git.Tree.Create(owner, repo, newTree);
// Create commit
var newCommit = new NewCommit("this is the new commit", tree.Sha, parentSha);
var commit = await github.Git.Commit.Create(owner, repo, newCommit);
// Create branch
var branch = await github.Git.Reference.Create(owner, repo, new NewReference($"refs/heads/{branchName}", commit.Sha));
// Return commit
return branch;
}
}
}